From patchwork Thu Dec 12 11:17:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Cui, LunyuanX" X-Patchwork-Id: 63784 X-Patchwork-Delegate: xiaolong.ye@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B95FAA04F5; Thu, 12 Dec 2019 04:20:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7509E1BE9D; Thu, 12 Dec 2019 04:20:15 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E120E2BD3; Thu, 12 Dec 2019 04:20:13 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 19:20:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,304,1571727600"; d="scan'208";a="220600191" Received: from intel.sh.intel.com ([10.239.255.129]) by fmsmga001.fm.intel.com with ESMTP; 11 Dec 2019 19:20:10 -0800 From: Lunyuan Cui To: dev@dpdk.org Cc: Wenzhuo Lu , Qiming Yang , Lunyuan Cui , stable@dpdk.org Date: Thu, 12 Dec 2019 11:17:14 +0000 Message-Id: <20191212111714.533-1-lunyuanx.cui@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] net/ixgbe: fixed port can not link up in FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In FreeBSD environment, nic_uio drivers do not support interrupts, rte_intr_callback_register() will fail to register interrupts. We can not make link status to change from down to up by interrupt callback. So we need to wait for the controller to acquire link when ports start. Through multiple tests, 5s should be enough. Fixes: b9bd0f09fa15 ("ethdev: fix link status query") Cc: stable@dpdk.org Signed-off-by: Lunyuan Cui --- drivers/net/ixgbe/ixgbe_ethdev.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 2c6fd0f13..e33b5483c 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -2555,6 +2555,9 @@ ixgbe_dev_start(struct rte_eth_dev *dev) IXGBE_DEV_PRIVATE_TO_TM_CONF(dev->data->dev_private); struct ixgbe_macsec_setting *macsec_setting = IXGBE_DEV_PRIVATE_TO_MACSEC_SETTING(dev->data->dev_private); +#ifdef RTE_EXEC_ENV_FREEBSD + int i; +#endif PMD_INIT_FUNC_TRACE(); @@ -2801,6 +2804,25 @@ ixgbe_dev_start(struct rte_eth_dev *dev) "please call hierarchy_commit() " "before starting the port"); +#ifdef RTE_EXEC_ENV_FREEBSD + /* + * In freebsd environment, nic_uio drivers do not support interrupts, + * rte_intr_callback_register() will fail to register interrupts. + * We can not make link status to change from down to up by interrupt + * callback. So we need to wait for the controller to acquire link + * when ports start. + */ + for (i = 0; i < 25; i++) { + /* If link up, just jump out */ + err = ixgbe_check_link(hw, &speed, &link_up, 0); + if (err) + goto error; + if (link_up) + break; + msec_delay(200); + } +#endif + /* * Update link status right before return, because it may * start link configuration process in a separate thread.