From patchwork Tue Feb 11 13:20:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wisam Jaddo X-Patchwork-Id: 65730 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1FB2A051C; Tue, 11 Feb 2020 14:20:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 00EBD2BA2; Tue, 11 Feb 2020 14:20:17 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130088.outbound.protection.outlook.com [40.107.13.88]) by dpdk.org (Postfix) with ESMTP id 2285EB62 for ; Tue, 11 Feb 2020 14:20:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VbVhLUTSDmX2Vf8nomQdmYwT+t5fArDDBUBs5CBS4CUK/TvzEExXrmH+x77+MicRUelEM3WVv1mTnKxcBof72CXq6o419wlx1rT796DRtnv6PG2kNNtXCYRJqXxF4UT14N9AnwCHadb9Wi57NeMFlPLtdIUNvh3NoSkntPsrGtv1jpn1Z0mydR6yjfmMyxgkRLdMzHQ+T4y3+o9fFBDB+2hn73ljUPMvQZojOVu7YGsNYdZD+jNiQ6FAZ6w4HicUM6/KUiJmZB/9ksu6MMuwxzq96CeDx8kqwkPejzifUhOym1XErrvQzF3qbgKwB/8jcBsttxbipYSrIgnzYVHt+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2E9kFu+itUcYPHLjnhTv4b+BjqWwVwR/mZJxK7X3+qE=; b=UesqbdMGMpPGExM2kNViviNAxFqAUIExXhzXjbFblSXU51fGf8Exo2gF1z24XHBm90Ic8s322/9OQAmf/iAZHyhA4DY7uOvW3ELGcdkbwhMfT3x31fiL0Ro3FBMtUMyb/nPeEKO9dz6hS5i1auW1+b9hNpaJp3qgGo1DYIPHcAiSYm7zx+uZJO0FhxGY2yJQvw8N7kiiSde5RDPQUyHKmvvpTCYq7dRgfztqzUmDz01tmquENLncYpecUjEC78TARmfLSSX3W9BeC+XD+JhLfJb8lHcMnDSX6r7Psdc2ZzUeS9H3Y5pCA0H097ebVNOO5QpGTEtugv+xK/nGgXrnQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2E9kFu+itUcYPHLjnhTv4b+BjqWwVwR/mZJxK7X3+qE=; b=AlMCE5OCRoWSuTGxOVdstG7x5bKW/aGqRmAHbwhgsbQV08ft2+5HZwnAxO137IXDc9tSSH3IPYG63Bp04iKbWl3DmhwoLLk6RBW3wbm4f8a1N2dMHRo7LtMYcW31dRpcOiyHpWAmlx/LfUpdK/dUb1DiKQx5aMB7MSW83Mbcsus= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=wisamm@mellanox.com; Received: from AM0PR05MB6610.eurprd05.prod.outlook.com (20.178.202.18) by AM0PR05MB5268.eurprd05.prod.outlook.com (20.178.17.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.23; Tue, 11 Feb 2020 13:20:15 +0000 Received: from AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::f9b0:5b27:21a3:c758]) by AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::f9b0:5b27:21a3:c758%3]) with mapi id 15.20.2707.030; Tue, 11 Feb 2020 13:20:15 +0000 From: Wisam Jaddo To: matan@mellanox.com, viacheslavo@mellanox.com, rasland@mellanox.com Cc: dev@dpdk.org, dekelp@mellanox.com Date: Tue, 11 Feb 2020 15:20:06 +0200 Message-Id: <1581427206-3434-1-git-send-email-wisamm@mellanox.com> X-Mailer: git-send-email 2.7.4 X-ClientProxiedBy: PR0P264CA0067.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1d::31) To AM0PR05MB6610.eurprd05.prod.outlook.com (2603:10a6:208:12f::18) MIME-Version: 1.0 Received: from mellanox.com (37.142.13.130) by PR0P264CA0067.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1d::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2707.23 via Frontend Transport; Tue, 11 Feb 2020 13:20:14 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [37.142.13.130] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: c128c566-065c-4dac-d15d-08d7aef521ab X-MS-TrafficTypeDiagnostic: AM0PR05MB5268:|AM0PR05MB5268: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2276; X-Forefront-PRVS: 0310C78181 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(396003)(39860400002)(136003)(376002)(199004)(189003)(8936002)(478600001)(8676002)(2906002)(956004)(66946007)(16526019)(6666004)(2616005)(186003)(66476007)(66556008)(316002)(6636002)(26005)(81156014)(8886007)(52116002)(107886003)(86362001)(55016002)(36756003)(7696005)(4744005)(5660300002)(4326008)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB5268; H:AM0PR05MB6610.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dj7n6UuLgzcU5OptxTEafojqTLyFDVUJleDc+6jlftF6dgl3CaaAtT4wX0YxapgLLLSkv+s+VAzne55GA1zFKfODNtgMKsXjMesjykXep5qbhAGeGoF+cbqG4HwEL1goPHb8J585ZoUzphQo+L0Buan/LvcxG23TXa1CDvUaDZ0OLW3XcrEKHH2Clc9dbsyAIcnIQsFZ1zj60Bgzb1D/REnGGuBNObyJ52j9HVBrWpx+IDiwEIsNOVtIGRBqeEyM6SX+bP0EC7GprC2BQo38k2DGuKbqZNNUcw3O8eW4ZkuBoGwg+kMSSVYAtxiqREbC45iLEby1jSnrpb5mhlgG6xXj3LfMADQT/oucZrlg5PQCsj94oqcKC/bELxZ79Rrc9LMYMZQRL9ZpKtw3Q/76fJi40ZJSpVxPnNSW14auik7hn6MsJkeSenNoP30PIn9Q X-MS-Exchange-AntiSpam-MessageData: y74ze4LJqXosyFQWxTLSuakQQj5HoLzOq1TaR09BHoJBsvNFu88HrqJx1WciBc+KKauM37PAuFcc3aOthBUEx0YDELKpaEn5QiD55+dTTMOE8KoLtpW7n7jOSMUR7A8o5YBlkSrqAhhtnuSZ9RXe6A== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c128c566-065c-4dac-d15d-08d7aef521ab X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2020 13:20:15.3911 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /wTvxoy0YsPoC/RbN8gBV9808le2KPToVdv1zHHnWHDAHwXq2B9qu/AmVhIYoS1fWPKH2Rc7OJmq1XA2uKcVvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5268 Subject: [dpdk-dev] [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The blocker should take FDB into consideration, since FDB all directions have transfer ingress in it. Fixes: 55060e62e4d2 ("net/mlx5: block push VLAN action on Rx") Cc: dekelp@mellanox.com Signed-off-by: Wisam Jaddo Acked-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index e71b3b5..c986f25 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -1746,7 +1746,7 @@ flow_dv_validate_action_push_vlan(uint64_t action_flags, { const struct rte_flow_action_of_push_vlan *push_vlan = action->conf; - if (attr->ingress) + if (!attr->transfer && attr->ingress) return rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ATTR_INGRESS, NULL,