From patchwork Fri Feb 14 00:52:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Zhang X-Patchwork-Id: 65804 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D3CDA0546; Fri, 14 Feb 2020 01:59:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E0BA1BFF9; Fri, 14 Feb 2020 01:59:37 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D259A1BFF5 for ; Fri, 14 Feb 2020 01:59:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2020 16:59:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,438,1574150400"; d="scan'208";a="281682965" Received: from npg-dpdk-zhangxiao.sh.intel.com ([10.67.110.218]) by FMSMGA003.fm.intel.com with ESMTP; 13 Feb 2020 16:59:33 -0800 From: Xiao Zhang To: dev@dpdk.org Cc: orika@mellanox.com, qi.z.zhang@intel.com, simei.su@intel.com, bernard.iremonger@intel.com, Xiao Zhang Date: Fri, 14 Feb 2020 08:52:44 +0800 Message-Id: <1581641564-58542-1-git-send-email-xiao.zhang@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1581570460-27068-1-git-send-email-xiao.zhang@intel.com> References: <1581570460-27068-1-git-send-email-xiao.zhang@intel.com> Subject: [dpdk-dev] [v2] app/testpmd: parse flow command line for AH X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add AH and AH SPI to testpmd rte flow command line. Add note and sample AH rules in testpmd guide. Signed-off-by: Xiao Zhang Acked-by: Ori Kam --- v2 Add sample rules in testpmd guide. --- app/test-pmd/cmdline_flow.c | 29 +++++++++++++++++++++++++++++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 18 ++++++++++++++++++ 2 files changed, 47 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index c2cc4c5..680cb1c 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -220,6 +220,8 @@ enum index { ITEM_L2TPV3OIP_SESSION_ID, ITEM_ESP, ITEM_ESP_SPI, + ITEM_AH, + ITEM_AH_SPI, /* Validate/create actions. */ ACTIONS, @@ -768,6 +770,7 @@ static const enum index next_item[] = { ITEM_TAG, ITEM_L2TPV3OIP, ITEM_ESP, + ITEM_AH, END_SET, ZERO, }; @@ -1046,6 +1049,12 @@ static const enum index item_esp[] = { ZERO, }; +static const enum index item_ah[] = { + ITEM_AH_SPI, + ITEM_NEXT, + ZERO, +}; + static const enum index next_set_raw[] = { SET_RAW_INDEX, ITEM_ETH, @@ -2699,6 +2708,19 @@ static const struct token token_list[] = { .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_esp, hdr.spi)), }, + [ITEM_AH] = { + .name = "ah", + .help = "match AH header", + .priv = PRIV_ITEM(AH, sizeof(struct rte_flow_item_ah)), + .next = NEXT(item_ah), + .call = parse_vc, + }, + [ITEM_AH_SPI] = { + .name = "spi", + .help = "security parameters index", + .next = NEXT(item_ah, NEXT_ENTRY(UNSIGNED), item_param), + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_ah, spi)), + }, /* Validate/create actions. */ [ACTIONS] = { .name = "actions", @@ -6444,6 +6466,9 @@ flow_item_default_mask(const struct rte_flow_item *item) case RTE_FLOW_ITEM_TYPE_ESP: mask = &rte_flow_item_esp_mask; break; + case RTE_FLOW_ITEM_TYPE_AH: + mask = &rte_flow_item_ah_mask; + break; default: break; } @@ -6541,6 +6566,10 @@ cmd_set_raw_parsed(const struct buffer *in) size = sizeof(struct rte_flow_item_esp); proto = 0x32; break; + case RTE_FLOW_ITEM_TYPE_AH: + size = sizeof(struct rte_flow_item_ah); + proto = 0x33; + break; default: printf("Error - Not supported item\n"); *total_size = 0; diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index 5103ff9..95f4f06 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -3987,6 +3987,10 @@ This section lists supported pattern items and their attributes, if any. - ``session_id {unsigned}``: L2TPv3 over IP session identifier. +- ``ah``: match AH header. + + - ``spi {unsigned}``: security parameters index. + Actions list ^^^^^^^^^^^^ @@ -4822,6 +4826,20 @@ ESP rules can be created by the following commands:: testpmd> flow create 0 ingress pattern eth / ipv6 / udp / esp spi is 1 / end actions queue index 3 / end +Sample AH rules +~~~~~~~~~~~~~~~~ + +AH rules can be created by the following commands:: + + testpmd> flow create 0 ingress pattern eth / ipv4 / ah spi is 1 / end actions + queue index 3 / end + testpmd> flow create 0 ingress pattern eth / ipv4 / udp / ah spi is 1 / end + actions queue index 3 / end + testpmd> flow create 0 ingress pattern eth / ipv6 / ah spi is 1 / end actions + queue index 3 / end + testpmd> flow create 0 ingress pattern eth / ipv6 / udp / ah spi is 1 / end + actions queue index 3 / end + BPF Functions --------------