From patchwork Mon Apr 27 23:28:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 69414 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F15DA00BE; Tue, 28 Apr 2020 01:28:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7185E1D52F; Tue, 28 Apr 2020 01:28:35 +0200 (CEST) Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id 488701D483 for ; Tue, 28 Apr 2020 01:28:33 +0200 (CEST) Received: by mail-pj1-f66.google.com with SMTP id fu13so292169pjb.5 for ; Mon, 27 Apr 2020 16:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gM9D22B7a/TuqnZw8T9M6yRj21fpxqioBW632jm56kU=; b=CZnfGzfbz3FXaObYfarrbPbBH4mDRWfde14UR2J4EusttzZWK/+vYvmi6LnNTCNnck uc2jMMNTNe1I+XYJql+W2oCLsosdjMnLTyz8bCYkC66/TQGfIUkei8B2SwWKFFHk34lN Entoots3pyYS/B8fyWQRFqVs0Z0LI+uOyGYWHiDquZtJ3QcwBK8n+G1GicCZagwDUWm6 k7PLz6LVzpJYb9BX2Pbmktqd9F3ztStzOE2Cg05Tqirb36U8suOz83UNbBp4nyHx2vu4 bpTKBokCcbKGjqdLmhEd3KHiIoIANXzciuKuxsuHObm6m4zAawxmiJCrNoeC5DQmK3nm 317g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gM9D22B7a/TuqnZw8T9M6yRj21fpxqioBW632jm56kU=; b=jEf3T70plFMAazghKqwBZz63KaSgp0QTQznTCL44fuAcJ3LRPAHMZ+tlv3tE+/pUJb FZTgxKJuOlpxoAtuGYTEzGgCJ6C4Dro8ztXcsteB1Xhw0nq+mwviW+PHFeAUjYSNd+H6 Wf4i9Ee2pfLt6pU/QBMSmemYxYoWJVdz0jZdlaoaAeXc2i0CNc3IJdJ3vmdZ9fGYR2Xh zyBO3flcayprSFi0tfElBnoxHsdksXVupR8QSqTVKATc87h78u55ajB3uyIQofPMaTjm X8wTB3uJBQF85q2yo6IfgVvOwzdhdyaLvKcoN/+uzxv+XRkEgVUpCOAcil56mJBBLzpC 3B4g== X-Gm-Message-State: AGi0Pua1+OCqaogGGj87S3a4Af58EPZZ1VSOyEHqbFihU2wE4smcQryc rwRU9knoohLXHBYdo4DZdGBLw1ksal8= X-Google-Smtp-Source: APiQypKoNOskxniJA8sXKTe8Z7mI/WXoDnloT7nPuflZhPsQB9BPNjM33GBm4QDDONkuIm/Ge43P1g== X-Received: by 2002:a17:90a:730a:: with SMTP id m10mr1431443pjk.9.1588030112037; Mon, 27 Apr 2020 16:28:32 -0700 (PDT) Received: from hermes.corp.microsoft.com (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z28sm13797586pfr.3.2020.04.27.16.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2020 16:28:31 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 27 Apr 2020 16:28:19 -0700 Message-Id: <20200427232822.21695-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200427232822.21695-1-stephen@networkplumber.org> References: <20200427232822.21695-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/4] net/vmbus: add missing barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The check for event ring being empty needs a barrier to avoid any over agressive optimization. This is same barrier as Linux kernel. Signed-off-by: Stephen Hemminger Reviewed-by: Ruifeng Wang --- drivers/bus/vmbus/vmbus_channel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/vmbus/vmbus_channel.c b/drivers/bus/vmbus/vmbus_channel.c index 46b3ba3f9f9e..ff2985c25758 100644 --- a/drivers/bus/vmbus/vmbus_channel.c +++ b/drivers/bus/vmbus/vmbus_channel.c @@ -199,6 +199,7 @@ bool rte_vmbus_chan_rx_empty(const struct vmbus_channel *channel) { const struct vmbus_br *br = &channel->rxbr; + rte_smp_rmb(); return br->vbr->rindex == br->vbr->windex; } From patchwork Mon Apr 27 23:28:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 69415 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C23CA00BE; Tue, 28 Apr 2020 01:28:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4BBD11D54C; Tue, 28 Apr 2020 01:28:38 +0200 (CEST) Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by dpdk.org (Postfix) with ESMTP id E99211D52F for ; Tue, 28 Apr 2020 01:28:34 +0200 (CEST) Received: by mail-pj1-f68.google.com with SMTP id ms17so302845pjb.0 for ; Mon, 27 Apr 2020 16:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sOHvfQKXCdE14EJdc9Vp1Bb5Jl1FLm+suh/wl6HVMbU=; b=ZJFoRsSrKWxGj11eg86+qUh7NlH/xV/Hgz6SKwG+xVJIt6TwwBSDEMGKeLbR9WWnKu 5Z6nUb90muJp7onhAnmpBmw8fM+QqN0zaVwSyZXw/BkpDvwHEiwUES2TlaHCtyxWD/M9 slHhTav1zt6qrhEAhNKWYum2OjmJN9AzoSS9GewuE1Y6COC/z3i1KySHbZXqHJlsHJrx 5wOez9FOQ0i2MK3YKSan9GhcI3bP3hjCcr5OobrW1TNWH00p1nPYfoNHx0E7eX9terPd tBUu76F+aD7JGb59yQhIh3ZbB2zLI1eS8CUi8c/L7v6zCpMePQ8hVeHrRrDFYSlSWo6o Fu5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sOHvfQKXCdE14EJdc9Vp1Bb5Jl1FLm+suh/wl6HVMbU=; b=IU4eAoAQg9UMqOD0dIRRKMZWNs+Xgvl1VAO1T1EcRjXAXGQJgeUhba7oJNooIkD8gs M/UnJt2JYlREbko/F7FqQSbN7SjjxJ+BMf0jNrtPvzE4ibgPa29wt0btJhy3Q8zQa06h BK+NDyMv1jQZUqbv5mTtlgcy3ccv0/48/p2vr9lIlv5rEjqCHaHJcsN9842g3f25vesY 3r/pgijHQQfAvJ30CaLH09zthK3wP/16+mA/bsTA+8J69VrGW3aeO6NhCpmiI1MdbaV2 K1V+DmHr0CqwegRtkUpbPH1VfqQ18/xYGc4oB9SrzOZK+xC0D9HF0zTzwPm6+aTkr/DX 6uXg== X-Gm-Message-State: AGi0PuaLETgwLEJWIS1BLAElgad+uvudh8mVP5ksioZupmAH/jqR3AP6 Om7wmgFDXrwCMxunJcSBK0orevRrTVg= X-Google-Smtp-Source: APiQypLq2zC+JVP3cCHa6ssjS1oAwEitEP1r7TndvRi73KTwXnF6W9F07dDxte1ajMabkWrqQ2DqGQ== X-Received: by 2002:a17:90b:1104:: with SMTP id gi4mr1394730pjb.115.1588030113375; Mon, 27 Apr 2020 16:28:33 -0700 (PDT) Received: from hermes.corp.microsoft.com (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z28sm13797586pfr.3.2020.04.27.16.28.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2020 16:28:32 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org Date: Mon, 27 Apr 2020 16:28:20 -0700 Message-Id: <20200427232822.21695-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200427232822.21695-1-stephen@networkplumber.org> References: <20200427232822.21695-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/4] net/netvsc: fix invalid rte_free on dev_close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The netvsc PMD is putting the mac address in private data. Unless dev->data->mac_addrs is NULL'd rte_ethdev_close will try and free the address array. Causing the following scary error. EAL: Invalid memory This is a simpler alternative to the fix already merged in 20.05-rc1 Fixes: f8279f47dd89 ("net/netvsc: fix crash in secondary process") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 05f1a25a1abc..96480f930a46 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -849,6 +849,9 @@ hn_dev_close(struct rte_eth_dev *dev) hn_vf_close(dev); hn_dev_free_queues(dev); + + /* mac_addrs must not be freed alone because part of dev_private */ + dev->data->mac_addrs = NULL; } static const struct eth_dev_ops hn_eth_dev_ops = { From patchwork Mon Apr 27 23:28:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 69416 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05661A00BE; Tue, 28 Apr 2020 01:28:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9F9501D55E; Tue, 28 Apr 2020 01:28:39 +0200 (CEST) Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by dpdk.org (Postfix) with ESMTP id 589CC1D543 for ; Tue, 28 Apr 2020 01:28:36 +0200 (CEST) Received: by mail-pj1-f68.google.com with SMTP id 7so402068pjo.0 for ; Mon, 27 Apr 2020 16:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=u17UNaTLJ/IeMKr0zgrGpfJy+GbabRpmVLViAk5ruew=; b=XNsqdcbOZzdyvGCQx3MWIInSCS99Vy825+YcR/6W8VlTfiPQDbQaSI4+1I70oUpOd5 8Jq2IJwEBfKj9+A4F8H/o5rqXYPnEnjvllCDFptzhbExDmKe5kmExeRpFFurby5O8Jz+ OQ/5eir2sTjpQC7cyPHd8GiWS4ZsaDAIqufgaLdA1iHp11mbSCwxN0EXYvREowBjZ8rV 75c0e/EJjhP+hZ0gElTgVPSrVm9lLws4k+CxOPuy/pr0SSpDmEMP1Kp9O4oAcZpZdSN9 g7DyvzRUEnK1o2uR+DFK3QVhI1F6QJ7ilhReYv+/l840SOTNZnB0loJ96Wq7cEfOfrax 6gzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=u17UNaTLJ/IeMKr0zgrGpfJy+GbabRpmVLViAk5ruew=; b=toKPJM0T+fGgOuapnfArB5IIqCV6uPgJbRpxMmG81p+/WMtslypSAVkkibweNoceYp GjKNE5B8N48kQgl3FAo2nsLG9iq2KIOuYfNAuhjQOq/PFE5VpaER6oTKKQSwCKO8aAj1 CzZLpUupbkY/bxOH0UPZsRHblI6tcOO2QZ9k8Zn3xkWmn0JDmx6ifF/YMqsLYR8zYqAH r3IKJaLY1XKSpYpCcLbVEOcArF3cUHRL56ePofJxwg5pciVxsMY1ULHVRpNp4IKw2L+N G5C8DN4E8dC7wdfF5rPuN3cDvgKCaY7gOn195nCoDpbUQFnVM5puG1qpixsTAF9i5mnX 4kyg== X-Gm-Message-State: AGi0Puah/jRL/t596dkYsd8semI2ZW6kKrSUhwRZrT8efxLHcfpXU4po RL68uRBrZRiJMS1YpKe6/n+hDgxpabY= X-Google-Smtp-Source: APiQypK0riTPv7EHlqqlQ/iV0Ic11Wn/Sg1X/rG1Cni5mKknyG0uSjuwDBEw7ClikptZbzcB4hKbwg== X-Received: by 2002:a17:90a:8509:: with SMTP id l9mr1363570pjn.113.1588030114922; Mon, 27 Apr 2020 16:28:34 -0700 (PDT) Received: from hermes.corp.microsoft.com (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z28sm13797586pfr.3.2020.04.27.16.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2020 16:28:33 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 27 Apr 2020 16:28:21 -0700 Message-Id: <20200427232822.21695-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200427232822.21695-1-stephen@networkplumber.org> References: <20200427232822.21695-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/4] net/netvsc: fix comment spelling errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 2 +- drivers/net/netvsc/hn_nvs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 96480f930a46..6723abab1fe5 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -72,7 +72,7 @@ static const struct hn_xstats_name_off hn_stat_strings[] = { /* The default RSS key. * This value is the same as MLX5 so that flows will be - * received on same path for both VF ans synthetic NIC. + * received on same path for both VF and synthetic NIC. */ static const uint8_t rss_default_key[NDIS_HASH_KEYSIZE_TOEPLITZ] = { 0x2c, 0xc6, 0x81, 0xd1, 0x5b, 0xdb, 0xf4, 0xf7, diff --git a/drivers/net/netvsc/hn_nvs.h b/drivers/net/netvsc/hn_nvs.h index 2563fd8d8669..015839e3644f 100644 --- a/drivers/net/netvsc/hn_nvs.h +++ b/drivers/net/netvsc/hn_nvs.h @@ -37,7 +37,7 @@ #define NVS_RNDIS_MTYPE_CTRL 1 /* - * NVS message transacion status codes. + * NVS message transaction status codes. */ #define NVS_STATUS_OK 1 #define NVS_STATUS_FAILED 2 From patchwork Mon Apr 27 23:28:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 69417 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97664A00BE; Tue, 28 Apr 2020 01:29:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C84B1D569; Tue, 28 Apr 2020 01:28:41 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id C1AC91D54B for ; Tue, 28 Apr 2020 01:28:37 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id f7so9754712pfa.9 for ; Mon, 27 Apr 2020 16:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=X1XhK2cuhXya53b+HaMWHBi4lHpIsPvjzNp0tvmg8B4=; b=zgR5sIYWikrDdNfg5POzmqVRTNGc33Ewq3uYB87j3gaOnlNWGoSQnTtjWhLZ110dKt pY+4a5gJhi9Zs1Zpm36WqBLQPuYmKeeREIzchcvLZbI7RoddHtSFHFu3xZp/mO03/LfU leKEznDxucB9dEOuFB0Qf50+ljq0XgjYw67ANVRO8Iy4/WC213tnHEn+f8rMNkIxISfZ IYcVgCVIGH63/unIpECyuGAA77wdMZYCQLoNDkr2VsFoLpZ1FV4DdAvRe4yoV/ONi7Sa 2RD/4AJnR79XF2hNq0WlAExXh9L6oEyBq0MhdLXy8OtmvIvKhJ/ZI44PtIx6QU5KIb1F KqJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=X1XhK2cuhXya53b+HaMWHBi4lHpIsPvjzNp0tvmg8B4=; b=G6MR6j6JUSFkcE3DkQpgPbQ4MauvL5rNjd3O0a2ik8p6dA3YGFfbwzt34dWZDYMV7B YNowMBHbp8XJbHxUxD0bpTclkDQ8NznejRyAA8uLkdst/ClKzAXJiR2Lq2WpsFrhMA/o nZUOihH9hVTFRlgSQ/wJ8kMMvi1i/tCDAEJr34EgksYz0zXTL66MgTkzNIkETDdC/BIm C2eBoPVfOYckPMdfLbM7c8NirS74yQ91SIlFw2yalntM2Gv1qJuYsJQCH3Uq5raJ5pMf jjj008fjWZZHpR0a2Sdp+rDVIn46DVY9qjugvqXgVAAMRAXa1/mYg+gfXmQZA0ajEC4e wt7g== X-Gm-Message-State: AGi0Puabqchf+sC+7C1iID1J/xYQw8zCgDS2qOsfQs+ehmTsDrE+uKaG dsKums0pNPsKmgwOir0UJwe3LE+1NuE= X-Google-Smtp-Source: APiQypIe/ojfg9TAu0EsgUuy/bxajYklrCWG6ww6f4+J5YSEE7RsCboTaTHhdo0luuPjIoNI13KVOw== X-Received: by 2002:a63:e5a:: with SMTP id 26mr6027182pgo.235.1588030116525; Mon, 27 Apr 2020 16:28:36 -0700 (PDT) Received: from hermes.corp.microsoft.com (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z28sm13797586pfr.3.2020.04.27.16.28.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2020 16:28:35 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 27 Apr 2020 16:28:22 -0700 Message-Id: <20200427232822.21695-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200427232822.21695-1-stephen@networkplumber.org> References: <20200427232822.21695-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 4/4] bus/vmbus: fix comment spelling errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/linux/vmbus_uio.c | 2 +- drivers/bus/vmbus/vmbus_common.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vmbus/linux/vmbus_uio.c b/drivers/bus/vmbus/linux/vmbus_uio.c index 10e50c9b5a10..5451bfd1501d 100644 --- a/drivers/bus/vmbus/linux/vmbus_uio.c +++ b/drivers/bus/vmbus/linux/vmbus_uio.c @@ -165,7 +165,7 @@ vmbus_uio_map_resource_by_index(struct rte_vmbus_device *dev, int idx, dev->resource[idx].addr = mapaddr; vmbus_map_addr = RTE_PTR_ADD(mapaddr, size); - /* Record result of sucessful mapping for use by secondary */ + /* Record result of successful mapping for use by secondary */ maps[idx].addr = mapaddr; maps[idx].size = size; diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c index 48a219f73529..eaf5c292f986 100644 --- a/drivers/bus/vmbus/vmbus_common.c +++ b/drivers/bus/vmbus/vmbus_common.c @@ -131,7 +131,7 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr, } /* - * IF device class GUID mathces, call the probe function of + * IF device class GUID matches, call the probe function of * registere drivers for the vmbus device. * Return -1 if initialization failed, * and 1 if no driver found for this device.