From patchwork Mon Aug 13 16:03:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 43696 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A80B837A2; Mon, 13 Aug 2018 18:04:26 +0200 (CEST) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 9959A10A3 for ; Mon, 13 Aug 2018 18:04:25 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id i134-v6so806409wmf.0 for ; Mon, 13 Aug 2018 09:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=vL1TzIqTe1LAOJkHIuM54CcHasjpoqL1GCaSc7X86FQ=; b=N0cGte2bjjCCSdVj4CYJaXc88nwc1lRIdf8Km2JDa3DmEl+LIT1YjXYNLDeywNabBm 41uir7G3eTpDrT01zBxmz4Vgxi2mj7Oc6GV9zBE854pN8WsL3/l73PVdgIoDFG9tKWX4 YGzMZjwzOcJlNVbIXDWM0nn2vJZeOHhHNkf+O9Ojcn16uPYKXGgpIRsvzLun1+iKoq0/ nVLQSzPlUa2niZYQTnfwi/kHuakKbUZDcFv9uJXjxxL628j9NsjCeN4ZgpHKGM8QHECa ZJ2j3EoolSI6/i3Std08nMQ5FqFL0qYZMsVdYbsbBCbIr2SOAJUdwLAT6+0N1mRywhpu 1eRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vL1TzIqTe1LAOJkHIuM54CcHasjpoqL1GCaSc7X86FQ=; b=sXUPkJULhUU9qMxtWDjwkMntUUgCd4N5eKZdr0CCSsnvvrPKQfBBYGgf4t/vhQ6TKR Hoos4TfAqVEMkl+4kMzf8ghMmtiFJ+Heo+zSdEJN1phcVrcmKLojIjL8m1A4nV3aRvVK 0w3sQmWiGHbarfsgI1d0lgtMgPKgwUPFUSwLZ1seCwel8HfYs11G34F+NV0yp35UBdP6 OZy8ZTVRKztZXiMR8PlRuEnCUyFPKB7uiq9Z+KSDpt06nrlv2OWq4Kmr8SaKN6oarabM ejRTAHWpOBYeggw5KVPXqpXbYOZrHeREZWHMj+9RjVStLkFjbjeyfKgy5KcuyPequqPV mjaA== X-Gm-Message-State: AOUpUlHkrEdfbqyQNRwcrUZ5lo9bPmqw9KfNrLdgyk46axyETHRkm/Pt ld5GdbKkC+aKKnSt/lBpprehCwAsW9w= X-Google-Smtp-Source: AA+uWPzbTXNUV16A7VtpXd2rMXhu+eeRqkvlk94yFlS2bZZOjnX6XPf6tE+dalrRfm3Hp4Vnlc//mA== X-Received: by 2002:a1c:202:: with SMTP id 2-v6mr8134097wmc.91.1534176265012; Mon, 13 Aug 2018 09:04:25 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id m207-v6sm10613247wma.31.2018.08.13.09.04.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 13 Aug 2018 09:04:24 -0700 (PDT) From: David Marchand To: dev@dpdk.org Cc: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Olivier Matz Date: Mon, 13 Aug 2018 18:03:45 +0200 Message-Id: <1534176226-21911-1-git-send-email-david.marchand@6wind.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [RFC 1/2] mbuf: add a sanity check on segment metadata X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add some basic check on the segments offset and length metadata: always funny to have a < 0 tailroom cast to uint16_t ;-). Signed-off-by: David Marchand --- lib/librte_mbuf/rte_mbuf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c index e714c5a..7eeef12 100644 --- a/lib/librte_mbuf/rte_mbuf.c +++ b/lib/librte_mbuf/rte_mbuf.c @@ -200,6 +200,8 @@ rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header) pkt_len = m->pkt_len; do { + if (m->data_off + m->data_len > m->buf_len) + rte_panic("bad segment metadata\n"); nb_segs -= 1; pkt_len -= m->data_len; } while ((m = m->next) != NULL); From patchwork Mon Aug 13 16:03:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 43697 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4686F49CF; Mon, 13 Aug 2018 18:04:29 +0200 (CEST) Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 9618D493D for ; Mon, 13 Aug 2018 18:04:28 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id w24-v6so9342083wmc.1 for ; Mon, 13 Aug 2018 09:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=F8ay8Sr30dnYt6hsKjgTHghlrOSSEb07gwA0PfNGyjI=; b=BtOgwK0sdDm0XwRyz7QV3iAyH3fVEmd1DaielanTWP3nXhqTvKEXTQYtnVJL1bjkVO TBK1k6GtXC09oWTvlVffsu5SMnvue5U3KPlxejAgkuy3K+vfwYDpoqvRYzkhRTQ7xl0q hybwwSPJD5uSVJ1G63uWAE4agT/hbmuuPwJhl0lcPF/He9+dXfHqGIze+zavTEnIf6DJ LHWF0g/YdIU+BUu9jY3cp+8Rwww19C/1CCQisUZA/Kt9gnmONyOL77cjdG7iAQQGQpML tMLjsM3SMEQDmabyrfBgdmx4MsmvrYZWODCumaxhvhUb+w1M5AVRs0y+Kte72ML1/Bi9 iF2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=F8ay8Sr30dnYt6hsKjgTHghlrOSSEb07gwA0PfNGyjI=; b=KFnIiSNM7QsnyN57d+X76ebobuUNJtlrwJSvk7dWXobswqVyNKO8sbUy+1Hu7gLnUv +ZB3x+3Uw7luEnEGqJRoCOTteoUYAqlYJACri7qZS5ZIyRKbBlP+olCdor3ZLWFtQQ6U ZwyL8CQUhW/+GkpyNlT1mMkuEZKuNrvra8G1zFf4czaBkVx6Hp3KZGRZAPNVNhmgNn3A MXtCedX8pmljBtnCcZMmF8G7EJHxai+wWdimFg9fVOud5fXtCEfL4L93FqWWqL5u6sZL NSJuUilaII2tPhqgycq2hWDT+17iO1/U249vLb2y0zqY2duUV1xZj95PVOGu/pv2+dR/ ibsg== X-Gm-Message-State: AOUpUlEZDBESliAZT67bUKTa09LSlbQItvhgtr23IJWRxKHPHoQaRvp1 OPKtDtA8cpEjnXmPWolAicD+Z7A9Bfs= X-Google-Smtp-Source: AA+uWPxVDJFtBlUxJ/GsezSrJjYOX8NZCoJv+0NCCtxkALD+pnul1W4Q4CAcebOqFlT75oHGqDjmfQ== X-Received: by 2002:a1c:7c13:: with SMTP id x19-v6mr8949272wmc.27.1534176268016; Mon, 13 Aug 2018 09:04:28 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id m207-v6sm10613247wma.31.2018.08.13.09.04.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 13 Aug 2018 09:04:27 -0700 (PDT) From: David Marchand To: dev@dpdk.org Cc: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Olivier Matz Date: Mon, 13 Aug 2018 18:03:46 +0200 Message-Id: <1534176226-21911-2-git-send-email-david.marchand@6wind.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1534176226-21911-1-git-send-email-david.marchand@6wind.com> References: <1534176226-21911-1-git-send-email-david.marchand@6wind.com> Subject: [dpdk-dev] [RFC 2/2] ethdev: check received mbufs sanity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Let's check the mbufs given by the drivers directly in the rx handler. The only drawback is that you need CONFIG_RTE_LIBRTE_MBUF_DEBUG to be set for this to actually do some real checks. Signed-off-by: David Marchand --- lib/librte_ethdev/rte_ethdev.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 7070e9a..8843307 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -3803,6 +3803,7 @@ rte_eth_rx_burst(uint16_t port_id, uint16_t queue_id, { struct rte_eth_dev *dev = &rte_eth_devices[port_id]; uint16_t nb_rx; + uint16_t index; #ifdef RTE_LIBRTE_ETHDEV_DEBUG RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, 0); @@ -3816,6 +3817,9 @@ rte_eth_rx_burst(uint16_t port_id, uint16_t queue_id, nb_rx = (*dev->rx_pkt_burst)(dev->data->rx_queues[queue_id], rx_pkts, nb_pkts); + for (index = 0; index < nb_rx; index++) + __rte_mbuf_sanity_check(rx_pkts[index], 1); + #ifdef RTE_ETHDEV_RXTX_CALLBACKS if (unlikely(dev->post_rx_burst_cbs[queue_id] != NULL)) { struct rte_eth_rxtx_callback *cb =