[04/10] net/bnxt: remove redundant header file inclusion
Checks
Commit Message
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
bnxt.h header includes bnxt_cpr.h and bnxt_util.h.
There is no need to include these headers file explicitly.
This commit does not cause any functional change.
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_cpr.c | 1 -
drivers/net/bnxt/bnxt_ethdev.c | 2 --
drivers/net/bnxt/bnxt_flow.c | 1 -
drivers/net/bnxt/bnxt_hwrm.c | 1 -
drivers/net/bnxt/bnxt_irq.c | 1 -
drivers/net/bnxt/bnxt_ring.c | 1 -
drivers/net/bnxt/bnxt_rxq.c | 1 -
drivers/net/bnxt/bnxt_rxr.c | 1 -
drivers/net/bnxt/bnxt_txq.c | 1 -
drivers/net/bnxt/bnxt_txr.c | 1 -
10 files changed, 11 deletions(-)
Comments
On 10/4/2019 6:02 AM, Ajit Khaparde wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> bnxt.h header includes bnxt_cpr.h and bnxt_util.h.
> There is no need to include these headers file explicitly.
>
> This commit does not cause any functional change.
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
don't you want this patch to be backported? I think it may be good to backport
these kind of small fixes too to reduce conflicts in the driver in the future.
@@ -8,7 +8,6 @@
#include <rte_cycles.h>
#include "bnxt.h"
-#include "bnxt_cpr.h"
#include "bnxt_hwrm.h"
#include "bnxt_ring.h"
#include "hsi_struct_def_dpdk.h"
@@ -14,7 +14,6 @@
#include <rte_alarm.h>
#include "bnxt.h"
-#include "bnxt_cpr.h"
#include "bnxt_filter.h"
#include "bnxt_hwrm.h"
#include "bnxt_irq.h"
@@ -27,7 +26,6 @@
#include "bnxt_vnic.h"
#include "hsi_struct_def_dpdk.h"
#include "bnxt_nvm_defs.h"
-#include "bnxt_util.h"
#define DRV_MODULE_NAME "bnxt"
static const char bnxt_version[] =
@@ -17,7 +17,6 @@
#include "bnxt_ring.h"
#include "bnxt_rxq.h"
#include "bnxt_vnic.h"
-#include "bnxt_util.h"
#include "hsi_struct_def_dpdk.h"
static int
@@ -13,7 +13,6 @@
#include <rte_version.h>
#include "bnxt.h"
-#include "bnxt_cpr.h"
#include "bnxt_filter.h"
#include "bnxt_hwrm.h"
#include "bnxt_rxq.h"
@@ -9,7 +9,6 @@
#include <rte_malloc.h>
#include "bnxt.h"
-#include "bnxt_cpr.h"
#include "bnxt_irq.h"
#include "bnxt_ring.h"
#include "hsi_struct_def_dpdk.h"
@@ -9,7 +9,6 @@
#include <unistd.h>
#include "bnxt.h"
-#include "bnxt_cpr.h"
#include "bnxt_hwrm.h"
#include "bnxt_ring.h"
#include "bnxt_rxq.h"
@@ -8,7 +8,6 @@
#include <rte_malloc.h>
#include "bnxt.h"
-#include "bnxt_cpr.h"
#include "bnxt_filter.h"
#include "bnxt_hwrm.h"
#include "bnxt_ring.h"
@@ -12,7 +12,6 @@
#include <rte_memory.h>
#include "bnxt.h"
-#include "bnxt_cpr.h"
#include "bnxt_ring.h"
#include "bnxt_rxr.h"
#include "bnxt_rxq.h"
@@ -8,7 +8,6 @@
#include <rte_malloc.h>
#include "bnxt.h"
-#include "bnxt_cpr.h"
#include "bnxt_ring.h"
#include "bnxt_txq.h"
#include "bnxt_txr.h"
@@ -9,7 +9,6 @@
#include <rte_malloc.h>
#include "bnxt.h"
-#include "bnxt_cpr.h"
#include "bnxt_ring.h"
#include "bnxt_txq.h"
#include "bnxt_txr.h"