Message ID | 1619657448-57567-1-git-send-email-humin29@huawei.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 294F7A0A0E; Thu, 29 Apr 2021 02:50:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43370412D3; Thu, 29 Apr 2021 02:50:46 +0200 (CEST) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id 6831E412D1 for <dev@dpdk.org>; Thu, 29 Apr 2021 02:50:42 +0200 (CEST) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FVxgc37mCzvTRd; Thu, 29 Apr 2021 08:48:12 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Thu, 29 Apr 2021 08:50:39 +0800 From: "Min Hu (Connor)" <humin29@huawei.com> To: <dev@dpdk.org> CC: <ferruh.yigit@intel.com>, <bernard.iremonger@intel.com>, <thomas@monjalon.net> Date: Thu, 29 Apr 2021 08:50:45 +0800 Message-ID: <1619657448-57567-1-git-send-email-humin29@huawei.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1616830818-3127-1-git-send-email-humin29@huawei.com> References: <1616830818-3127-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH v3 0/3] fix check of port and core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | fix check of port and core | |
Message
humin (Q)
April 29, 2021, 12:50 a.m. UTC
Currently, some examples check that the port is on the same NUMA node as the polling thread for best performance. The method is to compare the socket id of port and that of current core. If the result is different, warning info will be given. But it ignores the port which is from numa node 0, that is, no warning info will be given if the port is from numa node 0, and this set of patches will fix it. --- v3: * change "-w" to "-a". v2: * add more commit info. Min Hu (Connor) (3): examples/flow_classify: fix check of port and core examples/l2fwd-cat: fix check of port and core examples/skeleton: fix check of port and core examples/flow_classify/flow_classify.c | 2 +- examples/l2fwd-cat/l2fwd-cat.c | 2 +- examples/skeleton/basicfwd.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
Comments
On 4/29/2021 1:50 AM, Min Hu (Connor) wrote: > Currently, some examples check that the port is on the same NUMA > node as the polling thread for best performance. The method is > to compare the socket id of port and that of current core. If the > result is different, warning info will be given. > > But it ignores the port which is from numa node 0, that is, no > warning info will be given if the port is from numa node 0, and > this set of patches will fix it. > --- > v3: > * change "-w" to "-a". > > v2: > * add more commit info. > > Min Hu (Connor) (3): > examples/flow_classify: fix check of port and core > examples/l2fwd-cat: fix check of port and core > examples/skeleton: fix check of port and core > For series, Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Only I am not sure if it is confusing to mention from 'flow_classify' in the commit log of 'l2fwd-cat' or 'skeleton' patches.
12/05/2021 18:52, Ferruh Yigit: > On 4/29/2021 1:50 AM, Min Hu (Connor) wrote: > > Currently, some examples check that the port is on the same NUMA > > node as the polling thread for best performance. The method is > > to compare the socket id of port and that of current core. If the > > result is different, warning info will be given. > > > > But it ignores the port which is from numa node 0, that is, no > > warning info will be given if the port is from numa node 0, and > > this set of patches will fix it. > > --- > > v3: > > * change "-w" to "-a". > > > > v2: > > * add more commit info. > > > > Min Hu (Connor) (3): > > examples/flow_classify: fix check of port and core > > examples/l2fwd-cat: fix check of port and core > > examples/skeleton: fix check of port and core > > > > For series, > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Only I am not sure if it is confusing to mention from 'flow_classify' in the > commit log of 'l2fwd-cat' or 'skeleton' patches. Yes it is confusing, I'll drop these comments. The commits are still not explaining the issue is for devices on node 0, I'll reword a bit. Applied, thanks.