[V1] conf/test_case_checklist:add foxville not supoort case

Message ID 20210616121301.5734-1-linglix.chen@intel.com (mailing list archive)
State Changes Requested
Headers
Series [V1] conf/test_case_checklist:add foxville not supoort case |

Commit Message

Lingli Chen June 16, 2021, 12:13 p.m. UTC
  According to dpdk commit 312312e928c7 (app/testpmd: fix bitmap of link speeds when force speed):
foxville not supoort:change_linkspeed.

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 conf/test_case_checklist.json | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Lingli Chen June 16, 2021, 3:47 a.m. UTC | #1
> -----Original Message-----
> From: Chen, LingliX <linglix.chen@intel.com>
> Sent: Wednesday, June 16, 2021 8:13 PM
> To: dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: [dts][PATCH V1] conf/test_case_checklist:add foxville not supoort case
> 
> According to dpdk commit 312312e928c7 (app/testpmd: fix bitmap of link
> speeds when force speed):
> foxville not supoort:change_linkspeed.
> 
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>

Tested-by: Lingli Chen <linglix.chen@intel.com>
  
Tu, Lijuan June 18, 2021, 7:40 a.m. UTC | #2
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Lingli Chen
> Sent: 2021年6月16日 20:13
> To: dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: [dts] [PATCH V1] conf/test_case_checklist:add foxville not supoort case
> 
> According to dpdk commit 312312e928c7 (app/testpmd: fix bitmap of link
> speeds when force speed):
> foxville not supoort:change_linkspeed.


Commit 312312e928c7 (app/testpmd: fix bitmap of link
> speeds when force speed) tells:

app/testpmd: fix bitmap of link speeds when force speed

    Currently, when the user sets force link speed through 'link_speeds',
    bit(0) of 'link_speeds' is not set to 1(ETH_LINK_SPEED_FIXED),
    which conflicts with the definition.

I don't understand how do you get " foxville not supoort:change_linkspeed ", could you please clarify it?
> 
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>
> ---
>  conf/test_case_checklist.json | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json index
> 1a686d8e..8523f61e 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -2862,6 +2862,7 @@
>              "NIC": [
>                  "powerville",
>                  "springville",
> +                "foxville",
>                  "columbiaville_25g",
>                  "columbiaville_100g"
>              ],
> --
> 2.17.1
  

Patch

diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
index 1a686d8e..8523f61e 100644
--- a/conf/test_case_checklist.json
+++ b/conf/test_case_checklist.json
@@ -2862,6 +2862,7 @@ 
             "NIC": [
                 "powerville",
                 "springville",
+                "foxville",
                 "columbiaville_25g",
                 "columbiaville_100g"
             ],