diff mbox series

[v4,1/4] test/crypto: remove illegal header include

Message ID 20210907192246.3010653-2-gakhil@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series cryptodev: expose driver interface as internal |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing warning apply patch failure

Commit Message

Akhil Goyal Sept. 7, 2021, 7:22 p.m. UTC 
  rte_cryptodev_pmd.h is an interface between
driver and library and it is mentioned in the
file that application cannot use it directly.
Hence, removing the include.

Signed-off-by: Akhil Goyal <gakhil@marvell.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 app/test/test_cryptodev.c               | 1 -
 app/test/test_cryptodev_asym.c          | 1 -
 app/test/test_cryptodev_blockcipher.c   | 1 -
 app/test/test_cryptodev_security_pdcp.c | 1 -
 app/test/test_ipsec.c                   | 1 -
 5 files changed, 5 deletions(-)

Comments

Hemant Agrawal Sept. 8, 2021, 6:38 a.m. UTC | #1 
On 9/8/2021 12:52 AM, Akhil Goyal wrote:
> rte_cryptodev_pmd.h is an interface between
> driver and library and it is mentioned in the
> file that application cannot use it directly.
> Hence, removing the include.
>
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Series-

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>



> ---
>   app/test/test_cryptodev.c               | 1 -
>   app/test/test_cryptodev_asym.c          | 1 -
>   app/test/test_cryptodev_blockcipher.c   | 1 -
>   app/test/test_cryptodev_security_pdcp.c | 1 -
>   app/test/test_ipsec.c                   | 1 -
>   5 files changed, 5 deletions(-)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> index 843d07ba37..9e823db1e6 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -16,7 +16,6 @@
>   
>   #include <rte_crypto.h>
>   #include <rte_cryptodev.h>
> -#include <rte_cryptodev_pmd.h>
>   #include <rte_string_fns.h>
>   
>   #ifdef RTE_CRYPTO_SCHEDULER
> diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
> index 847b074a4f..9d19a6d6d9 100644
> --- a/app/test/test_cryptodev_asym.c
> +++ b/app/test/test_cryptodev_asym.c
> @@ -12,7 +12,6 @@
>   #include <rte_pause.h>
>   
>   #include <rte_cryptodev.h>
> -#include <rte_cryptodev_pmd.h>
>   #include <rte_crypto.h>
>   
>   #include "test_cryptodev.h"
> diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c
> index 53fd4718af..1c948eb008 100644
> --- a/app/test/test_cryptodev_blockcipher.c
> +++ b/app/test/test_cryptodev_blockcipher.c
> @@ -11,7 +11,6 @@
>   
>   #include <rte_crypto.h>
>   #include <rte_cryptodev.h>
> -#include <rte_cryptodev_pmd.h>
>   
>   #include "test.h"
>   #include "test_cryptodev.h"
> diff --git a/app/test/test_cryptodev_security_pdcp.c b/app/test/test_cryptodev_security_pdcp.c
> index 30f3eb892c..a7641bab7a 100644
> --- a/app/test/test_cryptodev_security_pdcp.c
> +++ b/app/test/test_cryptodev_security_pdcp.c
> @@ -17,7 +17,6 @@
>   
>   #include <rte_crypto.h>
>   #include <rte_cryptodev.h>
> -#include <rte_cryptodev_pmd.h>
>   #include <rte_security.h>
>   
>   #include <rte_lcore.h>
> diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c
> index fb90130ae2..c6d6b88d6d 100644
> --- a/app/test/test_ipsec.c
> +++ b/app/test/test_ipsec.c
> @@ -15,7 +15,6 @@
>   
>   #include <rte_crypto.h>
>   #include <rte_cryptodev.h>
> -#include <rte_cryptodev_pmd.h>
>   #include <rte_lcore.h>
>   #include <rte_ipsec.h>
>   #include <rte_random.h>
Akhil Goyal Sept. 8, 2021, 8:05 a.m. UTC | #2 
> 
> On 9/8/2021 12:52 AM, Akhil Goyal wrote:
> > rte_cryptodev_pmd.h is an interface between
> > driver and library and it is mentioned in the
> > file that application cannot use it directly.
> > Hence, removing the include.
> >
> > Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>
> 
> Series-
> 
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Series Applied to dpdk-next-crypto
diff mbox series

Patch

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 843d07ba37..9e823db1e6 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -16,7 +16,6 @@ 
 
 #include <rte_crypto.h>
 #include <rte_cryptodev.h>
-#include <rte_cryptodev_pmd.h>
 #include <rte_string_fns.h>
 
 #ifdef RTE_CRYPTO_SCHEDULER
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 847b074a4f..9d19a6d6d9 100644
--- a/app/test/test_cryptodev_asym.c
+++ b/app/test/test_cryptodev_asym.c
@@ -12,7 +12,6 @@ 
 #include <rte_pause.h>
 
 #include <rte_cryptodev.h>
-#include <rte_cryptodev_pmd.h>
 #include <rte_crypto.h>
 
 #include "test_cryptodev.h"
diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c
index 53fd4718af..1c948eb008 100644
--- a/app/test/test_cryptodev_blockcipher.c
+++ b/app/test/test_cryptodev_blockcipher.c
@@ -11,7 +11,6 @@ 
 
 #include <rte_crypto.h>
 #include <rte_cryptodev.h>
-#include <rte_cryptodev_pmd.h>
 
 #include "test.h"
 #include "test_cryptodev.h"
diff --git a/app/test/test_cryptodev_security_pdcp.c b/app/test/test_cryptodev_security_pdcp.c
index 30f3eb892c..a7641bab7a 100644
--- a/app/test/test_cryptodev_security_pdcp.c
+++ b/app/test/test_cryptodev_security_pdcp.c
@@ -17,7 +17,6 @@ 
 
 #include <rte_crypto.h>
 #include <rte_cryptodev.h>
-#include <rte_cryptodev_pmd.h>
 #include <rte_security.h>
 
 #include <rte_lcore.h>
diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c
index fb90130ae2..c6d6b88d6d 100644
--- a/app/test/test_ipsec.c
+++ b/app/test/test_ipsec.c
@@ -15,7 +15,6 @@ 
 
 #include <rte_crypto.h>
 #include <rte_cryptodev.h>
-#include <rte_cryptodev_pmd.h>
 #include <rte_lcore.h>
 #include <rte_ipsec.h>
 #include <rte_random.h>