Message ID | 20210913181510.46058-11-stephen@networkplumber.org (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E315A0C45; Mon, 13 Sep 2021 20:16:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7971041162; Mon, 13 Sep 2021 20:15:34 +0200 (CEST) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 16ECF4111B for <dev@dpdk.org>; Mon, 13 Sep 2021 20:15:25 +0200 (CEST) Received: by mail-pg1-f173.google.com with SMTP id u18so10275130pgf.0 for <dev@dpdk.org>; Mon, 13 Sep 2021 11:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xEryJVfRpOZnno13Fs+/Z1ZA5qB4zOvSxWQpk19aLoE=; b=QGMZGQE72UQL2KsUY9YNYfjnIe8NDIdH3VlqU21UNcEXDU643DsPwz/kuVoyJbIkq+ fAH8mO4kYivL2Q1PkcEajTwl6wFXGEbllUXgPCOsOYAipzbi4p/R3W3BnLyi17I2BBHq 0LcZN2LwsSl+E4sELDiUA5ZY6eh2I29LFHIxuPPvXjLM0VRgi7NwI7W+DNpzxio6Rxzk fidYhznxSbptr1DhBy2hCuZbkTj2DCdhaFwDdUQem/cd1MleNTGtHC3VCMJI6Kt9ckNQ HqwwSavgnCK+GVnMt8u3R26QdFbDVe4Xzido6o4NPAKzGx8E02i8239g+D5sFgJd4fhL fazw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xEryJVfRpOZnno13Fs+/Z1ZA5qB4zOvSxWQpk19aLoE=; b=Tn7nY7C5pR2JV1WfUN7gsHC08/XF0yAbHZrxdHbSJHkM7JnlmR1sCo55ZoP/vPOhhn rudshS2W5vYQNZvUB+ZpOuw4EW4DCb2Q1p8lWztZGGeHXFP2Cb1mj5yoQEoG8ZMpYU7R waNUselhZtBvakszPYvZOz3sTZyKpraFLxlatuxDj96wImupSsj99qftpChQ7dgqwoGF kzcIPUpBkXgyPDCRu1B+k+Wb/bQompztIb4sLkCUkaUiW0BKawe0WcpeIZOeRiS2hDD5 jLhxc3XPczKKxQvv9adX9KNZHTBp5CmsEPwvkQH/v4az+YF5wmLR2Xkk342WxK620AFl vLxA== X-Gm-Message-State: AOAM5328e5KAaeDmmrFmVhQ6wpFYo3gsYnq6FNwvmJxeVcL9p+IyVh3d m3hc46ECMKImd5R4YgEHXuFmq7ZFhD1VRA== X-Google-Smtp-Source: ABdhPJy2PZ2vK1vpqaXEUFhPnlNkQrFPRInmxd3Wy6zwHpNZk6eFgCLkQwSDBnREYYunlcr4330hyQ== X-Received: by 2002:aa7:88ce:0:b0:410:d7ea:7a77 with SMTP id k14-20020aa788ce000000b00410d7ea7a77mr758856pff.45.1631556923902; Mon, 13 Sep 2021 11:15:23 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id b10sm7616888pfl.220.2021.09.13.11.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Sep 2021 11:15:23 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org> Date: Mon, 13 Sep 2021 11:15:08 -0700 Message-Id: <20210913181510.46058-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210913181510.46058-1-stephen@networkplumber.org> References: <20210903004732.109023-1-stephen@networkplumber.org> <20210913181510.46058-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v8 10/12] test: enable bpf autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
Packet capture framework enhancements
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
Commit Message
Stephen Hemminger
Sept. 13, 2021, 6:15 p.m. UTC
The BPF autotest is defined but not run automatically.
Since it is short, it should be added to the autotest suite.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/test/meson.build | 2 ++
1 file changed, 2 insertions(+)
Comments
> The BPF autotest is defined but not run automatically. > Since it is short, it should be added to the autotest suite. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > --- > app/test/meson.build | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/app/test/meson.build b/app/test/meson.build > index 0d551ac9c2b2..cd18484bb73a 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -194,6 +194,8 @@ test_deps = [ > fast_tests = [ > ['acl_autotest', true], > ['atomic_autotest', false], > + ['bpf_autotest', true], > + ['bpf_convert_autotest', true], > ['bitops_autotest', true], > ['byteorder_autotest', true], > ['cksum_autotest', true], > -- Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > 2.30.2
On Wed, 15 Sep 2021 11:27:15 +0000 "Ananyev, Konstantin" <konstantin.ananyev@intel.com> wrote: > > The BPF autotest is defined but not run automatically. > > Since it is short, it should be added to the autotest suite. > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > > --- > > app/test/meson.build | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/app/test/meson.build b/app/test/meson.build > > index 0d551ac9c2b2..cd18484bb73a 100644 > > --- a/app/test/meson.build > > +++ b/app/test/meson.build > > @@ -194,6 +194,8 @@ test_deps = [ > > fast_tests = [ > > ['acl_autotest', true], > > ['atomic_autotest', false], > > + ['bpf_autotest', true], > > + ['bpf_convert_autotest', true], > > ['bitops_autotest', true], > > ['byteorder_autotest', true], > > ['cksum_autotest', true], > > -- > > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > > > 2.30.2 > One oddity of original BPF test is that it constructs an mbuf where there is no Ethernet header. Didn't want to change that since not only would the constructor have to be changed but also the hand written BPF programs as well. Not necessarily a bug, but the test is not doing what any application using BPF on incoming mbuf's would expect to do.
On Mon, 13 Sep 2021 11:15:08 -0700 Stephen Hemminger <stephen@networkplumber.org> wrote: > The BPF autotest is defined but not run automatically. > Since it is short, it should be added to the autotest suite. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > --- > app/test/meson.build | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/app/test/meson.build b/app/test/meson.build > index 0d551ac9c2b2..cd18484bb73a 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -194,6 +194,8 @@ test_deps = [ > fast_tests = [ > ['acl_autotest', true], > ['atomic_autotest', false], > + ['bpf_autotest', true], > + ['bpf_convert_autotest', true], > ['bitops_autotest', true], > ['byteorder_autotest', true], > ['cksum_autotest', true], Note: this patch exposes a pre-existing bug in DPDK: https://bugs.dpdk.org/show_bug.cgi?id=811 The BPF code does not work if built with Clang. The test was just being ignored by the CI before!
diff --git a/app/test/meson.build b/app/test/meson.build index 0d551ac9c2b2..cd18484bb73a 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -194,6 +194,8 @@ test_deps = [ fast_tests = [ ['acl_autotest', true], ['atomic_autotest', false], + ['bpf_autotest', true], + ['bpf_convert_autotest', true], ['bitops_autotest', true], ['byteorder_autotest', true], ['cksum_autotest', true],