Message ID | 20211015150545.1673312-1-xuemingl@nvidia.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Maxime Coquelin |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55D3BA0C45; Fri, 15 Oct 2021 17:06:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FD17411CB; Fri, 15 Oct 2021 17:06:31 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2063.outbound.protection.outlook.com [40.107.223.63]) by mails.dpdk.org (Postfix) with ESMTP id BC952410F1; Fri, 15 Oct 2021 17:06:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S0iy7yMExErx2w/qtyg3YgFVAu2V/mGLWkaeL4FmEmXXb43yL8RijQjyvQbrSZAbP1dEAb64Y9HpQcDjOzAsH1Mh46bNLx6wN0X3TMY1nQkZnQ+gd2SumO/7zc68mf2Tsqlqe9m5qmV1nLYy68tmtveBkOSbWTG79xGYtPjbZV+D+mdfJ5yiRO5PjhEnUpnnKM8+Vi2pYY6VZ/m7U/5uyrX8TE0rNRTYwqlLA0LWHBhbJjf/C2FDDnV6QwCj0rSpyIUBxeXhIvSDd6qyHCUhRA3NeMn/KrrsNojU0TMaoDrR09ZuWjovsh52gh6N91j4HoZ5Tmd6oW4nWGNbqQ08QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BcHUQBD3TxjErUS1awQzpdP32olv0m4VhEc9KJT6LOU=; b=TTdkZzCdvjjHv25sAY4oLCF6jFdNQ60DRVhYBqn/FP2eDf7onjTfBnvT4FCFit5bysuVQka2vMjbSppaKSplIOG4wGx/+gmSzrWoPV5SQ1virYKpSP8KqPbbVx9cAp3CgyMQ7u9FHCAf3p9uQgD88NhR+rsWcOHbIRz3M9qTZRsWzQ0Oiq6yYdYU7hEhxfvwQFPewGJVC5w7cVlrSdNHhtQSLLMzoowA4CAKR6gCbVaPnADsIfv4vw5gqMDWL+qgaq06q4dMLAxKCEeaibD2uOovWkgxpILChtc3gmssSWLFJuRSH9UwC5sr+3Y1T9YruxbeIj09FNNqecmotxIkpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BcHUQBD3TxjErUS1awQzpdP32olv0m4VhEc9KJT6LOU=; b=mrBqrKTtEBD/e89KU+QC0oeXF1ey2GN0SThIPoHblQNpNzygfsoePsjIfOwnp7I2WLsjol7rp8+o5pQTjWLEbJb4SIeEMQgQPmnpwseQ+dA7fTKbVqBww75o5aUH9Ucr2tRtjmxe3Hzv8axY01Cxpy/ewqtgzan/gFdwO2/lmmKE6Bwtr9NL19RWqO710CAIi/d4FTOTBU1dZ2tkWtuvq65nXGiJC9+JHr7OvA3fh+nwK7v0LOvpvUinar7lGrrTRA4xLfcGyl7xMBnxco2oIKoQdkRot7twbvH2Zl7Vog1WpwafFmZlYDl2lSXRy6CcNxSZrAXgW5RMRk/GiLA8Rw== Received: from MW4PR03CA0061.namprd03.prod.outlook.com (2603:10b6:303:b6::6) by MW3PR12MB4426.namprd12.prod.outlook.com (2603:10b6:303:58::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Fri, 15 Oct 2021 15:06:27 +0000 Received: from CO1NAM11FT066.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b6:cafe::f6) by MW4PR03CA0061.outlook.office365.com (2603:10b6:303:b6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Fri, 15 Oct 2021 15:06:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT066.mail.protection.outlook.com (10.13.175.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4608.15 via Frontend Transport; Fri, 15 Oct 2021 15:06:27 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 15 Oct 2021 15:06:25 +0000 From: Xueming Li <xuemingl@nvidia.com> To: <dev@dpdk.org> CC: <xuemingl@nvidia.com>, Maxime Coquelin <maxime.coquelin@redhat.com>, <stable@dpdk.org>, Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com> Date: Fri, 15 Oct 2021 23:05:44 +0800 Message-ID: <20211015150545.1673312-1-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210923081758.178745-1-xuemingl@nvidia.com> References: <20210923081758.178745-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2bb252ca-0028-4254-3a13-08d98fed5cae X-MS-TrafficTypeDiagnostic: MW3PR12MB4426: X-Microsoft-Antispam-PRVS: <MW3PR12MB4426AA315C049FAC1256BE26A1B99@MW3PR12MB4426.namprd12.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:475; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n7NQ3D2kciVD4JQnGjWRtTpwM0xjA8l/ugcrZy+Rjy3N+bXaTqEqJB2fWiK/0vlXy6zddCYF6utMGT7UvbbwgJnPC3+YyAws5dy/UKYqCn6lTUaXfJM9bLTme+mz4j51mC6POWJC/ZKZTiuSss4Xw6N37ZQAwQyuxCkaWvKUfNMwRCi+UsGY4qGbAhPB2EMNNjZEsRwdkJ9rB+2juPFU8+A545V2VDLq5Whb0+btgVZHxJYSV3WSlRZsG+3JrNcVoUXPFyhHuUI68aMnqgWAGRETs5Qny5NR18LkEHfMobez5CcNZ6DIpzOaM5V/rwuVo9qdPCgTsnMr9ZUEnLvA2IuSW79PZa+Wi1sIM9GotF8D8fRc/LyvA/ofOqOM3ZKvnlUozsy9G3y9j9qW8KSKpWq7Wc6KRaTJij2rxXnltpXU+D2bMrZZgIFktcvWbY2+LIByGjbB7kwdOTZbRz63TNSEIgk50x4cusJeDDocPt9H64PUKhRSACxwq5MrB4Unph89HDhm9X8A0Yc1NdkV1wwn6l+4mZE/noGm2W+irarwr4zAZQA0g3J/oBYgLjggn7cWJ5AGmg4l/4PQ5zYcqibGAEEDGF0/DrbSXCxUf+bBK6aYEoMTZcPZmvZX3wX3byICToo8yR/6CO1UfA4fNeJ5qiuw2fRJblY2eqtgOqUj3KcXx6yeg37lKpHRxS+L4v8Z1zu1bIcAXP1aZqQFAw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(6916009)(356005)(54906003)(4326008)(6286002)(7696005)(107886003)(8936002)(7636003)(1076003)(316002)(36860700001)(6666004)(47076005)(82310400003)(5660300002)(16526019)(2906002)(186003)(26005)(336012)(86362001)(83380400001)(426003)(36756003)(70586007)(55016002)(8676002)(70206006)(508600001)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2021 15:06:27.3565 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2bb252ca-0028-4254-3a13-08d98fed5cae X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT066.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4426 Subject: [dpdk-dev] [PATCH v2 1/2] vdpa/mlx5: workaround FW first completion in start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
[v2,1/2] vdpa/mlx5: workaround FW first completion in start
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
Commit Message
Xueming(Steven) Li
Oct. 15, 2021, 3:05 p.m. UTC
After a vDPA application restart, qemu restores VQ with used and available index, new incoming packet triggers virtio driver to handle buffers. Under heavy traffic, no available buffer for firmware to receive new packets, no Rx interrupts generated, driver is stuck on endless interrupt waiting. As a firmware workaround, this patch sends a notification after VQ setup to ask driver handling buffers and filling new buffers. Fixes: bff735011078 ("vdpa/mlx5: prepare virtio queues") Cc: stable@dpdk.org Signed-off-by: Xueming Li <xuemingl@nvidia.com> Reviewed-by: Matan Azrad <matan@nvidia.com> --- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 4 ++++ 1 file changed, 4 insertions(+)
Comments
On 10/15/21 17:05, Xueming Li wrote: > After a vDPA application restart, qemu restores VQ with used and > available index, new incoming packet triggers virtio driver to > handle buffers. Under heavy traffic, no available buffer for > firmware to receive new packets, no Rx interrupts generated, > driver is stuck on endless interrupt waiting. > > As a firmware workaround, this patch sends a notification after > VQ setup to ask driver handling buffers and filling new buffers. > > Fixes: bff735011078 ("vdpa/mlx5: prepare virtio queues") > Cc: stable@dpdk.org > > Signed-off-by: Xueming Li <xuemingl@nvidia.com> > Reviewed-by: Matan Azrad <matan@nvidia.com> > --- > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 4 ++++ > 1 file changed, 4 insertions(+) > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Thanks, Maxime
On 10/15/21 17:05, Xueming Li wrote: > After a vDPA application restart, qemu restores VQ with used and > available index, new incoming packet triggers virtio driver to > handle buffers. Under heavy traffic, no available buffer for > firmware to receive new packets, no Rx interrupts generated, > driver is stuck on endless interrupt waiting. > > As a firmware workaround, this patch sends a notification after > VQ setup to ask driver handling buffers and filling new buffers. > > Fixes: bff735011078 ("vdpa/mlx5: prepare virtio queues") > Cc: stable@dpdk.org > > Signed-off-by: Xueming Li <xuemingl@nvidia.com> > Reviewed-by: Matan Azrad <matan@nvidia.com> > --- > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 4 ++++ > 1 file changed, 4 insertions(+) > Applied to dpdk-next-virtio/main. Thanks, Maxime
On Thu, 2021-10-21 at 14:27 +0200, Maxime Coquelin wrote: > > On 10/15/21 17:05, Xueming Li wrote: > > After a vDPA application restart, qemu restores VQ with used and > > available index, new incoming packet triggers virtio driver to > > handle buffers. Under heavy traffic, no available buffer for > > firmware to receive new packets, no Rx interrupts generated, > > driver is stuck on endless interrupt waiting. > > > > As a firmware workaround, this patch sends a notification after > > VQ setup to ask driver handling buffers and filling new buffers. > > > > Fixes: bff735011078 ("vdpa/mlx5: prepare virtio queues") > > Cc: stable@dpdk.org > > > > Signed-off-by: Xueming Li <xuemingl@nvidia.com> > > Reviewed-by: Matan Azrad <matan@nvidia.com> > > --- > > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > > Applied to dpdk-next-virtio/main. Thanks Maxime! > > Thanks, > Maxime >
diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c index f530646058f..71470d23d9e 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c @@ -4,6 +4,7 @@ #include <string.h> #include <unistd.h> #include <sys/mman.h> +#include <sys/eventfd.h> #include <rte_malloc.h> #include <rte_errno.h> @@ -367,6 +368,9 @@ mlx5_vdpa_virtq_setup(struct mlx5_vdpa_priv *priv, int index) goto error; } virtq->stopped = false; + /* Initial notification to ask qemu handling completed buffers. */ + if (virtq->eqp.cq.callfd != -1) + eventfd_write(virtq->eqp.cq.callfd, (eventfd_t)1); DRV_LOG(DEBUG, "vid %u virtq %u was created successfully.", priv->vid, index); return 0;