[V1] tests/port_control: Optimize script check the port status after restarting the port
Checks
Context |
Check |
Description |
ci/Intel-dts-format-test |
success
|
Testing OK
|
ci/Intel-dts-pylama-test |
success
|
Testing OK
|
ci/Intel-dts-suite-test |
success
|
Testing OK
|
Commit Message
The port status should be checked when the port is stopped and
restarted, not after the pmd is started.
Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
tests/TestSuite_port_control.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Monday, October 17, 2022 1:17 PM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1] tests/port_control: Optimize script check the port
> status after restarting the port
>
> The port status should be checked when the port is stopped and restarted,
> not after the pmd is started.
>
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
Tested-by: Song Jiale <songx.jiale@intel.com >
> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Monday, October 17, 2022 1:17 PM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1] tests/port_control: Optimize script check the port
> status after restarting the port
>
> The port status should be checked when the port is stopped and restarted, not
> after the pmd is started.
>
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---
Acked-by: Zhimin Huang <zhiminx.huang@intel.com >
On Mon, 17 Oct 2022 13:16:51 +0800, Weiyuan Li <weiyuanx.li@intel.com> wrote:
> The port status should be checked when the port is stopped and
> restarted, not after the pmd is started.
>
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
Applied, thanks
@@ -124,9 +124,9 @@ class TestPortControl(TestCase):
def start_pmd_port(self, terminal):
terminal.execute_cmd("port start all")
+ terminal.wait_link_status_up("all")
terminal.execute_cmd("start")
time.sleep(5)
- terminal.wait_link_status_up("all", timeout=5)
ret = terminal.get_port_link_status(self.port_id_0)
self.verify(ret == "up", "port not up!")