From patchwork Sat Nov 10 09:59:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Slava Ovsiienko X-Patchwork-Id: 47978 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A6CA32BCE; Sat, 10 Nov 2018 10:59:27 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140084.outbound.protection.outlook.com [40.107.14.84]) by dpdk.org (Postfix) with ESMTP id 14513239 for ; Sat, 10 Nov 2018 10:59:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dFI0TgbUFqtbhtuw49b+JibsrIvE+n7bra4eYHwidA8=; b=HY3BvPUAWXSqAocPme8bL6ISLWEJTFZVWIZQIgegTmvIeI+/wqjHi7DrlzaO4aJZpla1Ve0EWOGZXmTxwxlW/KPFri669R/ouW1uNqHXLT7zjzNshtWFmX/G+2AMuny3O8ZMosWJhPI6KoSEl9QmSasVgCTEhhHw1QDbjckPnCs= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.186.150) by AM4PR05MB3250.eurprd05.prod.outlook.com (10.171.186.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.21; Sat, 10 Nov 2018 09:59:24 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::544b:a68d:e6a5:ba6e]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::544b:a68d:e6a5:ba6e%2]) with mapi id 15.20.1294.039; Sat, 10 Nov 2018 09:59:24 +0000 From: Slava Ovsiienko To: Shahaf Shuler , Yongseok Koh CC: "dev@dpdk.org" , Slava Ovsiienko Thread-Topic: [PATCH 0/3] fix VXLAN related rules cleanup and management Thread-Index: AQHUeNwPhAfWAWAf40mCoKTHboxzTA== Date: Sat, 10 Nov 2018 09:59:24 +0000 Message-ID: <1541843951-31708-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: CWLP265CA0342.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:5a::18) To AM4PR05MB3265.eurprd05.prod.outlook.com (2603:10a6:205:4::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3250; 6:SPlS4jIqhUydiwWLKKA+c8X+KqdpCsvaEITFBaB9W14rb1m11Kp8T57Zb7zcToWpxWqcEOdo/ENiZN1Sp1xa0E6UPvWA0eOppGFd1BDdVL41NihOyDt7pVgmQRN8qiTXg+CJP74qxzNM2cT6fQ/TZyFxzC9WcWFl+w1X8B0dn18psvj/A0zyfcj7YXo0zeSe06ZpRANgrW8L2CNFR9vDZeEkC+8pq2m6/NOm7wSGlW2LHVntDcCBLpcSEp2nFBMbN8FASuS3r/lf5D2c7g4Fm+BcdSL78Ae4jVM8LbOdChBYhb2ze8jhOCQV6qT7kEL56YOnx5pMLudBLm5LzgPiew/+cuNBVHecADJpp83ngwQEaLonGMuNkKzYyzPWoWBI5h9daadgd+ERjUnP5H7XTCjmRzl/0UtcJHk80rcB+l7VpdstoM42802c+hIgy6yaD+/QRpRX4E7rJtFQP87JGg==; 5:sMXYPhcB+E9QbmODJqJNn+d1n7YwwZosLlD0+ua1qLJk9WkXeu2DExiJ/Z/UwpMPdoSJEoGf8lRkh2gEA9YnGzKYVNeArboD2p+UDuvG0S4/WceWdZJVdBlUO2cxPu8gx6RKQzH/Zq1NT6BEJeLrBNF0+KoUqX4GH9RiS6lcfMo=; 7:bKSICKoZjDx3uOd0FMa7YFxI+o9KS5zSXhZgVeMv8xqzqhTpIKOFkjr+ky8g7l9dVwK4dW69zZhN7YUovyvskH1axEK9AmXU5B1i0VLb9b4xrwct1fI/lsGC4fGmRmbf2fT4LEh2Xz76YF9DdwneQg== x-ms-office365-filtering-correlation-id: bf3a281c-38fd-4bdb-aeeb-08d646f33143 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390040)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3250; x-ms-traffictypediagnostic: AM4PR05MB3250: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:AM4PR05MB3250; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3250; x-forefront-prvs: 0852EB6797 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(39860400002)(346002)(136003)(366004)(199004)(189003)(2616005)(6436002)(476003)(486006)(4326008)(7736002)(2906002)(3846002)(186003)(54906003)(105586002)(6486002)(6116002)(305945005)(25786009)(110136005)(66066001)(386003)(6506007)(14454004)(102836004)(36756003)(52116002)(81156014)(97736004)(81166006)(6512007)(106356001)(8676002)(2900100001)(53936002)(107886003)(316002)(478600001)(71200400001)(99286004)(8936002)(68736007)(14444005)(6636002)(256004)(5660300001)(71190400001)(86362001)(85306007)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3250; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: UYySgv0bHlKPpde908VOnw2o+oifoS8uZ0p+ccH9htLkuAl5XTlxDxJ683KgTuCCSoLMHeMTNZMFly11HIs9osNYh+YPL7Zt2xyJeAN8eemmDPn4xMSc4lZmPTIJl3HTaY44BWZ6gABfXYkjziZag/ANCNqr+bbRkDFlSrtDUD8g1/XCHRjrhEf5qgyk5o8TaWTB3noo+946o78fVmwotipKgSu2iaOBqR6UXJ63YNxiZPEuAinW/XEVRiYI/Bjs4a0UYLHaejj8vz8nsMwH0YURHVSf1vWVrruA92+7nD8rB+pZuv2wflN1thI2OVWkukeN6b+K7LBTgqrC8hlTk/AFhnPPJHSkr53CVVKJ/XE= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf3a281c-38fd-4bdb-aeeb-08d646f33143 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2018 09:59:24.4475 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3250 Subject: [dpdk-dev] [PATCH 0/3] fix VXLAN related rules cleanup and management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The VXLAN related rule cleanup routine queries and gathers all existing local IP and neigh rules into buffer list. One buffer may contain multiple rule deletetion commands and is prepared to send into Netlink as single message. But, if error occurs for some deletion commands in the buffer, the multiple ACK message with errors can be send back by the kernel. It breaks the Netlink communication sequence numbers, because we expect only one ACK message and it smashes out futher Netlik communication. The workaround of this problem is to send rule deletion commands from buffer in one-by-one fashion and get ACK message for every command sent. We do not expect too may rules preexist, so there should not be critical performance degradation at VXLAN outer interface initialization. Viacheslav Ovsiienko (3): net/mlx5: fix buffer allocation check in rule cleanup net/mlx5: add Netlink message size check in rule cleanup net/mlx5: fix rule cleanup Netlink command sending drivers/net/mlx5/mlx5_flow_tcf.c | 93 +++++++++++++++++++--------------------- 1 file changed, 45 insertions(+), 48 deletions(-)