Message ID | 1544773540-89825-1-git-send-email-jia.guo@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2CA821B6D1; Fri, 14 Dec 2018 08:41:32 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id E9D8D1B613 for <dev@dpdk.org>; Fri, 14 Dec 2018 08:41:29 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2018 23:41:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,352,1539673200"; d="scan'208";a="100641729" Received: from jeffguo-s2600wt2.sh.intel.com (HELO localhost.localdomain) ([10.67.110.10]) by orsmga006.jf.intel.com with ESMTP; 13 Dec 2018 23:41:25 -0800 From: Jeff Guo <jia.guo@intel.com> To: bernard.iremonger@intel.com, wenzhuo.lu@intel.com, shahafs@mellanox.com, thomas@monjalon.net, matan@mellanox.com Cc: ferruh.yigit@intel.com, konstantin.ananyev@intel.com, dev@dpdk.org, jia.guo@intel.com, stephen@networkplumber.org, gaetan.rivet@6wind.com, qi.z.zhang@intel.com, arybchenko@solarflare.com, bruce.richardson@intel.com, shaopeng.he@intel.com, anatoly.burakov@intel.com Date: Fri, 14 Dec 2018 15:45:37 +0800 Message-Id: <1544773540-89825-1-git-send-email-jia.guo@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH 0/3] use a common eal device event for hot-unplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
use a common eal device event for hot-unplug
|
|
Message
Guo, Jia
Dec. 14, 2018, 7:45 a.m. UTC
This patch set aim to use a common eal device event mechanism to manage devices for hot-unplug whatever device types, so the previous ethdev remove event will be deleted and the device detach will be remove from app into eal framework. Jeff Guo (3): eal: add --dev-hotplug option ethdev: remove ethdev rmv interrupt testpmd: remove device detach into eal app/test-pmd/parameters.c | 2 -- app/test-pmd/testpmd.c | 41 +++--------------------------- drivers/bus/pci/pci_common.c | 7 +++++ drivers/net/failsafe/failsafe_ether.c | 12 ++++----- drivers/net/failsafe/failsafe_ops.c | 3 +-- drivers/net/failsafe/failsafe_private.h | 6 ++--- drivers/net/mlx4/mlx4_intr.c | 1 - drivers/net/mlx5/mlx5_ethdev.c | 7 ++--- lib/librte_eal/bsdapp/eal/eal.c | 16 ++++++++++++ lib/librte_eal/common/eal_common_options.c | 5 ++++ lib/librte_eal/common/eal_internal_cfg.h | 1 + lib/librte_eal/common/eal_options.h | 4 ++- lib/librte_eal/linuxapp/eal/eal.c | 16 ++++++++++++ lib/librte_eal/linuxapp/eal/eal_dev.c | 16 +++++++++++- lib/librte_ethdev/rte_ethdev.h | 1 - 15 files changed, 79 insertions(+), 59 deletions(-)
Comments
Hi Jia > -----Original Message----- > From: Guo, Jia > Sent: Friday, December 14, 2018 7:46 AM > To: Iremonger, Bernard <bernard.iremonger@intel.com>; Lu, Wenzhuo > <wenzhuo.lu@intel.com>; shahafs@mellanox.com; thomas@monjalon.net; > matan@mellanox.com > Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Ananyev, Konstantin > <konstantin.ananyev@intel.com>; dev@dpdk.org; Guo, Jia > <jia.guo@intel.com>; stephen@networkplumber.org; gaetan.rivet@6wind.com; > Zhang, Qi Z <qi.z.zhang@intel.com>; arybchenko@solarflare.com; Richardson, > Bruce <bruce.richardson@intel.com>; He, Shaopeng <shaopeng.he@intel.com>; > Burakov, Anatoly <anatoly.burakov@intel.com> > Subject: [PATCH 0/3] use a common eal device event for hot-unplug > > This patch set aim to use a common eal device event mechanism to manage > devices for hot-unplug whatever device types, so the previous ethdev remove > event will be deleted and the device detach will be remove from app into eal > framework. > > Jeff Guo (3): > eal: add --dev-hotplug option > ethdev: remove ethdev rmv interrupt > testpmd: remove device detach into eal > > app/test-pmd/parameters.c | 2 -- > app/test-pmd/testpmd.c | 41 +++--------------------------- > drivers/bus/pci/pci_common.c | 7 +++++ > drivers/net/failsafe/failsafe_ether.c | 12 ++++----- > drivers/net/failsafe/failsafe_ops.c | 3 +-- > drivers/net/failsafe/failsafe_private.h | 6 ++--- > drivers/net/mlx4/mlx4_intr.c | 1 - > drivers/net/mlx5/mlx5_ethdev.c | 7 ++--- > lib/librte_eal/bsdapp/eal/eal.c | 16 ++++++++++++ > lib/librte_eal/common/eal_common_options.c | 5 ++++ > lib/librte_eal/common/eal_internal_cfg.h | 1 + > lib/librte_eal/common/eal_options.h | 4 ++- > lib/librte_eal/linuxapp/eal/eal.c | 16 ++++++++++++ > lib/librte_eal/linuxapp/eal/eal_dev.c | 16 +++++++++++- > lib/librte_ethdev/rte_ethdev.h | 1 - > 15 files changed, 79 insertions(+), 59 deletions(-) > > -- > 2.7.4 This patch set fails to apply to DPDK 19.05.rc1 and probably needs to be rebased. Regards, Bernard.
Unifying hotplug and device event support would be good idea but this patch has gone stale. And supporting it would require API changes (need to wait for next LTS) and a lot of testing. Also, hotplug is a complex topic which has a lot of platform dependencies. If someone wants to do a more general solution this patchset is worth looking at. But for now it needs to be marked rejected in patchwork.