From patchwork Mon Jul 15 15:39:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Carrillo, Erik G" X-Patchwork-Id: 56460 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D1B492C18; Mon, 15 Jul 2019 17:39:22 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 00E152BA8 for ; Mon, 15 Jul 2019 17:39:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jul 2019 08:39:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,493,1557212400"; d="scan'208";a="161116889" Received: from wcpqa1.an.intel.com ([10.123.72.207]) by orsmga008.jf.intel.com with ESMTP; 15 Jul 2019 08:39:19 -0700 From: Erik Gabriel Carrillo To: thomas@monjalon.net Cc: dev@dpdk.org Date: Mon, 15 Jul 2019 10:39:30 -0500 Message-Id: <1563205172-352-1-git-send-email-erik.g.carrillo@intel.com> X-Mailer: git-send-email 1.7.10 Subject: [dpdk-dev] [PATCH 0/2] fix segfault seen with performance-thread example X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A crash occurs in the examples/performance-thread/l3fwd-thread when it calls into rte_timer_manage() from the LThread library it utilizes. This happens because the application omitted a call to rte_timer_subsystem_init(), which leaves a pointer set to null in the timer library. This pointer is dereferenced in a check for validity of a timer data object, resulting in the segfault. This series fixes the validity check in the timer library, and adds the missing call to rte_timer_subsystem_init in the application. Erik Gabriel Carrillo (2): timer: fix null pointer dereference examples/performance-thread: init timer subsystem examples/performance-thread/l3fwd-thread/main.c | 5 +++++ lib/librte_timer/rte_timer.c | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-)