mbox series

[kmods,v3,0/3] windows/virt2phys: fix paging issue

Message ID 20211012004212.429929-1-dmitry.kozliuk@gmail.com (mailing list archive)
Headers show
Series windows/virt2phys: fix paging issue | expand

Message

Dmitry Kozlyuk Oct. 12, 2021, 12:42 a.m. UTC
Physical addresses exposed by virt2phys driver could become pageable.
This presents stability and security issues that prevent Microsoft
from signing virt2phys, because a signed driver would be trusted
by all end-user machines.

Ensure that memory for which physical addresses are exposed by
virt2phys is non-pageable at least for the lifetime of the process.
As virt2phys code grows, make its development and debugging easier.

There are other known issues that come from using PA and accessing DMA
from userspace. They are not related to virt2phys par se. It is planned
to address them later by enabling the use of IOMMU for DPDK on Windows.

Depends-on: series-19342 ("windows: independent fixes")

v3:
    * Fix Release build (Ranjit).
    * Drop PnpLockdown=1 patch as it is now in dependency series.
v2:
    * Following ofline review by DmitryM:
      - Add comment explaining tracking approach for validation team.
      - Replace deprecated allocation API calls.
      - Check properties of locked memory (see docs in patch 3/4).
      - Add configurable limits for tracked processes and memory.
    * Add end-user documentation.
    * Drop patch for Inf2Cat settings UseLocalTime=true:
      the issue it resolves originated from development VM.
    * Add PnpLockdown=1 patch.


Dmitry Kozlyuk (3):
  windows/virt2phys: do not expose pageable physical addresses
  windows/virt2phys: add limits against resource exhaustion
  windows/virt2phys: add tracing

 windows/virt2phys/README.md                 |  38 ++
 windows/virt2phys/virt2phys.c               | 173 ++++++--
 windows/virt2phys/virt2phys.vcxproj         |  11 +-
 windows/virt2phys/virt2phys.vcxproj.filters |  11 +-
 windows/virt2phys/virt2phys_logic.c         | 415 ++++++++++++++++++++
 windows/virt2phys/virt2phys_logic.h         |  39 ++
 windows/virt2phys/virt2phys_trace.h         |  50 +++
 7 files changed, 703 insertions(+), 34 deletions(-)
 create mode 100644 windows/virt2phys/README.md
 create mode 100644 windows/virt2phys/virt2phys_logic.c
 create mode 100644 windows/virt2phys/virt2phys_logic.h
 create mode 100644 windows/virt2phys/virt2phys_trace.h

Comments

Thomas Monjalon Jan. 11, 2022, 1:56 p.m. UTC | #1
12/10/2021 02:42, Dmitry Kozlyuk:
> v3:
>     * Fix Release build (Ranjit).
>     * Drop PnpLockdown=1 patch as it is now in dependency series.
> v2:
>     * Following ofline review by DmitryM:
>       - Add comment explaining tracking approach for validation team.
>       - Replace deprecated allocation API calls.
>       - Check properties of locked memory (see docs in patch 3/4).
>       - Add configurable limits for tracked processes and memory.
>     * Add end-user documentation.
>     * Drop patch for Inf2Cat settings UseLocalTime=true:
>       the issue it resolves originated from development VM.
>     * Add PnpLockdown=1 patch.
> 
> 
> Dmitry Kozlyuk (3):
>   windows/virt2phys: do not expose pageable physical addresses
>   windows/virt2phys: add limits against resource exhaustion
>   windows/virt2phys: add tracing

I suppose we will never have a review from Microsoft, so
Applied, thanks.