Message ID | 20211025113208.3910951-1-wojciechx.liguzinski@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B818A0C52; Mon, 25 Oct 2021 13:32:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC9FF40E32; Mon, 25 Oct 2021 13:32:24 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 0B55E407FF for <dev@dpdk.org>; Mon, 25 Oct 2021 13:32:22 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10147"; a="228389859" X-IronPort-AV: E=Sophos;i="5.87,180,1631602800"; d="scan'208";a="228389859" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2021 04:32:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,180,1631602800"; d="scan'208";a="446191719" Received: from silpixa00400629.ir.intel.com ([10.237.213.30]) by orsmga006.jf.intel.com with ESMTP; 25 Oct 2021 04:32:11 -0700 From: "Liguzinski, WojciechX" <wojciechx.liguzinski@intel.com> To: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com Cc: megha.ajmera@intel.com Date: Mon, 25 Oct 2021 11:32:03 +0000 Message-Id: <20211025113208.3910951-1-wojciechx.liguzinski@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211020075002.3871469-1-wojciechx.liguzinski@intel.com> References: <20211020075002.3871469-1-wojciechx.liguzinski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | Add PIE support for HQoS library | |
Message
Liguzinski, WojciechX
Oct. 25, 2021, 11:32 a.m. UTC
DPDK sched library is equipped with mechanism that secures it from the bufferbloat problem which is a situation when excess buffers in the network cause high latency and latency variation. Currently, it supports RED for active queue management. However, more advanced queue management is required to address this problem and provide desirable quality of service to users. This solution (RFC) proposes usage of new algorithm called "PIE" (Proportional Integral controller Enhanced) that can effectively and directly control queuing latency to address the bufferbloat problem. The implementation of mentioned functionality includes modification of existing and adding a new set of data structures to the library, adding PIE related APIs. This affects structures in public API/ABI. That is why deprecation notice is going to be prepared and sent. Liguzinski, WojciechX (5): sched: add PIE based congestion management example/qos_sched: add PIE support example/ip_pipeline: add PIE support doc/guides/prog_guide: added PIE app/test: add tests for PIE app/test/meson.build | 4 + app/test/test_pie.c | 1065 ++++++++++++++++++ config/rte_config.h | 1 - doc/guides/prog_guide/glossary.rst | 3 + doc/guides/prog_guide/qos_framework.rst | 64 +- doc/guides/prog_guide/traffic_management.rst | 13 +- drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- examples/ip_pipeline/tmgr.c | 142 +-- examples/qos_sched/cfg_file.c | 127 ++- examples/qos_sched/cfg_file.h | 5 + examples/qos_sched/init.c | 27 +- examples/qos_sched/main.h | 3 + examples/qos_sched/profile.cfg | 196 ++-- lib/sched/meson.build | 3 +- lib/sched/rte_pie.c | 86 ++ lib/sched/rte_pie.h | 398 +++++++ lib/sched/rte_sched.c | 241 ++-- lib/sched/rte_sched.h | 63 +- lib/sched/version.map | 4 + 19 files changed, 2172 insertions(+), 279 deletions(-) create mode 100644 app/test/test_pie.c create mode 100644 lib/sched/rte_pie.c create mode 100644 lib/sched/rte_pie.h
Comments
Hi Thomas,
Would you merge this patch as the series is acked by Cristian as below?
https://patchwork.dpdk.org/project/dpdk/cover/20211019081902.3514841-1-wojciechx.liguzinski@intel.com/
Thanks & Regards,
Yu Liu
-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of Liguzinski, WojciechX
Sent: Monday, October 25, 2021 7:32 PM
To: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
Cc: Ajmera, Megha <megha.ajmera@intel.com>
Subject: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library
DPDK sched library is equipped with mechanism that secures it from the bufferbloat problem which is a situation when excess buffers in the network cause high latency and latency variation. Currently, it supports RED for active queue management. However, more advanced queue management is required to address this problem and provide desirable quality of service to users.
This solution (RFC) proposes usage of new algorithm called "PIE" (Proportional Integral controller Enhanced) that can effectively and directly control queuing latency to address the bufferbloat problem.
The implementation of mentioned functionality includes modification of existing and adding a new set of data structures to the library, adding PIE related APIs.
This affects structures in public API/ABI. That is why deprecation notice is going to be prepared and sent.
Liguzinski, WojciechX (5):
sched: add PIE based congestion management
example/qos_sched: add PIE support
example/ip_pipeline: add PIE support
doc/guides/prog_guide: added PIE
app/test: add tests for PIE
app/test/meson.build | 4 +
app/test/test_pie.c | 1065 ++++++++++++++++++
config/rte_config.h | 1 -
doc/guides/prog_guide/glossary.rst | 3 +
doc/guides/prog_guide/qos_framework.rst | 64 +-
doc/guides/prog_guide/traffic_management.rst | 13 +-
drivers/net/softnic/rte_eth_softnic_tm.c | 6 +-
examples/ip_pipeline/tmgr.c | 142 +--
examples/qos_sched/cfg_file.c | 127 ++-
examples/qos_sched/cfg_file.h | 5 +
examples/qos_sched/init.c | 27 +-
examples/qos_sched/main.h | 3 +
examples/qos_sched/profile.cfg | 196 ++--
lib/sched/meson.build | 3 +-
lib/sched/rte_pie.c | 86 ++
lib/sched/rte_pie.h | 398 +++++++
lib/sched/rte_sched.c | 241 ++--
lib/sched/rte_sched.h | 63 +-
lib/sched/version.map | 4 +
19 files changed, 2172 insertions(+), 279 deletions(-) create mode 100644 app/test/test_pie.c create mode 100644 lib/sched/rte_pie.c create mode 100644 lib/sched/rte_pie.h
--
2.25.1
Series-acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
26/10/2021 10:24, Liu, Yu Y: > Hi Thomas, > > Would you merge this patch as the series is acked by Cristian as below? > https://patchwork.dpdk.org/project/dpdk/cover/20211019081902.3514841-1-wojciechx.liguzinski@intel.com/ I didn't see any email from Cristian. It seems you just added this ack silently at the bottom of the cover letter. 1/ an email from Cristian is far better 2/ when integrating ack, it must be done in patches, not cover letter > > Thanks & Regards, > Yu Liu > > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Liguzinski, WojciechX > Sent: Monday, October 25, 2021 7:32 PM > To: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian <cristian.dumitrescu@intel.com> > Cc: Ajmera, Megha <megha.ajmera@intel.com> > Subject: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library > > DPDK sched library is equipped with mechanism that secures it from the bufferbloat problem which is a situation when excess buffers in the network cause high latency and latency variation. Currently, it supports RED for active queue management. However, more advanced queue management is required to address this problem and provide desirable quality of service to users. > > This solution (RFC) proposes usage of new algorithm called "PIE" (Proportional Integral controller Enhanced) that can effectively and directly control queuing latency to address the bufferbloat problem. > > The implementation of mentioned functionality includes modification of existing and adding a new set of data structures to the library, adding PIE related APIs. > This affects structures in public API/ABI. That is why deprecation notice is going to be prepared and sent. > > Liguzinski, WojciechX (5): > sched: add PIE based congestion management > example/qos_sched: add PIE support > example/ip_pipeline: add PIE support > doc/guides/prog_guide: added PIE > app/test: add tests for PIE > > app/test/meson.build | 4 + > app/test/test_pie.c | 1065 ++++++++++++++++++ > config/rte_config.h | 1 - > doc/guides/prog_guide/glossary.rst | 3 + > doc/guides/prog_guide/qos_framework.rst | 64 +- > doc/guides/prog_guide/traffic_management.rst | 13 +- > drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- > examples/ip_pipeline/tmgr.c | 142 +-- > examples/qos_sched/cfg_file.c | 127 ++- > examples/qos_sched/cfg_file.h | 5 + > examples/qos_sched/init.c | 27 +- > examples/qos_sched/main.h | 3 + > examples/qos_sched/profile.cfg | 196 ++-- > lib/sched/meson.build | 3 +- > lib/sched/rte_pie.c | 86 ++ > lib/sched/rte_pie.h | 398 +++++++ > lib/sched/rte_sched.c | 241 ++-- > lib/sched/rte_sched.h | 63 +- > lib/sched/version.map | 4 + > 19 files changed, 2172 insertions(+), 279 deletions(-) create mode 100644 app/test/test_pie.c create mode 100644 lib/sched/rte_pie.c create mode 100644 lib/sched/rte_pie.h > > -- > 2.25.1 > > Series-acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> >
> -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Tuesday, October 26, 2021 9:33 AM > To: Liguzinski, WojciechX <wojciechx.liguzinski@intel.com>; Singh, Jasvinder > <jasvinder.singh@intel.com>; Dumitrescu, Cristian > <cristian.dumitrescu@intel.com>; Liu, Yu Y <yu.y.liu@intel.com> > Cc: dev@dpdk.org; Ajmera, Megha <megha.ajmera@intel.com>; Liu, Yu Y > <yu.y.liu@intel.com>; david.marchand@redhat.com > Subject: Re: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library > > 26/10/2021 10:24, Liu, Yu Y: > > Hi Thomas, > > > > Would you merge this patch as the series is acked by Cristian as below? > > > https://patchwork.dpdk.org/project/dpdk/cover/20211019081902.3514841- > 1-wojciechx.liguzinski@intel.com/ > > I didn't see any email from Cristian. > It seems you just added this ack silently at the bottom of the cover letter. > > 1/ an email from Cristian is far better > 2/ when integrating ack, it must be done in patches, not cover letter > Hi Thomas, I did ack this set in a previous version (V15) by replying with "Series-acked-by" on the cover letter email, which does not show in patchwork. Is there a better way to do this? It would be good to have Jasvinder's ack as well on this series, as he is looking into some other aspects of the sched library. Regards, Cristian > > > > > Thanks & Regards, > > Yu Liu > > > > -----Original Message----- > > From: dev <dev-bounces@dpdk.org> On Behalf Of Liguzinski, WojciechX > > Sent: Monday, October 25, 2021 7:32 PM > > To: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>; > Dumitrescu, Cristian <cristian.dumitrescu@intel.com> > > Cc: Ajmera, Megha <megha.ajmera@intel.com> > > Subject: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library > > > > DPDK sched library is equipped with mechanism that secures it from the > bufferbloat problem which is a situation when excess buffers in the network > cause high latency and latency variation. Currently, it supports RED for active > queue management. However, more advanced queue management is > required to address this problem and provide desirable quality of service to > users. > > > > This solution (RFC) proposes usage of new algorithm called "PIE" > (Proportional Integral controller Enhanced) that can effectively and directly > control queuing latency to address the bufferbloat problem. > > > > The implementation of mentioned functionality includes modification of > existing and adding a new set of data structures to the library, adding PIE > related APIs. > > This affects structures in public API/ABI. That is why deprecation notice is > going to be prepared and sent. > > > > Liguzinski, WojciechX (5): > > sched: add PIE based congestion management > > example/qos_sched: add PIE support > > example/ip_pipeline: add PIE support > > doc/guides/prog_guide: added PIE > > app/test: add tests for PIE > > > > app/test/meson.build | 4 + > > app/test/test_pie.c | 1065 ++++++++++++++++++ > > config/rte_config.h | 1 - > > doc/guides/prog_guide/glossary.rst | 3 + > > doc/guides/prog_guide/qos_framework.rst | 64 +- > > doc/guides/prog_guide/traffic_management.rst | 13 +- > > drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- > > examples/ip_pipeline/tmgr.c | 142 +-- > > examples/qos_sched/cfg_file.c | 127 ++- > > examples/qos_sched/cfg_file.h | 5 + > > examples/qos_sched/init.c | 27 +- > > examples/qos_sched/main.h | 3 + > > examples/qos_sched/profile.cfg | 196 ++-- > > lib/sched/meson.build | 3 +- > > lib/sched/rte_pie.c | 86 ++ > > lib/sched/rte_pie.h | 398 +++++++ > > lib/sched/rte_sched.c | 241 ++-- > > lib/sched/rte_sched.h | 63 +- > > lib/sched/version.map | 4 + > > 19 files changed, 2172 insertions(+), 279 deletions(-) create mode 100644 > app/test/test_pie.c create mode 100644 lib/sched/rte_pie.c create mode > 100644 lib/sched/rte_pie.h > > > > -- > > 2.25.1 > > > > Series-acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > > > > > >
26/10/2021 12:02, Dumitrescu, Cristian: > From: Thomas Monjalon <thomas@monjalon.net> > > 26/10/2021 10:24, Liu, Yu Y: > > > Hi Thomas, > > > > > > Would you merge this patch as the series is acked by Cristian as below? > > > > > https://patchwork.dpdk.org/project/dpdk/cover/20211019081902.3514841- > > 1-wojciechx.liguzinski@intel.com/ > > > > I didn't see any email from Cristian. > > It seems you just added this ack silently at the bottom of the cover letter. > > > > 1/ an email from Cristian is far better > > 2/ when integrating ack, it must be done in patches, not cover letter > > > > Hi Thomas, > > I did ack this set in a previous version (V15) by replying with "Series-acked-by" on the cover letter email, which does not show in patchwork. Is there a better way to do this? No you did the right thing (I missed this email on v15). But v16 did not show your ack. And v17 added it only in the cover letter instead of reporting it in all patches. > It would be good to have Jasvinder's ack as well on this series, as he is looking into some other aspects of the sched library. Yes
Hi, V16 - My bad, probably I haven't copied it correctly when preparing cover letter V17 - I understood Cristian's comment as to copy the Series ACK to next versions of patches, and not to "split it" for each one. If that was the correct way I had no knowledge about it. Wojtek -----Original Message----- From: Thomas Monjalon <thomas@monjalon.net> Sent: Tuesday, October 26, 2021 12:10 PM To: Liguzinski, WojciechX <wojciechx.liguzinski@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>; Liu, Yu Y <yu.y.liu@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian <cristian.dumitrescu@intel.com> Cc: dev@dpdk.org; Ajmera, Megha <megha.ajmera@intel.com>; Liu, Yu Y <yu.y.liu@intel.com>; david.marchand@redhat.com Subject: Re: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library 26/10/2021 12:02, Dumitrescu, Cristian: > From: Thomas Monjalon <thomas@monjalon.net> > > 26/10/2021 10:24, Liu, Yu Y: > > > Hi Thomas, > > > > > > Would you merge this patch as the series is acked by Cristian as below? > > > > > https://patchwork.dpdk.org/project/dpdk/cover/20211019081902.3514841 > > - > > 1-wojciechx.liguzinski@intel.com/ > > > > I didn't see any email from Cristian. > > It seems you just added this ack silently at the bottom of the cover letter. > > > > 1/ an email from Cristian is far better 2/ when integrating ack, it > > must be done in patches, not cover letter > > > > Hi Thomas, > > I did ack this set in a previous version (V15) by replying with "Series-acked-by" on the cover letter email, which does not show in patchwork. Is there a better way to do this? No you did the right thing (I missed this email on v15). But v16 did not show your ack. And v17 added it only in the cover letter instead of reporting it in all patches. > It would be good to have Jasvinder's ack as well on this series, as he is looking into some other aspects of the sched library. Yes
26/10/2021 12:20, Liguzinski, WojciechX: > Hi, > > V16 - My bad, probably I haven't copied it correctly when preparing cover letter > V17 - I understood Cristian's comment as to copy the Series ACK to next versions of patches, and not to "split it" for each one. If that was the correct way I had no knowledge about it. Yes you had to reproduce it in each patch. Otherwise who would do it to make it appear in patchwork and in the git history when merged? I understand you did not have that knowledge. For future, I hope the Intel team will better track features patches of newcomers so they don't miss something knew by others. John, I know knowledge sharing is not an easy task, we always have to improve :) > From: Thomas Monjalon <thomas@monjalon.net> > 26/10/2021 12:02, Dumitrescu, Cristian: > > From: Thomas Monjalon <thomas@monjalon.net> > > > 26/10/2021 10:24, Liu, Yu Y: > > > > Hi Thomas, > > > > > > > > Would you merge this patch as the series is acked by Cristian as below? > > > > > > > https://patchwork.dpdk.org/project/dpdk/cover/20211019081902.3514841 > > > - > > > 1-wojciechx.liguzinski@intel.com/ > > > > > > I didn't see any email from Cristian. > > > It seems you just added this ack silently at the bottom of the cover letter. > > > > > > 1/ an email from Cristian is far better 2/ when integrating ack, it > > > must be done in patches, not cover letter > > > > > > > Hi Thomas, > > > > I did ack this set in a previous version (V15) by replying with "Series-acked-by" on the cover letter email, which does not show in patchwork. Is there a better way to do this? > > No you did the right thing (I missed this email on v15). > But v16 did not show your ack. > And v17 added it only in the cover letter instead of reporting it in all patches. > > > > It would be good to have Jasvinder's ack as well on this series, as he is looking into some other aspects of the sched library. > > Yes > > >