From patchwork Fri Dec 3 22:55:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Douthit X-Patchwork-Id: 104858 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20D41A0C41; Fri, 3 Dec 2021 23:56:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A910D4067B; Fri, 3 Dec 2021 23:56:00 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2111.outbound.protection.outlook.com [40.107.21.111]) by mails.dpdk.org (Postfix) with ESMTP id F1F2E40041 for ; Fri, 3 Dec 2021 23:55:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M7u/6VwANFNcIbwqB3Uaz/OygkLqPdDZZHhdjtIOKMUwGR/rPryjj5VK2I7xsik2XeT6jel2U3VLfkBTvL5Tuef7SY4+9sEcYKGLuBIIxtMXmso4KbRN3QgH/zwLsFR0WuPKzu/SnirVylfJEfc44YT03haooERCD0AnEcetZdTkclRdEaaVZmQa0n0+ElnmXH78jqbafymYmlJ6Yb7yU22Oc1i2QHSNPRSOcyWmuW7BoQFWTZg/8//MYH4qfg0bvp7e4qfFbzl/0tRnRhh2HjseFEuC4z8orpVk5Utcj0gKh4uotBwN0537ddQ8un2g2c9jHDy1c3K/JRh8VAegOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VSBy8ebkR1rYDzX7NqKytuRFwnQVARpHul7D5nQU5Z4=; b=D0iDx9f2s+MgUGirZWvBYDCh2gF7bEGipv39AWsJx5AAtzy7wkubqxtgm661/wSTGyjv6ppVRnwJtRC+0Cg1ZdCVHInVPkeqDHiAXsn5JSIgfC71yxuf0Af6n9yXvxtMhmKcWFNcUxd4gjOolt1X9mX69wD6fE+tdQku6oPSVvjyMHXsf96uovE75EnhZXhlcZv6Q6rKTHYH8SdL5MLl+aweL2aOv3rKwwELBYAmy4TOwkZ+hw486n0DkwDKi8p7RfbaQS2RekSW7cAQnHP/YIRCm0t4YbI9U0fXeQm9X8Zfp5xbIgggBK9+dp88gF7SYX0CyGZOAcPyk1bzHtS/dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silicom-usa.com; dmarc=pass action=none header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VSBy8ebkR1rYDzX7NqKytuRFwnQVARpHul7D5nQU5Z4=; b=XY5B/GE0ZlRO6cnc3Enl01HiqFDyITxy2cYZRAqG7AZxTLhH5PJEwnjhiD+5FWvYX1IQvcYYXQm7qhtVVzv5tKTwqAmBOEskro2ONQD3awL2YJ7uHcWLRxRlWRjqyBrsgXh8epsp+NTIzaZUfmkA3A7ap0E8AQhUQy7azQ1iGUY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silicom-usa.com; Received: from AM0PR04MB4083.eurprd04.prod.outlook.com (2603:10a6:208:64::29) by AM0PR04MB6404.eurprd04.prod.outlook.com (2603:10a6:208:178::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec 2021 22:55:52 +0000 Received: from AM0PR04MB4083.eurprd04.prod.outlook.com ([fe80::f4db:d40d:a746:7bfc]) by AM0PR04MB4083.eurprd04.prod.outlook.com ([fe80::f4db:d40d:a746:7bfc%7]) with mapi id 15.20.4755.019; Fri, 3 Dec 2021 22:55:52 +0000 From: Stephen Douthit To: dev@dpdk.org Cc: wenw@silicom-usa.com, Stephen Douthit Subject: [PATCH 0/7] ixgbe SFP handling fixes Date: Fri, 3 Dec 2021 17:55:09 -0500 Message-Id: <20211203225516.571368-1-stephend@silicom-usa.com> X-Mailer: git-send-email 2.31.1 X-ClientProxiedBy: BL1PR13CA0431.namprd13.prod.outlook.com (2603:10b6:208:2c3::16) To AM0PR04MB4083.eurprd04.prod.outlook.com (2603:10a6:208:64::29) MIME-Version: 1.0 Received: from lappy.adi.eng (173.14.114.227) by BL1PR13CA0431.namprd13.prod.outlook.com (2603:10b6:208:2c3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.10 via Frontend Transport; Fri, 3 Dec 2021 22:55:51 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d81c6775-54a6-4687-e0ec-08d9b6b00e7b X-MS-TrafficTypeDiagnostic: AM0PR04MB6404: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +NVa4IOiQMjfESdv1YFRv6q0NKLvGq+YwV6v2b02rITCTFQEjRipJRTEn4p+w3ZQodLys42/QkeQY3vJIrcXgnKiYHO9mGBoZi6az2JbxhX+hRZL2RO4h4p1I/YijNMXUpVMvwgNie+wrv54ugC+Jqh/WDwXFy99BknAOLZCpKRQLdePoU0KqVmZ0lFJ9WG5XMLKr9L/R2X4qMITP4mgme84ztLmUJq6Flq1XcNmDnjEEopXNZtarfna0RD7NjnUXzNPm7dNvQvj/tDHxhTih9FamPr9O/2tSzCdBHOVK3xw04HWhLBz1OowvpPZ8OgOKzxzS5CfOHhcDig6ebLAaFsCkAH9QinS7R5BJwktUTX4XtGE7O0sPNpOO8SISQW0wDJK37k6/ip2yTx1QgaO3YliFwEprm587wf66kAGSCt60r5R9IF6QFvUFADNeSE4gEtcni8970licEEjMPPcThceTZbITIPsxqnLNksi9bT2P/YGh1JuT/qTomdp415UQ8acH1JCPUUTjnQA3Se3ylsrazppMoc2yf3LKwPC1c5TXcgN8XcQuNnYqsJh78LhLvb0uBkczakn8UaYEOA1u8bf1hSdS1kU/JdB5WJ2CeI99gr88D2DefJDoSGffdumIdlpsuRvmo03wlg0SjXRnaWoRANpPWs7QIimy5VTQis08WBNAsiwvnnZK58YPXI2VTUhN7hC/PFO0PWNfB3xOg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR04MB4083.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(2906002)(508600001)(6916009)(8676002)(6486002)(26005)(956004)(83380400001)(316002)(1076003)(36756003)(5660300002)(86362001)(186003)(4326008)(66946007)(2616005)(107886003)(38100700002)(38350700002)(6506007)(66556008)(52116002)(66476007)(6666004)(6512007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zQC8bPCBRZz9VWwPz84jrx7s1clKV02CUcqRPZ+qys7QAPYCSCULHJVkT5N85TofRMgan7C8Ru3NrOvKci+dFcQ8/sLMmZH9u5/vhbDgpAk2xISDjH7QQgc9PT+mUVnGY9zxFzFTMq+SClInZcb9cS34eDfq9cBwlioABu8L0J7dFS2w9EWjEI2ApR/ue4ir48hB5zWzgCDJtK1ZsXxzniUj1K4h3ZuUGO9x/+cAPc7zyqE5Jt1KXJjoD9A3ZTYvMKt9I25keub3oHOM3NVvxU1bY/MOj+cvKm5qItbikn5IV7HY/GgjWrCMgDyxminaWM0bhsJWLu6xN769H37kVxLTJAjX+ptodO9E1MyP3GSyfw2JxzCbREM6YCQKE5ZKCYVN/AZOcP8samTwvK3KB7xOQL015hqcEGxPrZSnV55ahy8t2F+62vioUHkv7QeQcm0DTURZqPH6jVnxHVAhRloQ8cV2IwsIsYhkIIQyIvxkDCu+bYbvfWsRah/lTjzcH7fi3eCasua3pJLY5xy73wtuQQlbZkXNcc2XcSGZD8KBcsSXZZRxQbQkzotRAdfZqv7E/6rTfm71mB5miAXAE2rYQnA9FHKWOG10iSt8SF/VXkMrN5Yv6Y9TZpC8vqdrD0rSFuQCBMLHBzm4gK0X3CzgH98vGK1MxJQzDP2KrdfMJDdv3IggowmDZB0Cgeaw8YXcjDrVwlw/EEh2F9rD4YboR+I9qZ2a1ODcq+2cEg8qTe4o2Bjtm0xNq4GIpfnutrWfV7yfG/u6HgSUAF/RWsN4mR22X7dsX5dOHAWLVmsrC1geVEcZEiA4HD67CWUgW/gGoqUej8hCELtU1v2a5XXXYvHAvUrUfBdJaQubUoixs68kOzikFN8f3uWorxmWNSi7msTATZ0mQZgQWq286ZCMLN1hKH6mcAh7X3jERsMxiiGSJp9Ph3tYbJjHKGe2qApwNtAdYNUTuu6lEEwUSPWPJ4DvyD1zR8HKS6WNng3yklIYK3O0O1BFGP7YXYPX9UugSaMAOTjpf7bLcQsocKDt/3I9K2vWwbuk7BflnfPut8x9DhjrrEpbNJX5PFN1BPddlQgThSSibOxxJOi1itViMeU2QE3GgHkwyYh84OlVyhCrjD1gAR8bY/jsZu2mnpOCYaonS8g9fR1MLyTU85KyChx+gDySyr25ET6ZIjVkESj8urwfRF5ut0BgoRdxJ6pvE5h+f7QMozliCSy/8VlybaVxUF3E8Ai10/sDUon+AdwZL2TTW1ppcTXJZwsm8hB4CvrPcy+/KktzMxhrUkE923P5DpuSjdRH8oo7+MMNQQiBeBgaE5Ui58xh6tEifpjbIu+pYiqDyU8jEoR88XJdvNnIUjM2Nz612fV/w6aoMhHv1gqfZLuJz/a4UpWbfb56PB+trO3U2aZegMx2ERkhZFNRezlq/vlOjvFda05bMH9za3QHFPcwxZbSAvVPcgaO/uTw13uth9VwOl5xupY6un4Zf98Tnx8WjdtnUJBE4irLVBcW+bDw86ram6GLt1g+DYFztKbHwhVve563NW/b9WqSX4B7O32IyE93Z+D40XogpXFnKzd8Jnas501JM7Y/gbDZihAUfn160pPC9fj43l5rCyBZiRwI7hwV/OU9qDSfhrg0+AiXREar8SCl1xbhMon3czV7IH/udvxA0LKSxBLpltiJRd8JVprHK9Y= X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-Network-Message-Id: d81c6775-54a6-4687-e0ec-08d9b6b00e7b X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB4083.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 22:55:52.4044 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: srDJB1va1Hyj9fbZnWBoI+jNXupfIO4puuo0aTGtSq/kv4+btmyL+xX4aU2PSqRTZZr4I2MXJ/KnhvKai7D6Sb79rclmqtsZEdJ0MECVENs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6404 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello all, We have several platforms based on Intel's C3000 series of SoCs that have integrated ixgbe devices (X550EM) operating in the "Native SFI" mode (the 0x15c4 device ID). The first five patches in the series all fix issues relating to the ID and setup of SFPs. Patch 6 allows slow to boot SFPs (like some XGS-PON modules) to work. Patch 7 enables 1G Cu to run with a warning, similar to other unofficially supported modules covered by the allow_unsupported_sfp flag. Currently we use this for g.Fast modules, but other modules that enumerate as 1G Cu may also benefit. Since all of my testing was done on a C3000 platform, and the ixgbe driver now covers a large number of devices, any regression testing that can be done on other ixgbe devices would be greatly appreciated. Thanks, Steve Stephen Douthit (7): net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs net/ixgbe: Add ixgbe_check_sfp_cage() for testing state of PRSNT# signal net/ixgbe: Check that SFF-8472 soft rate select is supported before write net/ixgbe: Run 82599 link status workaround only on affected devices net/ixgbe: Fix SFP detection and linking on hotplug net/ixgbe: Retry SFP ID read field to handle misbehaving SFPs net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices drivers/net/ixgbe/base/ixgbe_82599.c | 41 +++ drivers/net/ixgbe/base/ixgbe_common.c | 106 +++++-- drivers/net/ixgbe/base/ixgbe_common.h | 8 + drivers/net/ixgbe/base/ixgbe_phy.c | 39 ++- drivers/net/ixgbe/base/ixgbe_phy.h | 3 + drivers/net/ixgbe/base/ixgbe_type.h | 2 + drivers/net/ixgbe/base/ixgbe_x550.c | 14 +- drivers/net/ixgbe/ixgbe_ethdev.c | 412 +++++++++++++++++--------- drivers/net/ixgbe/ixgbe_ethdev.h | 18 +- 9 files changed, 468 insertions(+), 175 deletions(-)