From patchwork Sat Feb 19 23:43:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 107845 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5A46A00C4; Sun, 20 Feb 2022 00:43:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66CDD40395; Sun, 20 Feb 2022 00:43:26 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id B69694014E for ; Sun, 20 Feb 2022 00:43:25 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id v8-20020a17090a634800b001bb78857ccdso13215912pjs.1 for ; Sat, 19 Feb 2022 15:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PAxcTKzaZMt7IPOa+A+fGDKsS+9UyI14PjqhNxNEhl0=; b=BksHItyDGBoKTS08T2FY02Xp2gUVQQgENB4dYB2ERXh6Ibel7SHMf866FpFxKogLXY kocTMGXvDJyBkT85gkwVSbl139N+8oU99LOVEBqGIhB4k/bzJQN0cyNT34Fq6dF4poOA VA4vWNUph7vdAyHSqG3oZSxKPmF1B+13iWiB3T2LUWZgKbsPXNUTYldnClhnjElY4c2U h5Ab4zc8Kgj2Ztx10o/djPDUPgv8Iuw3d0crGf7RTfjCjgc6VtfP/N9Cl0DEerhC+AyQ SrBCDZ11IsI55ZRqza96YcT6UqUWzQbTLG9o9ee2n4wPAdLR8h15HZA3Y8GuTDw2/Wzc OZkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PAxcTKzaZMt7IPOa+A+fGDKsS+9UyI14PjqhNxNEhl0=; b=y4jINwBYXd6uY/dS5gpD/tlUh4Hi3uMa6raqj0GBhRZhzrDLKg8fSo/P+URGQQ6fhI 5l4tWVuvNZaAfiFn0Ru1+q5X5Qt1Dv9fAKXJxAr/2UoXNGzBJQnSQ7dtDSRLLm2h6P/8 DrshrCSAtziPv9ARTnN3rcaRuCGXsoW6BhptMmFmDVSuCGZ0Ckf7SzdAiUFOtfwNYU3L 9Saq1oSLVH8eHPhzG0wRtgRIo6Q/4Rzy4vzJNBD2JyVrvRY30sjOVo0/FhZOQ4yS13r8 BdoTrRljH2IQhq8c5UGWTecZxtMuIaFBUuaTvDBn+gNbFD8EsLe8EYE/82Gw8dt+SHUy h4sQ== X-Gm-Message-State: AOAM531ki/GpvMLH5ouv/Br6Njn03h6R+Vn5Hr5HytI+ORNVcgOEjhLj mg12ZhFMdCh/BUkra0KzuxcgwEwKLXjgaXp0 X-Google-Smtp-Source: ABdhPJyiqgIyButqgUl4QxbKdgrVqGQWaVOIHdvpisdW4jyJ8l+iR7fup2NVBUxFZ3pjbkTmbHvwpQ== X-Received: by 2002:a17:90a:9109:b0:1bb:8504:8640 with SMTP id k9-20020a17090a910900b001bb85048640mr14795911pjo.173.1645314204487; Sat, 19 Feb 2022 15:43:24 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id v17-20020a17090a459100b001b93ef45c13sm3057268pjg.55.2022.02.19.15.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Feb 2022 15:43:23 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 0/3] more unnecessary null checks Date: Sat, 19 Feb 2022 15:43:19 -0800 Message-Id: <20220219234322.61309-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thomas suggested there are some other functions that could use the nullfree cleanup. And ACL and LPM are both candidates. Stephen Hemminger (3): cocci/nullfree: add more functions acl: remove unncessary null checks in calls to rte_acl_free() lpm: remove unnecessary NULL checks app/test/test_acl.c | 12 ++++-------- app/test/test_func_reentrancy.c | 3 +-- devtools/cocci/nullfree.cocci | 9 +++++++++ lib/acl/rte_acl.h | 1 + lib/lpm/rte_lpm.h | 1 + lib/lpm/rte_lpm6.h | 1 + lib/table/rte_swx_table_wm.c | 3 +-- lib/table/rte_table_acl.c | 15 +++++---------- 8 files changed, 23 insertions(+), 22 deletions(-)