mbox series

[0/4] cfgfile: enhance error detecting

Message ID 20240220035840.32978-1-fengchengwen@huawei.com (mailing list archive)
Headers
Series cfgfile: enhance error detecting |

Message

fengchengwen Feb. 20, 2024, 3:58 a.m. UTC 
When I was trying to debug a problem introduced by config.ini in
test-dma-perf, I found the cfgfile library should enhance error
detecting, so got this patchset.

Chengwen Feng (4):
  cfgfile: remove dead code
  cfgfile: support verify name and value
  cfgfile: verify add section and entry result
  cfgfile: add unique name flag

 lib/cfgfile/rte_cfgfile.c | 70 +++++++++++++++++++++++++++++----------
 lib/cfgfile/rte_cfgfile.h |  7 ++++
 2 files changed, 59 insertions(+), 18 deletions(-)

Comments

David Marchand July 4, 2024, 3:12 p.m. UTC | #1 
On Tue, Feb 20, 2024 at 5:00 AM Chengwen Feng <fengchengwen@huawei.com> wrote:
>
> When I was trying to debug a problem introduced by config.ini in
> test-dma-perf, I found the cfgfile library should enhance error
> detecting, so got this patchset.
>
> Chengwen Feng (4):
>   cfgfile: remove dead code
>   cfgfile: support verify name and value
>   cfgfile: verify add section and entry result
>   cfgfile: add unique name flag
>
>  lib/cfgfile/rte_cfgfile.c | 70 +++++++++++++++++++++++++++++----------
>  lib/cfgfile/rte_cfgfile.h |  7 ++++
>  2 files changed, 59 insertions(+), 18 deletions(-)

Please review.
Stephen Hemminger July 4, 2024, 9:40 p.m. UTC | #2 
On Tue, 20 Feb 2024 03:58:36 +0000
Chengwen Feng <fengchengwen@huawei.com> wrote:

> When I was trying to debug a problem introduced by config.ini in
> test-dma-perf, I found the cfgfile library should enhance error
> detecting, so got this patchset.
> 
> Chengwen Feng (4):
>   cfgfile: remove dead code
>   cfgfile: support verify name and value
>   cfgfile: verify add section and entry result
>   cfgfile: add unique name flag
> 
>  lib/cfgfile/rte_cfgfile.c | 70 +++++++++++++++++++++++++++++----------
>  lib/cfgfile/rte_cfgfile.h |  7 ++++
>  2 files changed, 59 insertions(+), 18 deletions(-)
> 


The existing cfgfile in DPDK is quite limited, and there are better
libraries available; not sure why a reinvention was necessary.
Stephen Hemminger July 5, 2024, 12:14 a.m. UTC | #3 
On Thu, 4 Jul 2024 17:12:56 +0200
David Marchand <david.marchand@redhat.com> wrote:

> On Tue, Feb 20, 2024 at 5:00 AM Chengwen Feng <fengchengwen@huawei.com> wrote:
> >
> > When I was trying to debug a problem introduced by config.ini in
> > test-dma-perf, I found the cfgfile library should enhance error
> > detecting, so got this patchset.
> >
> > Chengwen Feng (4):
> >   cfgfile: remove dead code
> >   cfgfile: support verify name and value
> >   cfgfile: verify add section and entry result
> >   cfgfile: add unique name flag
> >
> >  lib/cfgfile/rte_cfgfile.c | 70 +++++++++++++++++++++++++++++----------
> >  lib/cfgfile/rte_cfgfile.h |  7 ++++
> >  2 files changed, 59 insertions(+), 18 deletions(-)  
> 
> Please review.
> 
> 


Somewhat related, why is the cfgfile test disabled?
The line for test_cfgfile is commented out in app/test/meson.build
Stephen Hemminger July 5, 2024, 12:29 a.m. UTC | #4 
On Thu, 4 Jul 2024 17:14:33 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> On Thu, 4 Jul 2024 17:12:56 +0200
> David Marchand <david.marchand@redhat.com> wrote:
> 
> > On Tue, Feb 20, 2024 at 5:00 AM Chengwen Feng <fengchengwen@huawei.com> wrote:  
> > >
> > > When I was trying to debug a problem introduced by config.ini in
> > > test-dma-perf, I found the cfgfile library should enhance error
> > > detecting, so got this patchset.
> > >
> > > Chengwen Feng (4):
> > >   cfgfile: remove dead code
> > >   cfgfile: support verify name and value
> > >   cfgfile: verify add section and entry result
> > >   cfgfile: add unique name flag
> > >
> > >  lib/cfgfile/rte_cfgfile.c | 70 +++++++++++++++++++++++++++++----------
> > >  lib/cfgfile/rte_cfgfile.h |  7 ++++
> > >  2 files changed, 59 insertions(+), 18 deletions(-)    
> > 
> > Please review.
> > 
> >   
> 
> 
> Somewhat related, why is the cfgfile test disabled?
> The line for test_cfgfile is commented out in app/test/meson.build

The existing test won't build because of broken resource stuff which is
also not built. Probably best to yank the whole test and resource stuff
out until Christian fixes it.
Bruce Richardson July 5, 2024, 8:39 a.m. UTC | #5 
On Thu, Jul 04, 2024 at 02:40:55PM -0700, Stephen Hemminger wrote:
> On Tue, 20 Feb 2024 03:58:36 +0000
> Chengwen Feng <fengchengwen@huawei.com> wrote:
> 
> > When I was trying to debug a problem introduced by config.ini in
> > test-dma-perf, I found the cfgfile library should enhance error
> > detecting, so got this patchset.
> > 
> > Chengwen Feng (4):
> >   cfgfile: remove dead code
> >   cfgfile: support verify name and value
> >   cfgfile: verify add section and entry result
> >   cfgfile: add unique name flag
> > 
> >  lib/cfgfile/rte_cfgfile.c | 70 +++++++++++++++++++++++++++++----------
> >  lib/cfgfile/rte_cfgfile.h |  7 ++++
> >  2 files changed, 59 insertions(+), 18 deletions(-)
> > 
> 
> 
> The existing cfgfile in DPDK is quite limited, and there are better
> libraries available; not sure why a reinvention was necessary.
> 
At the time, it was done to avoid having additional external dependencies.
Since then, it's generally been relatively trouble free, so it's never been
felt worth the effort to replace, I suspect.

/Bruce