[v2,00/18] net/r8169: add r8169 pmd to dpdk

Message ID	20241017063200.26101-1-howard_wang@realsil.com.cn (mailing list archive)
Headers	code: ctloc85258 From: Howard Wang <howard_wang@realsil.com.cn> To: <dev@dpdk.org> CC: <pro_nic_dpdk@realtek.com>, Howard Wang <howard_wang@realsil.com.cn> Subject: [PATCH v2 00/18] net/r8169: add r8169 pmd to dpdk Date: Thu, 17 Oct 2024 14:31:42 +0800 Message-ID: <20241017063200.26101-1-howard_wang@realsil.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	net/r8169: add r8169 pmd to dpdk \| [v2,00/18] net/r8169: add r8169 pmd to dpdk [v2,01/18] net/r8169: add PMD driver skeleton [v2,02/18] net/r8169: add logging structure [v2,03/18] net/r8169: add hardware registers access routines [v2,04/18] net/r8169: implement core logic for Tx/Rx [v2,05/18] net/r8169: add support for hw config [v2,06/18] net/r8169: add phy registers access routines [v2,07/18] net/r8169: add support for hardware operations [v2,08/18] net/r8169: add support for phy configuration [v2,09/18] net/r8169: add support for hw initialization [v2,10/18] net/r8169: add link status and interrupt management [v2,11/18] net/r8169: implement Rx path [v2,12/18] net/r8169: implement Tx path [v2,13/18] net/r8169: implement device statistics [v2,14/18] net/r8169: implement promisc and allmulti modes [v2,15/18] net/r8169: impelment MTU configuration [v2,16/18] net/r8169: add support for getting fw version [v2,17/18] net/r8169: add driver_start and driver_stop [v2,18/18] doc/guides/nics: add documents for r8169 pmd

Message ID

20241017063200.26101-1-howard_wang@realsil.com.cn (mailing list archive)

Headers

From: Howard Wang <howard_wang@realsil.com.cn>
To: <dev@dpdk.org>
CC: <pro_nic_dpdk@realtek.com>, Howard Wang <howard_wang@realsil.com.cn>
Subject: [PATCH v2 00/18] net/r8169: add r8169 pmd to dpdk
Date: Thu, 17 Oct 2024 14:31:42 +0800
Message-ID: <20241017063200.26101-1-howard_wang@realsil.com.cn>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: list
Errors-To: dev-bounces@dpdk.org

Series

net/r8169: add r8169 pmd to dpdk |

Message

Howard Wang Oct. 17, 2024, 6:31 a.m. UTC

PATCH v2: modify some code as suggested by the maintainer.

Howard Wang (18):
  net/r8169: add PMD driver skeleton
  net/r8169: add logging structure
  net/r8169: add hardware registers access routines
  net/r8169: implement core logic for Tx/Rx
  net/r8169: add support for hw config
  net/r8169: add phy registers access routines
  net/r8169: add support for hardware operations
  net/r8169: add support for phy configuration
  net/r8169: add support for hw initialization
  net/r8169: add link status and interrupt management
  net/r8169: implement Rx path
  net/r8169: implement Tx path
  net/r8169: implement device statistics
  net/r8169: implement promisc and allmulti modes
  net/r8169: impelment MTU configuration
  net/r8169: add support for getting fw version
  net/r8169: add driver_start and driver_stop
  doc/guides/nics: add documents for r8169 pmd

 MAINTAINERS                            |    9 +
 doc/guides/nics/features/r8169.ini     |   32 +
 doc/guides/nics/index.rst              |    1 +
 doc/guides/nics/r8169.rst              |   17 +
 drivers/net/meson.build                |    1 +
 drivers/net/r8169/base/rtl8125a.c      |  413 ++++
 drivers/net/r8169/base/rtl8125a_mcu.c  | 1586 +++++++++++++
 drivers/net/r8169/base/rtl8125a_mcu.h  |   15 +
 drivers/net/r8169/base/rtl8125b.c      |  391 ++++
 drivers/net/r8169/base/rtl8125b_mcu.c  | 1068 +++++++++
 drivers/net/r8169/base/rtl8125b_mcu.h  |   15 +
 drivers/net/r8169/base/rtl8125bp.c     |  116 +
 drivers/net/r8169/base/rtl8125bp_mcu.c |  289 +++
 drivers/net/r8169/base/rtl8125bp_mcu.h |   14 +
 drivers/net/r8169/base/rtl8125d.c      |  245 ++
 drivers/net/r8169/base/rtl8125d_mcu.c  |  618 +++++
 drivers/net/r8169/base/rtl8125d_mcu.h  |   14 +
 drivers/net/r8169/base/rtl8126a.c      |  534 +++++
 drivers/net/r8169/base/rtl8126a_mcu.c  | 2994 ++++++++++++++++++++++++
 drivers/net/r8169/base/rtl8126a_mcu.h  |   17 +
 drivers/net/r8169/meson.build          |   21 +
 drivers/net/r8169/r8169_base.h         |  625 +++++
 drivers/net/r8169/r8169_dash.c         |  230 ++
 drivers/net/r8169/r8169_dash.h         |   58 +
 drivers/net/r8169/r8169_ethdev.c       |  812 +++++++
 drivers/net/r8169/r8169_ethdev.h       |  146 ++
 drivers/net/r8169/r8169_hw.c           | 1590 +++++++++++++
 drivers/net/r8169/r8169_hw.h           |  115 +
 drivers/net/r8169/r8169_logs.h         |   53 +
 drivers/net/r8169/r8169_phy.c          |  898 +++++++
 drivers/net/r8169/r8169_phy.h          |  148 ++
 drivers/net/r8169/r8169_rxtx.c         | 1481 ++++++++++++
 32 files changed, 14566 insertions(+)
 create mode 100644 doc/guides/nics/features/r8169.ini
 create mode 100644 doc/guides/nics/r8169.rst
 create mode 100644 drivers/net/r8169/base/rtl8125a.c
 create mode 100644 drivers/net/r8169/base/rtl8125a_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125a_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8125b.c
 create mode 100644 drivers/net/r8169/base/rtl8125b_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125b_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8125bp.c
 create mode 100644 drivers/net/r8169/base/rtl8125bp_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125bp_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8125d.c
 create mode 100644 drivers/net/r8169/base/rtl8125d_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125d_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8126a.c
 create mode 100644 drivers/net/r8169/base/rtl8126a_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8126a_mcu.h
 create mode 100644 drivers/net/r8169/meson.build
 create mode 100644 drivers/net/r8169/r8169_base.h
 create mode 100644 drivers/net/r8169/r8169_dash.c
 create mode 100644 drivers/net/r8169/r8169_dash.h
 create mode 100644 drivers/net/r8169/r8169_ethdev.c
 create mode 100644 drivers/net/r8169/r8169_ethdev.h
 create mode 100644 drivers/net/r8169/r8169_hw.c
 create mode 100644 drivers/net/r8169/r8169_hw.h
 create mode 100644 drivers/net/r8169/r8169_logs.h
 create mode 100644 drivers/net/r8169/r8169_phy.c
 create mode 100644 drivers/net/r8169/r8169_phy.h
 create mode 100644 drivers/net/r8169/r8169_rxtx.c

Comments

Stephen Hemminger Oct. 17, 2024, 4:41 p.m. UTC | #1

On Thu, 17 Oct 2024 14:31:42 +0800
Howard Wang <howard_wang@realsil.com.cn> wrote:

> PATCH v2: modify some code as suggested by the maintainer.
> 
> Howard Wang (18):
>   net/r8169: add PMD driver skeleton
>   net/r8169: add logging structure
>   net/r8169: add hardware registers access routines
>   net/r8169: implement core logic for Tx/Rx
>   net/r8169: add support for hw config
>   net/r8169: add phy registers access routines
>   net/r8169: add support for hardware operations
>   net/r8169: add support for phy configuration
>   net/r8169: add support for hw initialization
>   net/r8169: add link status and interrupt management
>   net/r8169: implement Rx path
>   net/r8169: implement Tx path
>   net/r8169: implement device statistics
>   net/r8169: implement promisc and allmulti modes
>   net/r8169: impelment MTU configuration
>   net/r8169: add support for getting fw version
>   net/r8169: add driver_start and driver_stop
>   doc/guides/nics: add documents for r8169 pmd
> 
>  MAINTAINERS                            |    9 +
>  doc/guides/nics/features/r8169.ini     |   32 +
>  doc/guides/nics/index.rst              |    1 +
>  doc/guides/nics/r8169.rst              |   17 +
>  drivers/net/meson.build                |    1 +
>  drivers/net/r8169/base/rtl8125a.c      |  413 ++++
>  drivers/net/r8169/base/rtl8125a_mcu.c  | 1586 +++++++++++++
>  drivers/net/r8169/base/rtl8125a_mcu.h  |   15 +
>  drivers/net/r8169/base/rtl8125b.c      |  391 ++++
>  drivers/net/r8169/base/rtl8125b_mcu.c  | 1068 +++++++++
>  drivers/net/r8169/base/rtl8125b_mcu.h  |   15 +
>  drivers/net/r8169/base/rtl8125bp.c     |  116 +
>  drivers/net/r8169/base/rtl8125bp_mcu.c |  289 +++
>  drivers/net/r8169/base/rtl8125bp_mcu.h |   14 +
>  drivers/net/r8169/base/rtl8125d.c      |  245 ++
>  drivers/net/r8169/base/rtl8125d_mcu.c  |  618 +++++
>  drivers/net/r8169/base/rtl8125d_mcu.h  |   14 +
>  drivers/net/r8169/base/rtl8126a.c      |  534 +++++
>  drivers/net/r8169/base/rtl8126a_mcu.c  | 2994 ++++++++++++++++++++++++
>  drivers/net/r8169/base/rtl8126a_mcu.h  |   17 +
>  drivers/net/r8169/meson.build          |   21 +
>  drivers/net/r8169/r8169_base.h         |  625 +++++
>  drivers/net/r8169/r8169_dash.c         |  230 ++
>  drivers/net/r8169/r8169_dash.h         |   58 +
>  drivers/net/r8169/r8169_ethdev.c       |  812 +++++++
>  drivers/net/r8169/r8169_ethdev.h       |  146 ++
>  drivers/net/r8169/r8169_hw.c           | 1590 +++++++++++++
>  drivers/net/r8169/r8169_hw.h           |  115 +
>  drivers/net/r8169/r8169_logs.h         |   53 +
>  drivers/net/r8169/r8169_phy.c          |  898 +++++++
>  drivers/net/r8169/r8169_phy.h          |  148 ++
>  drivers/net/r8169/r8169_rxtx.c         | 1481 ++++++++++++
>  32 files changed, 14566 insertions(+)
>  create mode 100644 doc/guides/nics/features/r8169.ini
>  create mode 100644 doc/guides/nics/r8169.rst
>  create mode 100644 drivers/net/r8169/base/rtl8125a.c
>  create mode 100644 drivers/net/r8169/base/rtl8125a_mcu.c
>  create mode 100644 drivers/net/r8169/base/rtl8125a_mcu.h
>  create mode 100644 drivers/net/r8169/base/rtl8125b.c
>  create mode 100644 drivers/net/r8169/base/rtl8125b_mcu.c
>  create mode 100644 drivers/net/r8169/base/rtl8125b_mcu.h
>  create mode 100644 drivers/net/r8169/base/rtl8125bp.c
>  create mode 100644 drivers/net/r8169/base/rtl8125bp_mcu.c
>  create mode 100644 drivers/net/r8169/base/rtl8125bp_mcu.h
>  create mode 100644 drivers/net/r8169/base/rtl8125d.c
>  create mode 100644 drivers/net/r8169/base/rtl8125d_mcu.c
>  create mode 100644 drivers/net/r8169/base/rtl8125d_mcu.h
>  create mode 100644 drivers/net/r8169/base/rtl8126a.c
>  create mode 100644 drivers/net/r8169/base/rtl8126a_mcu.c
>  create mode 100644 drivers/net/r8169/base/rtl8126a_mcu.h
>  create mode 100644 drivers/net/r8169/meson.build
>  create mode 100644 drivers/net/r8169/r8169_base.h
>  create mode 100644 drivers/net/r8169/r8169_dash.c
>  create mode 100644 drivers/net/r8169/r8169_dash.h
>  create mode 100644 drivers/net/r8169/r8169_ethdev.c
>  create mode 100644 drivers/net/r8169/r8169_ethdev.h
>  create mode 100644 drivers/net/r8169/r8169_hw.c
>  create mode 100644 drivers/net/r8169/r8169_hw.h
>  create mode 100644 drivers/net/r8169/r8169_logs.h
>  create mode 100644 drivers/net/r8169/r8169_phy.c
>  create mode 100644 drivers/net/r8169/r8169_phy.h
>  create mode 100644 drivers/net/r8169/r8169_rxtx.c
> 

Lots of whitespace errors when test applying this patch.

Applying: net/r8169: add PMD driver skeleton
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:56: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:78: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:263: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:310: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
Applying: net/r8169: add logging structure
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:54: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:113: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Applying: net/r8169: add hardware registers access routines
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:539: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:574: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Applying: net/r8169: implement core logic for Tx/Rx
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:142: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Applying: net/r8169: add support for hw config
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:938: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:1020: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:1047: new blank line at EOF.
+
warning: 3 lines add whitespace errors.
Applying: net/r8169: add phy registers access routines
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:245: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Applying: net/r8169: add support for hardware operations
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:460: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2052: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2073: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2470: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:3544: new blank line at EOF.
+
warning: squelched 12 whitespace errors
warning: 17 lines add whitespace errors.
Applying: net/r8169: add support for phy configuration
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:512: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Applying: net/r8169: add support for hw initialization
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:189: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:230: new blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:978: new blank line at EOF.
+
warning: 3 lines add whitespace errors.
Applying: net/r8169: add link status and interrupt management
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:600: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Applying: net/r8169: implement Rx path
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:1030: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Applying: net/r8169: implement Tx path
Applying: net/r8169: implement device statistics
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:225: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Applying: net/r8169: implement promisc and allmulti modes
Applying: net/r8169: impelment MTU configuration
Applying: net/r8169: add support for getting fw version
Applying: net/r8169: add driver_start and driver_stop
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:205: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Applying: doc/guides/nics: add documents for r8169 pmd