mbox series

[v5,00/42] DPAA2 specific patches

Message ID 20241023115955.1207617-1-vanshika.shukla@nxp.com (mailing list archive)
Headers
Series DPAA2 specific patches |

Message

Vanshika Shukla Oct. 23, 2024, 11:59 a.m. UTC
From: Vanshika Shukla <vanshika.shukla@nxp.com>

This series includes:
-> Fixes and enhancements for NXP DPAA2 drivers.
-> Upgrade with MC version 10.37
-> Enhancements in DPDMUX code
-> Fixes for coverity issues reported

V2 changes:
Fixed the broken compilation for clang in:
        "net/dpaa2: dpdmux single flow/multiple rules support" patch.
Fixed checkpatch warnings in the below patches:
        "net/dpaa2: protocol inside tunnel distribution"
        "net/dpaa2: add VXLAN distribution support"
        "bus/fslmc: dynamic IOVA mode configuration"
        "bus/fslmc: enhance MC VFIO multiprocess support"

V3 changes:
Rebased to the latest commit.

V4 changes:
Fixed the checkpatch warnings in:
        "bus/fslmc: get MC VFIO group FD directly"
        "bus/fslmc: dynamic IOVA mode configuration"
        "net/dpaa2: add GTP flow support"
        "net/dpaa2: add flow support for IPsec AH and ESP
        "bus/fslmc: enhance MC VFIO multiprocess support"
Resolved comments by the reviewer.

V5 changes:
Resolved comments by the reviewer in:
	"bus/fslmc: dynamic IOVA mode configuration"

Apeksha Gupta (2):
  net/dpaa2: add proper MTU debugging print
  net/dpaa2: store drop priority in mbuf

Brick Yang (1):
  net/dpaa2: update DPNI link status method

Gagandeep Singh (3):
  bus/fslmc: upgrade with MC version 10.37
  net/dpaa2: fix memory corruption in TM
  net/dpaa2: support software taildrop

Hemant Agrawal (2):
  net/dpaa2: add support to dump dpdmux counters
  bus/fslmc: change dpcon close as internal symbol

Jun Yang (23):
  net/dpaa2: enhance Tx scatter-gather mempool
  net/dpaa2: add new PMD API to check dpaa platform version
  bus/fslmc: improve BMAN buffer acquire
  bus/fslmc: get MC VFIO group FD directly
  bus/fslmc: enhance MC VFIO multiprocess support
  bus/fslmc: dynamic IOVA mode configuration
  bus/fslmc: remove VFIO IRQ mapping
  bus/fslmc: create dpaa2 device with it's object
  bus/fslmc: introduce VFIO DMA mapping API for fslmc
  net/dpaa2: flow API refactor
  net/dpaa2: dump Rx parser result
  net/dpaa2: enhancement of raw flow extract
  net/dpaa2: frame attribute flags parser
  net/dpaa2: add VXLAN distribution support
  net/dpaa2: protocol inside tunnel distribution
  net/dpaa2: eCPRI support by parser result
  net/dpaa2: add GTP flow support
  net/dpaa2: check if Soft parser is loaded
  net/dpaa2: soft parser flow verification
  net/dpaa2: add flow support for IPsec AH and ESP
  net/dpaa2: check IOVA before sending MC command
  net/dpaa2: add API to get endpoint name
  net/dpaa2: dpdmux single flow/multiple rules support

Rohit Raj (6):
  bus/fslmc: add close API to close DPAA2 device
  net/dpaa2: support link state for eth interfaces
  bus/fslmc: free VFIO group FD in case of add group failure
  bus/fslmc: fix coverity issue
  bus/fslmc: change qbman eq desc from d to desc
  net/dpaa2: change miss flow ID macro name

Sachin Saxena (1):
  net/dpaa2: improve DPDMUX error behavior settings

Vanshika Shukla (4):
  net/dpaa2: support PTP packet one-step timestamp
  net/dpaa2: dpdmux: add support for CVLAN
  net/dpaa2: support VLAN traffic splitting
  net/dpaa2: add support for C-VLAN and MAC

 doc/guides/platform/dpaa2.rst                 |    4 +-
 drivers/bus/fslmc/bus_fslmc_driver.h          |   72 +-
 drivers/bus/fslmc/fslmc_bus.c                 |   62 +-
 drivers/bus/fslmc/fslmc_vfio.c                | 1621 +++-
 drivers/bus/fslmc/fslmc_vfio.h                |   35 +-
 drivers/bus/fslmc/mc/dpio.c                   |   94 +-
 drivers/bus/fslmc/mc/fsl_dpcon.h              |    6 +-
 drivers/bus/fslmc/mc/fsl_dpio.h               |   21 +-
 drivers/bus/fslmc/mc/fsl_dpio_cmd.h           |   13 +-
 drivers/bus/fslmc/mc/fsl_dpmng.h              |    4 +-
 drivers/bus/fslmc/mc/fsl_dprc_cmd.h           |    8 +-
 drivers/bus/fslmc/meson.build                 |    3 +-
 drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c      |   38 +-
 drivers/bus/fslmc/portal/dpaa2_hw_dpci.c      |   38 +-
 drivers/bus/fslmc/portal/dpaa2_hw_dpio.c      |   50 +-
 drivers/bus/fslmc/portal/dpaa2_hw_dpio.h      |    3 +-
 drivers/bus/fslmc/portal/dpaa2_hw_dprc.c      |    8 +-
 drivers/bus/fslmc/portal/dpaa2_hw_pvt.h       |  114 +-
 .../bus/fslmc/qbman/include/fsl_qbman_debug.h |   12 +-
 drivers/bus/fslmc/qbman/qbman_debug.c         |   49 +-
 drivers/bus/fslmc/qbman/qbman_portal.c        |   30 +-
 drivers/bus/fslmc/version.map                 |   16 +-
 drivers/crypto/dpaa2_sec/mc/dpseci.c          |   91 +-
 drivers/crypto/dpaa2_sec/mc/fsl_dpseci.h      |   47 +-
 drivers/crypto/dpaa2_sec/mc/fsl_dpseci_cmd.h  |   19 +-
 drivers/dma/dpaa2/dpaa2_qdma.c                |    1 +
 drivers/event/dpaa2/dpaa2_hw_dpcon.c          |   38 +-
 drivers/mempool/dpaa2/dpaa2_hw_mempool.c      |    2 +-
 drivers/net/dpaa2/base/dpaa2_hw_dpni.c        |   63 +-
 drivers/net/dpaa2/dpaa2_ethdev.c              |  597 +-
 drivers/net/dpaa2/dpaa2_ethdev.h              |  225 +-
 drivers/net/dpaa2/dpaa2_flow.c                | 7066 ++++++++++-------
 drivers/net/dpaa2/dpaa2_mux.c                 |  541 +-
 drivers/net/dpaa2/dpaa2_parse_dump.h          |  250 +
 drivers/net/dpaa2/dpaa2_ptp.c                 |    8 +-
 drivers/net/dpaa2/dpaa2_rxtx.c                |   32 +-
 drivers/net/dpaa2/dpaa2_sparser.c             |   25 +-
 drivers/net/dpaa2/dpaa2_tm.c                  |   72 +-
 drivers/net/dpaa2/mc/dpdmux.c                 |  205 +-
 drivers/net/dpaa2/mc/dpkg.c                   |   12 +-
 drivers/net/dpaa2/mc/dpni.c                   |  383 +-
 drivers/net/dpaa2/mc/fsl_dpdmux.h             |   99 +-
 drivers/net/dpaa2/mc/fsl_dpdmux_cmd.h         |   83 +-
 drivers/net/dpaa2/mc/fsl_dpkg.h               |    7 +-
 drivers/net/dpaa2/mc/fsl_dpni.h               |  176 +-
 drivers/net/dpaa2/mc/fsl_dpni_cmd.h           |  125 +-
 drivers/net/dpaa2/rte_pmd_dpaa2.h             |   51 +-
 drivers/net/dpaa2/version.map                 |    6 +
 48 files changed, 8271 insertions(+), 4254 deletions(-)
 create mode 100644 drivers/net/dpaa2/dpaa2_parse_dump.h
  

Comments

Hemant Agrawal Nov. 7, 2024, 11:24 a.m. UTC | #1
> -----Original Message-----
> From: vanshika.shukla@nxp.com <vanshika.shukla@nxp.com>
> Sent: Wednesday, October 23, 2024 5:29 PM
> To: dev@dpdk.org
> Subject: [v5 00/42] DPAA2 specific patches
> 
> From: Vanshika Shukla <vanshika.shukla@nxp.com>
> 
> This series includes:
> -> Fixes and enhancements for NXP DPAA2 drivers.
> -> Upgrade with MC version 10.37
> -> Enhancements in DPDMUX code
> -> Fixes for coverity issues reported
> 
> V2 changes:
> Fixed the broken compilation for clang in:
>         "net/dpaa2: dpdmux single flow/multiple rules support" patch.
> Fixed checkpatch warnings in the below patches:
>         "net/dpaa2: protocol inside tunnel distribution"
>         "net/dpaa2: add VXLAN distribution support"
>         "bus/fslmc: dynamic IOVA mode configuration"
>         "bus/fslmc: enhance MC VFIO multiprocess support"
> 
> V3 changes:
> Rebased to the latest commit.
> 
> V4 changes:
> Fixed the checkpatch warnings in:
>         "bus/fslmc: get MC VFIO group FD directly"
>         "bus/fslmc: dynamic IOVA mode configuration"
>         "net/dpaa2: add GTP flow support"
>         "net/dpaa2: add flow support for IPsec AH and ESP
>         "bus/fslmc: enhance MC VFIO multiprocess support"
> Resolved comments by the reviewer.
> 
> V5 changes:
> Resolved comments by the reviewer in:
> 	"bus/fslmc: dynamic IOVA mode configuration"
> 
> Apeksha Gupta (2):
>   net/dpaa2: add proper MTU debugging print
>   net/dpaa2: store drop priority in mbuf
> 
> Brick Yang (1):
>   net/dpaa2: update DPNI link status method
> 
> Gagandeep Singh (3):
>   bus/fslmc: upgrade with MC version 10.37
>   net/dpaa2: fix memory corruption in TM
>   net/dpaa2: support software taildrop
> 
> Hemant Agrawal (2):
>   net/dpaa2: add support to dump dpdmux counters
>   bus/fslmc: change dpcon close as internal symbol
> 
> Jun Yang (23):
>   net/dpaa2: enhance Tx scatter-gather mempool
>   net/dpaa2: add new PMD API to check dpaa platform version
>   bus/fslmc: improve BMAN buffer acquire
>   bus/fslmc: get MC VFIO group FD directly
>   bus/fslmc: enhance MC VFIO multiprocess support
>   bus/fslmc: dynamic IOVA mode configuration
>   bus/fslmc: remove VFIO IRQ mapping
>   bus/fslmc: create dpaa2 device with it's object
>   bus/fslmc: introduce VFIO DMA mapping API for fslmc
>   net/dpaa2: flow API refactor
>   net/dpaa2: dump Rx parser result
>   net/dpaa2: enhancement of raw flow extract
>   net/dpaa2: frame attribute flags parser
>   net/dpaa2: add VXLAN distribution support
>   net/dpaa2: protocol inside tunnel distribution
>   net/dpaa2: eCPRI support by parser result
>   net/dpaa2: add GTP flow support
>   net/dpaa2: check if Soft parser is loaded
>   net/dpaa2: soft parser flow verification
>   net/dpaa2: add flow support for IPsec AH and ESP
>   net/dpaa2: check IOVA before sending MC command
>   net/dpaa2: add API to get endpoint name
>   net/dpaa2: dpdmux single flow/multiple rules support
> 
> Rohit Raj (6):
>   bus/fslmc: add close API to close DPAA2 device
>   net/dpaa2: support link state for eth interfaces
>   bus/fslmc: free VFIO group FD in case of add group failure
>   bus/fslmc: fix coverity issue
>   bus/fslmc: change qbman eq desc from d to desc
>   net/dpaa2: change miss flow ID macro name
> 
> Sachin Saxena (1):
>   net/dpaa2: improve DPDMUX error behavior settings
> 
> Vanshika Shukla (4):
>   net/dpaa2: support PTP packet one-step timestamp
>   net/dpaa2: dpdmux: add support for CVLAN
>   net/dpaa2: support VLAN traffic splitting
>   net/dpaa2: add support for C-VLAN and MAC
> 
>  doc/guides/platform/dpaa2.rst                 |    4 +-
>  drivers/bus/fslmc/bus_fslmc_driver.h          |   72 +-
>  drivers/bus/fslmc/fslmc_bus.c                 |   62 +-
>  drivers/bus/fslmc/fslmc_vfio.c                | 1621 +++-
>  drivers/bus/fslmc/fslmc_vfio.h                |   35 +-
>  drivers/bus/fslmc/mc/dpio.c                   |   94 +-
>  drivers/bus/fslmc/mc/fsl_dpcon.h              |    6 +-
>  drivers/bus/fslmc/mc/fsl_dpio.h               |   21 +-
>  drivers/bus/fslmc/mc/fsl_dpio_cmd.h           |   13 +-
>  drivers/bus/fslmc/mc/fsl_dpmng.h              |    4 +-
>  drivers/bus/fslmc/mc/fsl_dprc_cmd.h           |    8 +-
>  drivers/bus/fslmc/meson.build                 |    3 +-
>  drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c      |   38 +-
>  drivers/bus/fslmc/portal/dpaa2_hw_dpci.c      |   38 +-
>  drivers/bus/fslmc/portal/dpaa2_hw_dpio.c      |   50 +-
>  drivers/bus/fslmc/portal/dpaa2_hw_dpio.h      |    3 +-
>  drivers/bus/fslmc/portal/dpaa2_hw_dprc.c      |    8 +-
>  drivers/bus/fslmc/portal/dpaa2_hw_pvt.h       |  114 +-
>  .../bus/fslmc/qbman/include/fsl_qbman_debug.h |   12 +-
>  drivers/bus/fslmc/qbman/qbman_debug.c         |   49 +-
>  drivers/bus/fslmc/qbman/qbman_portal.c        |   30 +-
>  drivers/bus/fslmc/version.map                 |   16 +-
>  drivers/crypto/dpaa2_sec/mc/dpseci.c          |   91 +-
>  drivers/crypto/dpaa2_sec/mc/fsl_dpseci.h      |   47 +-
>  drivers/crypto/dpaa2_sec/mc/fsl_dpseci_cmd.h  |   19 +-
>  drivers/dma/dpaa2/dpaa2_qdma.c                |    1 +
>  drivers/event/dpaa2/dpaa2_hw_dpcon.c          |   38 +-
>  drivers/mempool/dpaa2/dpaa2_hw_mempool.c      |    2 +-
>  drivers/net/dpaa2/base/dpaa2_hw_dpni.c        |   63 +-
>  drivers/net/dpaa2/dpaa2_ethdev.c              |  597 +-
>  drivers/net/dpaa2/dpaa2_ethdev.h              |  225 +-
>  drivers/net/dpaa2/dpaa2_flow.c                | 7066 ++++++++++-------
>  drivers/net/dpaa2/dpaa2_mux.c                 |  541 +-
>  drivers/net/dpaa2/dpaa2_parse_dump.h          |  250 +
>  drivers/net/dpaa2/dpaa2_ptp.c                 |    8 +-
>  drivers/net/dpaa2/dpaa2_rxtx.c                |   32 +-
>  drivers/net/dpaa2/dpaa2_sparser.c             |   25 +-
>  drivers/net/dpaa2/dpaa2_tm.c                  |   72 +-
>  drivers/net/dpaa2/mc/dpdmux.c                 |  205 +-
>  drivers/net/dpaa2/mc/dpkg.c                   |   12 +-
>  drivers/net/dpaa2/mc/dpni.c                   |  383 +-
>  drivers/net/dpaa2/mc/fsl_dpdmux.h             |   99 +-
>  drivers/net/dpaa2/mc/fsl_dpdmux_cmd.h         |   83 +-
>  drivers/net/dpaa2/mc/fsl_dpkg.h               |    7 +-
>  drivers/net/dpaa2/mc/fsl_dpni.h               |  176 +-
>  drivers/net/dpaa2/mc/fsl_dpni_cmd.h           |  125 +-
>  drivers/net/dpaa2/rte_pmd_dpaa2.h             |   51 +-
>  drivers/net/dpaa2/version.map                 |    6 +
>  48 files changed, 8271 insertions(+), 4254 deletions(-)  create mode 100644
> drivers/net/dpaa2/dpaa2_parse_dump.h
> 
> --
> 2.25.1

Series-
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
  
Thomas Monjalon Nov. 10, 2024, 1:34 a.m. UTC | #2
23/10/2024 13:59, vanshika.shukla@nxp.com:
> Apeksha Gupta (2):
>   net/dpaa2: add proper MTU debugging print
>   net/dpaa2: store drop priority in mbuf
> 
> Brick Yang (1):
>   net/dpaa2: update DPNI link status method
> 
> Gagandeep Singh (3):
>   bus/fslmc: upgrade with MC version 10.37
>   net/dpaa2: fix memory corruption in TM
>   net/dpaa2: support software taildrop
> 
> Hemant Agrawal (2):
>   net/dpaa2: add support to dump dpdmux counters
>   bus/fslmc: change dpcon close as internal symbol
> 
> Jun Yang (23):
>   net/dpaa2: enhance Tx scatter-gather mempool
>   net/dpaa2: add new PMD API to check dpaa platform version
>   bus/fslmc: improve BMAN buffer acquire
>   bus/fslmc: get MC VFIO group FD directly
>   bus/fslmc: enhance MC VFIO multiprocess support
>   bus/fslmc: dynamic IOVA mode configuration
>   bus/fslmc: remove VFIO IRQ mapping
>   bus/fslmc: create dpaa2 device with it's object
>   bus/fslmc: introduce VFIO DMA mapping API for fslmc
>   net/dpaa2: flow API refactor
>   net/dpaa2: dump Rx parser result
>   net/dpaa2: enhancement of raw flow extract
>   net/dpaa2: frame attribute flags parser
>   net/dpaa2: add VXLAN distribution support
>   net/dpaa2: protocol inside tunnel distribution
>   net/dpaa2: eCPRI support by parser result
>   net/dpaa2: add GTP flow support
>   net/dpaa2: check if Soft parser is loaded
>   net/dpaa2: soft parser flow verification
>   net/dpaa2: add flow support for IPsec AH and ESP
>   net/dpaa2: check IOVA before sending MC command
>   net/dpaa2: add API to get endpoint name
>   net/dpaa2: dpdmux single flow/multiple rules support
> 
> Rohit Raj (6):
>   bus/fslmc: add close API to close DPAA2 device
>   net/dpaa2: support link state for eth interfaces
>   bus/fslmc: free VFIO group FD in case of add group failure
>   bus/fslmc: fix coverity issue
>   bus/fslmc: change qbman eq desc from d to desc
>   net/dpaa2: change miss flow ID macro name
> 
> Sachin Saxena (1):
>   net/dpaa2: improve DPDMUX error behavior settings
> 
> Vanshika Shukla (4):
>   net/dpaa2: support PTP packet one-step timestamp
>   net/dpaa2: dpdmux: add support for CVLAN
>   net/dpaa2: support VLAN traffic splitting
>   net/dpaa2: add support for C-VLAN and MAC

This series is not clean at all.
There are a lot of unrelated changes in the middle of patches
like reindent or cast cleanup.
Some commits are breaking compilation.
Some useless code is added and removed in the last commit.
The features matrix for the flow items and actions are not updated.
Some error messages are polluting the cleanup stage for everybody.
The patch for DPDMUX based on C-VLAN and MAC address is present twice.
Not even talking about conflicts because of a parallel series.

I'm not sure why I'm trying to merge these patches,
I suppose I'm trying to be kind.
I've fixed all blocking issues and applied.
  
Vanshika Shukla Nov. 11, 2024, 5:55 a.m. UTC | #3
Hi Thomas,

Thanks a lot for helping merge these patches. We apologize for the inconvenience caused to you resolving the issues.
We'll be more vigilant in future reviews to avoid similar disruptions.

Regards,
Vanshika

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Sunday, November 10, 2024 7:04 AM
> To: Vanshika Shukla <vanshika.shukla@nxp.com>; Gagandeep Singh
> <G.Singh@nxp.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Jun
> Yang <jun.yang@nxp.com>; Rohit Raj <rohit.raj@nxp.com>
> Cc: dev@dpdk.org; David Marchand <david.marchand@redhat.com>
> Subject: [EXT] Re: [v5 00/42] DPAA2 specific patches
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> 23/10/2024 13:59, vanshika.shukla@nxp.com:
> > Apeksha Gupta (2):
> >   net/dpaa2: add proper MTU debugging print
> >   net/dpaa2: store drop priority in mbuf
> >
> > Brick Yang (1):
> >   net/dpaa2: update DPNI link status method
> >
> > Gagandeep Singh (3):
> >   bus/fslmc: upgrade with MC version 10.37
> >   net/dpaa2: fix memory corruption in TM
> >   net/dpaa2: support software taildrop
> >
> > Hemant Agrawal (2):
> >   net/dpaa2: add support to dump dpdmux counters
> >   bus/fslmc: change dpcon close as internal symbol
> >
> > Jun Yang (23):
> >   net/dpaa2: enhance Tx scatter-gather mempool
> >   net/dpaa2: add new PMD API to check dpaa platform version
> >   bus/fslmc: improve BMAN buffer acquire
> >   bus/fslmc: get MC VFIO group FD directly
> >   bus/fslmc: enhance MC VFIO multiprocess support
> >   bus/fslmc: dynamic IOVA mode configuration
> >   bus/fslmc: remove VFIO IRQ mapping
> >   bus/fslmc: create dpaa2 device with it's object
> >   bus/fslmc: introduce VFIO DMA mapping API for fslmc
> >   net/dpaa2: flow API refactor
> >   net/dpaa2: dump Rx parser result
> >   net/dpaa2: enhancement of raw flow extract
> >   net/dpaa2: frame attribute flags parser
> >   net/dpaa2: add VXLAN distribution support
> >   net/dpaa2: protocol inside tunnel distribution
> >   net/dpaa2: eCPRI support by parser result
> >   net/dpaa2: add GTP flow support
> >   net/dpaa2: check if Soft parser is loaded
> >   net/dpaa2: soft parser flow verification
> >   net/dpaa2: add flow support for IPsec AH and ESP
> >   net/dpaa2: check IOVA before sending MC command
> >   net/dpaa2: add API to get endpoint name
> >   net/dpaa2: dpdmux single flow/multiple rules support
> >
> > Rohit Raj (6):
> >   bus/fslmc: add close API to close DPAA2 device
> >   net/dpaa2: support link state for eth interfaces
> >   bus/fslmc: free VFIO group FD in case of add group failure
> >   bus/fslmc: fix coverity issue
> >   bus/fslmc: change qbman eq desc from d to desc
> >   net/dpaa2: change miss flow ID macro name
> >
> > Sachin Saxena (1):
> >   net/dpaa2: improve DPDMUX error behavior settings
> >
> > Vanshika Shukla (4):
> >   net/dpaa2: support PTP packet one-step timestamp
> >   net/dpaa2: dpdmux: add support for CVLAN
> >   net/dpaa2: support VLAN traffic splitting
> >   net/dpaa2: add support for C-VLAN and MAC
> 
> This series is not clean at all.
> There are a lot of unrelated changes in the middle of patches like reindent or
> cast cleanup.
> Some commits are breaking compilation.
> Some useless code is added and removed in the last commit.
> The features matrix for the flow items and actions are not updated.
> Some error messages are polluting the cleanup stage for everybody.
> The patch for DPDMUX based on C-VLAN and MAC address is present twice.
> Not even talking about conflicts because of a parallel series.
> 
> I'm not sure why I'm trying to merge these patches, I suppose I'm trying to be
> kind.
> I've fixed all blocking issues and applied.
>