[v5,00/18] modify code as suggested by the maintainer

Message ID	20241028073112.107535-1-howard_wang@realsil.com.cn (mailing list archive)
Headers	code: ctloc85258 From: Howard Wang <howard_wang@realsil.com.cn> To: <dev@dpdk.org> CC: <pro_nic_dpdk@realtek.com>, Howard Wang <howard_wang@realsil.com.cn> Subject: [PATCH v5 00/18] modify code as suggested by the maintainer Date: Mon, 28 Oct 2024 15:30:54 +0800 Message-ID: <20241028073112.107535-1-howard_wang@realsil.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	modify code as suggested by the maintainer \| [v5,00/18] modify code as suggested by the maintainer [v5,01/18] net/r8169: add PMD driver skeleton [v5,02/18] net/r8169: add logging structure [v5,03/18] net/r8169: add hardware registers access routines [v5,04/18] net/r8169: implement core logic for Tx/Rx [v5,05/18] net/r8169: add support for hw config [v5,06/18] net/r8169: add phy registers access routines [v5,07/18] net/r8169: add support for hardware operations [v5,08/18] net/r8169: add support for phy configuration [v5,09/18] net/r8169: add support for hw initialization [v5,10/18] net/r8169: add link status and interrupt management [v5,11/18] net/r8169: implement Rx path [v5,12/18] net/r8169: implement Tx path [v5,13/18] net/r8169: implement device statistics [v5,14/18] net/r8169: implement promisc and allmulti modes [v5,15/18] net/r8169: implement MTU configuration [v5,16/18] net/r8169: add support for getting fw version [v5,17/18] net/r8169: add driver_start and driver_stop [v5,18/18] doc/guides/nics: add documents for r8169 pmd

Message ID

20241028073112.107535-1-howard_wang@realsil.com.cn (mailing list archive)

Headers

From: Howard Wang <howard_wang@realsil.com.cn>
To: <dev@dpdk.org>
CC: <pro_nic_dpdk@realtek.com>, Howard Wang <howard_wang@realsil.com.cn>
Subject: [PATCH v5 00/18] modify code as suggested by the maintainer
Date: Mon, 28 Oct 2024 15:30:54 +0800
Message-ID: <20241028073112.107535-1-howard_wang@realsil.com.cn>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: list
Errors-To: dev-bounces@dpdk.org

Series

modify code as suggested by the maintainer |

Message

Howard Wang Oct. 28, 2024, 7:30 a.m. UTC

Fix some warning issues.

Howard Wang (18):
  net/r8169: add PMD driver skeleton
  net/r8169: add logging structure
  net/r8169: add hardware registers access routines
  net/r8169: implement core logic for Tx/Rx
  net/r8169: add support for hw config
  net/r8169: add phy registers access routines
  net/r8169: add support for hardware operations
  net/r8169: add support for phy configuration
  net/r8169: add support for hw initialization
  net/r8169: add link status and interrupt management
  net/r8169: implement Rx path
  net/r8169: implement Tx path
  net/r8169: implement device statistics
  net/r8169: implement promisc and allmulti modes
  net/r8169: implement MTU configuration
  net/r8169: add support for getting fw version
  net/r8169: add driver_start and driver_stop
  doc/guides/nics: add documents for r8169 pmd

 MAINTAINERS                            |    9 +
 doc/guides/nics/features/r8169.ini     |   32 +
 doc/guides/nics/index.rst              |    1 +
 doc/guides/nics/r8169.rst              |   17 +
 drivers/net/meson.build                |    1 +
 drivers/net/r8169/base/rtl8125a.c      |  412 ++++
 drivers/net/r8169/base/rtl8125a_mcu.c  | 1585 +++++++++++++
 drivers/net/r8169/base/rtl8125a_mcu.h  |   14 +
 drivers/net/r8169/base/rtl8125b.c      |  390 +++
 drivers/net/r8169/base/rtl8125b_mcu.c  | 1067 +++++++++
 drivers/net/r8169/base/rtl8125b_mcu.h  |   14 +
 drivers/net/r8169/base/rtl8125bp.c     |  115 +
 drivers/net/r8169/base/rtl8125bp_mcu.c |  288 +++
 drivers/net/r8169/base/rtl8125bp_mcu.h |   13 +
 drivers/net/r8169/base/rtl8125d.c      |  244 ++
 drivers/net/r8169/base/rtl8125d_mcu.c  |  617 +++++
 drivers/net/r8169/base/rtl8125d_mcu.h  |   13 +
 drivers/net/r8169/base/rtl8126a.c      |  533 +++++
 drivers/net/r8169/base/rtl8126a_mcu.c  | 2993 ++++++++++++++++++++++++
 drivers/net/r8169/base/rtl8126a_mcu.h  |   16 +
 drivers/net/r8169/meson.build          |   20 +
 drivers/net/r8169/r8169_base.h         |  615 +++++
 drivers/net/r8169/r8169_dash.c         |  229 ++
 drivers/net/r8169/r8169_dash.h         |   57 +
 drivers/net/r8169/r8169_ethdev.c       |  779 ++++++
 drivers/net/r8169/r8169_ethdev.h       |  145 ++
 drivers/net/r8169/r8169_hw.c           | 1589 +++++++++++++
 drivers/net/r8169/r8169_hw.h           |  114 +
 drivers/net/r8169/r8169_logs.h         |   46 +
 drivers/net/r8169/r8169_phy.c          |  901 +++++++
 drivers/net/r8169/r8169_phy.h          |  147 ++
 drivers/net/r8169/r8169_rxtx.c         | 1484 ++++++++++++
 32 files changed, 14500 insertions(+)
 create mode 100644 doc/guides/nics/features/r8169.ini
 create mode 100644 doc/guides/nics/r8169.rst
 create mode 100644 drivers/net/r8169/base/rtl8125a.c
 create mode 100644 drivers/net/r8169/base/rtl8125a_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125a_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8125b.c
 create mode 100644 drivers/net/r8169/base/rtl8125b_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125b_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8125bp.c
 create mode 100644 drivers/net/r8169/base/rtl8125bp_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125bp_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8125d.c
 create mode 100644 drivers/net/r8169/base/rtl8125d_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125d_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8126a.c
 create mode 100644 drivers/net/r8169/base/rtl8126a_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8126a_mcu.h
 create mode 100644 drivers/net/r8169/meson.build
 create mode 100644 drivers/net/r8169/r8169_base.h
 create mode 100644 drivers/net/r8169/r8169_dash.c
 create mode 100644 drivers/net/r8169/r8169_dash.h
 create mode 100644 drivers/net/r8169/r8169_ethdev.c
 create mode 100644 drivers/net/r8169/r8169_ethdev.h
 create mode 100644 drivers/net/r8169/r8169_hw.c
 create mode 100644 drivers/net/r8169/r8169_hw.h
 create mode 100644 drivers/net/r8169/r8169_logs.h
 create mode 100644 drivers/net/r8169/r8169_phy.c
 create mode 100644 drivers/net/r8169/r8169_phy.h
 create mode 100644 drivers/net/r8169/r8169_rxtx.c

Comments

Ferruh Yigit Nov. 3, 2024, 2:23 a.m. UTC | #1

On 10/28/2024 7:30 AM, Howard Wang wrote:
> Fix some warning issues.
> 
> Howard Wang (18):
>   net/r8169: add PMD driver skeleton
>   net/r8169: add logging structure
>   net/r8169: add hardware registers access routines
>   net/r8169: implement core logic for Tx/Rx
>   net/r8169: add support for hw config
>   net/r8169: add phy registers access routines
>   net/r8169: add support for hardware operations
>   net/r8169: add support for phy configuration
>   net/r8169: add support for hw initialization
>   net/r8169: add link status and interrupt management
>   net/r8169: implement Rx path
>   net/r8169: implement Tx path
>   net/r8169: implement device statistics
>   net/r8169: implement promisc and allmulti modes
>   net/r8169: implement MTU configuration
>   net/r8169: add support for getting fw version
>   net/r8169: add driver_start and driver_stop
>   doc/guides/nics: add documents for r8169 pmd
>

Hi Howard,

Thanks for restructuring the patch series, it looks better now, I put
some comments.

Btw, there are many "Avoid CamelCase" checkpatch warning, if this code
is not shared (but developed for DPDK), can you please address the warnings?

Howard Wang Nov. 4, 2024, 2:05 a.m. UTC | #2

Dear Ferruh,

Thank you for your comments. I will make the changes you suggested. Our DPDK PMD is developed based on our company’s Linux kernel drivers r8125 and r8126, which are more comprehensive and detailed. To facilitate synchronized maintenance, I have retained the CamelCase.

Best Regards,
Howard Wang

-----邮件原件-----
发件人: Ferruh Yigit <ferruh.yigit@amd.com> 
发送时间: 2024年11月3日 10:24
收件人: 王颢 <howard_wang@realsil.com.cn>; dev@dpdk.org
抄送: pro_nic_dpdk@realtek.com
主题: Re: [PATCH v5 00/18] modify code as suggested by the maintainer

External mail.

On 10/28/2024 7:30 AM, Howard Wang wrote:
> Fix some warning issues.
>
> Howard Wang (18):
>   net/r8169: add PMD driver skeleton
>   net/r8169: add logging structure
>   net/r8169: add hardware registers access routines
>   net/r8169: implement core logic for Tx/Rx
>   net/r8169: add support for hw config
>   net/r8169: add phy registers access routines
>   net/r8169: add support for hardware operations
>   net/r8169: add support for phy configuration
>   net/r8169: add support for hw initialization
>   net/r8169: add link status and interrupt management
>   net/r8169: implement Rx path
>   net/r8169: implement Tx path
>   net/r8169: implement device statistics
>   net/r8169: implement promisc and allmulti modes
>   net/r8169: implement MTU configuration
>   net/r8169: add support for getting fw version
>   net/r8169: add driver_start and driver_stop
>   doc/guides/nics: add documents for r8169 pmd
>

Hi Howard,

Thanks for restructuring the patch series, it looks better now, I put some comments.

Btw, there are many "Avoid CamelCase" checkpatch warning, if this code is not shared (but developed for DPDK), can you please address the warnings?

Ferruh Yigit Nov. 4, 2024, 8:50 a.m. UTC | #3

On 11/4/2024 2:05 AM, 王颢 wrote:
> Dear Ferruh,
> 
> Thank you for your comments. I will make the changes you suggested. Our DPDK PMD is developed based on our company’s Linux kernel drivers r8125 and r8126, which are more comprehensive and detailed. To facilitate synchronized maintenance, I have retained the CamelCase.
> 

OK to keep the CamelCase syntax since code is shared.

> Best Regards,
> Howard Wang
> 
> -----邮件原件-----
> 发件人: Ferruh Yigit <ferruh.yigit@amd.com> 
> 发送时间: 2024年11月3日 10:24
> 收件人: 王颢 <howard_wang@realsil.com.cn>; dev@dpdk.org
> 抄送: pro_nic_dpdk@realtek.com
> 主题: Re: [PATCH v5 00/18] modify code as suggested by the maintainer
> 
> 
> External mail.
> 
> 
> 
> On 10/28/2024 7:30 AM, Howard Wang wrote:
>> Fix some warning issues.
>>
>> Howard Wang (18):
>>   net/r8169: add PMD driver skeleton
>>   net/r8169: add logging structure
>>   net/r8169: add hardware registers access routines
>>   net/r8169: implement core logic for Tx/Rx
>>   net/r8169: add support for hw config
>>   net/r8169: add phy registers access routines
>>   net/r8169: add support for hardware operations
>>   net/r8169: add support for phy configuration
>>   net/r8169: add support for hw initialization
>>   net/r8169: add link status and interrupt management
>>   net/r8169: implement Rx path
>>   net/r8169: implement Tx path
>>   net/r8169: implement device statistics
>>   net/r8169: implement promisc and allmulti modes
>>   net/r8169: implement MTU configuration
>>   net/r8169: add support for getting fw version
>>   net/r8169: add driver_start and driver_stop
>>   doc/guides/nics: add documents for r8169 pmd
>>
> 
> Hi Howard,
> 
> Thanks for restructuring the patch series, it looks better now, I put some comments.
> 
> Btw, there are many "Avoid CamelCase" checkpatch warning, if this code is not shared (but developed for DPDK), can you please address the warnings?