[v6,00/17] Modify code as suggested by the maintainer.

Message ID	20241108121123.248797-1-howard_wang@realsil.com.cn (mailing list archive)
Headers	code: ctloc85258 From: Howard Wang <howard_wang@realsil.com.cn> To: <dev@dpdk.org> CC: <pro_nic_dpdk@realtek.com>, Howard Wang <howard_wang@realsil.com.cn> Subject: [PATCH v6 00/17] Modify code as suggested by the maintainer. Date: Fri, 8 Nov 2024 20:11:06 +0800 Message-ID: <20241108121123.248797-1-howard_wang@realsil.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	Modify code as suggested by the maintainer. \| [v6,00/17] Modify code as suggested by the maintainer. [v6,01/17] net/r8169: add PMD driver skeleton [v6,02/17] net/r8169: add logging structure [v6,03/17] net/r8169: add hardware registers access routines [v6,04/17] net/r8169: implement core logic for Tx/Rx [v6,05/17] net/r8169: add support for hw config [v6,06/17] net/r8169: add phy registers access routines [v6,07/17] net/r8169: add support for hardware operations [v6,08/17] net/r8169: add support for phy configuration [v6,09/17] net/r8169: add support for hw initialization [v6,10/17] net/r8169: add link status and interrupt management [v6,11/17] net/r8169: implement Rx path [v6,12/17] net/r8169: implement Tx path [v6,13/17] net/r8169: implement device statistics [v6,14/17] net/r8169: implement promisc and allmulti modes [v6,15/17] net/r8169: implement MTU configuration [v6,16/17] net/r8169: add support for getting fw version [v6,17/17] net/r8169: add driver_start and driver_stop

Message ID

20241108121123.248797-1-howard_wang@realsil.com.cn (mailing list archive)

Headers

From: Howard Wang <howard_wang@realsil.com.cn>
To: <dev@dpdk.org>
CC: <pro_nic_dpdk@realtek.com>, Howard Wang <howard_wang@realsil.com.cn>
Subject: [PATCH v6 00/17] Modify code as suggested by the maintainer.
Date: Fri, 8 Nov 2024 20:11:06 +0800
Message-ID: <20241108121123.248797-1-howard_wang@realsil.com.cn>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: list
Errors-To: dev-bounces@dpdk.org

Series

Modify code as suggested by the maintainer. |

Message

Howard Wang Nov. 8, 2024, 12:11 p.m. UTC

Remove some headers and code that are not used.
Improve r8169.ini and r8169.rst gradually.

Howard Wang (17):
  net/r8169: add PMD driver skeleton
  net/r8169: add logging structure
  net/r8169: add hardware registers access routines
  net/r8169: implement core logic for Tx/Rx
  net/r8169: add support for hw config
  net/r8169: add phy registers access routines
  net/r8169: add support for hardware operations
  net/r8169: add support for phy configuration
  net/r8169: add support for hw initialization
  net/r8169: add link status and interrupt management
  net/r8169: implement Rx path
  net/r8169: implement Tx path
  net/r8169: implement device statistics
  net/r8169: implement promisc and allmulti modes
  net/r8169: implement MTU configuration
  net/r8169: add support for getting fw version
  net/r8169: add driver_start and driver_stop

 MAINTAINERS                            |    8 +
 doc/guides/nics/features/r8169.ini     |   32 +
 doc/guides/nics/index.rst              |    1 +
 doc/guides/nics/r8169.rst              |   28 +
 doc/guides/rel_notes/release_24_11.rst |    5 +
 drivers/net/meson.build                |    1 +
 drivers/net/r8169/base/rtl8125a.c      |  412 ++++
 drivers/net/r8169/base/rtl8125a_mcu.c  | 1585 +++++++++++++
 drivers/net/r8169/base/rtl8125a_mcu.h  |   14 +
 drivers/net/r8169/base/rtl8125b.c      |  390 +++
 drivers/net/r8169/base/rtl8125b_mcu.c  | 1067 +++++++++
 drivers/net/r8169/base/rtl8125b_mcu.h  |   14 +
 drivers/net/r8169/base/rtl8125bp.c     |  115 +
 drivers/net/r8169/base/rtl8125bp_mcu.c |  288 +++
 drivers/net/r8169/base/rtl8125bp_mcu.h |   13 +
 drivers/net/r8169/base/rtl8125d.c      |  244 ++
 drivers/net/r8169/base/rtl8125d_mcu.c  |  617 +++++
 drivers/net/r8169/base/rtl8125d_mcu.h  |   13 +
 drivers/net/r8169/base/rtl8126a.c      |  533 +++++
 drivers/net/r8169/base/rtl8126a_mcu.c  | 2993 ++++++++++++++++++++++++
 drivers/net/r8169/base/rtl8126a_mcu.h  |   16 +
 drivers/net/r8169/meson.build          |   20 +
 drivers/net/r8169/r8169_compat.h       |  609 +++++
 drivers/net/r8169/r8169_dash.c         |  227 ++
 drivers/net/r8169/r8169_dash.h         |   57 +
 drivers/net/r8169/r8169_ethdev.c       |  764 ++++++
 drivers/net/r8169/r8169_ethdev.h       |  143 ++
 drivers/net/r8169/r8169_hw.c           | 1587 +++++++++++++
 drivers/net/r8169/r8169_hw.h           |  114 +
 drivers/net/r8169/r8169_logs.h         |   46 +
 drivers/net/r8169/r8169_phy.c          |  899 +++++++
 drivers/net/r8169/r8169_phy.h          |  147 ++
 drivers/net/r8169/r8169_rxtx.c         | 1479 ++++++++++++
 33 files changed, 14481 insertions(+)
 create mode 100644 doc/guides/nics/features/r8169.ini
 create mode 100644 doc/guides/nics/r8169.rst
 create mode 100644 drivers/net/r8169/base/rtl8125a.c
 create mode 100644 drivers/net/r8169/base/rtl8125a_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125a_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8125b.c
 create mode 100644 drivers/net/r8169/base/rtl8125b_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125b_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8125bp.c
 create mode 100644 drivers/net/r8169/base/rtl8125bp_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125bp_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8125d.c
 create mode 100644 drivers/net/r8169/base/rtl8125d_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125d_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8126a.c
 create mode 100644 drivers/net/r8169/base/rtl8126a_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8126a_mcu.h
 create mode 100644 drivers/net/r8169/meson.build
 create mode 100644 drivers/net/r8169/r8169_compat.h
 create mode 100644 drivers/net/r8169/r8169_dash.c
 create mode 100644 drivers/net/r8169/r8169_dash.h
 create mode 100644 drivers/net/r8169/r8169_ethdev.c
 create mode 100644 drivers/net/r8169/r8169_ethdev.h
 create mode 100644 drivers/net/r8169/r8169_hw.c
 create mode 100644 drivers/net/r8169/r8169_hw.h
 create mode 100644 drivers/net/r8169/r8169_logs.h
 create mode 100644 drivers/net/r8169/r8169_phy.c
 create mode 100644 drivers/net/r8169/r8169_phy.h
 create mode 100644 drivers/net/r8169/r8169_rxtx.c

Comments

Ferruh Yigit Nov. 11, 2024, 12:26 a.m. UTC | #1

On 11/8/2024 12:11 PM, Howard Wang wrote:
> Remove some headers and code that are not used.
> Improve r8169.ini and r8169.rst gradually.
> 
> Howard Wang (17):
>   net/r8169: add PMD driver skeleton
>   net/r8169: add logging structure
>   net/r8169: add hardware registers access routines
>   net/r8169: implement core logic for Tx/Rx
>   net/r8169: add support for hw config
>   net/r8169: add phy registers access routines
>   net/r8169: add support for hardware operations
>   net/r8169: add support for phy configuration
>   net/r8169: add support for hw initialization
>   net/r8169: add link status and interrupt management
>   net/r8169: implement Rx path
>   net/r8169: implement Tx path
>   net/r8169: implement device statistics
>   net/r8169: implement promisc and allmulti modes
>   net/r8169: implement MTU configuration
>   net/r8169: add support for getting fw version
>   net/r8169: add driver_start and driver_stop
>

Hi Howard,

Thanks for the updates.

Series should build after each patch, but it seems broken in the set,
starting from patch 4/17 there are some warnings, and they are fixed
after a few patches. But can you please sure it builds fine after each
patch?

Above build issue is the main blocker for the set, but there are a few
minor issues listed below:

1. please fix issue highlighted by check-git-log.sh
`./devtools/check-git-log.sh -n17`

2. Please fix meson syntax warnings
`./devtools/check-meson.py`

Also I put some comments to individual patches.