mbox series

[v7,00/17] modify code as suggested by the maintainer

Message ID 20241112095804.42091-1-howard_wang@realsil.com.cn (mailing list archive)
Headers
Series modify code as suggested by the maintainer |

Message

Howard Wang Nov. 12, 2024, 9:57 a.m. UTC
./devtools/check-xxxx and some small issues

Howard Wang (17):
  net/r8169: add PMD driver skeleton
  net/r8169: add logging structure
  net/r8169: add hardware registers access routines
  net/r8169: implement core logic for Tx/Rx
  net/r8169: add support for HW config
  net/r8169: add PHY registers access routines
  net/r8169: add support for hardware operations
  net/r8169: add support for PHY configuration
  net/r8169: add support for HW initialization
  net/r8169: add link status and interrupt management
  net/r8169: implement Rx path
  net/r8169: implement Tx path
  net/r8169: implement device statistics
  net/r8169: implement promisc and allmulti modes
  net/r8169: implement MTU configuration
  net/r8169: add support for getting FW version
  net/r8169: add driver start and driver stop

 MAINTAINERS                            |    8 +
 doc/guides/nics/features/r8169.ini     |   27 +
 doc/guides/nics/index.rst              |    1 +
 doc/guides/nics/r8169.rst              |   27 +
 doc/guides/rel_notes/release_24_11.rst |    5 +
 drivers/net/meson.build                |    1 +
 drivers/net/r8169/base/rtl8125a.c      |  412 ++++
 drivers/net/r8169/base/rtl8125a_mcu.c  | 1585 +++++++++++++
 drivers/net/r8169/base/rtl8125a_mcu.h  |   14 +
 drivers/net/r8169/base/rtl8125b.c      |  390 +++
 drivers/net/r8169/base/rtl8125b_mcu.c  | 1067 +++++++++
 drivers/net/r8169/base/rtl8125b_mcu.h  |   14 +
 drivers/net/r8169/base/rtl8125bp.c     |  115 +
 drivers/net/r8169/base/rtl8125bp_mcu.c |  288 +++
 drivers/net/r8169/base/rtl8125bp_mcu.h |   13 +
 drivers/net/r8169/base/rtl8125d.c      |  244 ++
 drivers/net/r8169/base/rtl8125d_mcu.c  |  617 +++++
 drivers/net/r8169/base/rtl8125d_mcu.h  |   13 +
 drivers/net/r8169/base/rtl8126a.c      |  533 +++++
 drivers/net/r8169/base/rtl8126a_mcu.c  | 2993 ++++++++++++++++++++++++
 drivers/net/r8169/base/rtl8126a_mcu.h  |   16 +
 drivers/net/r8169/meson.build          |   20 +
 drivers/net/r8169/r8169_compat.h       |  609 +++++
 drivers/net/r8169/r8169_dash.c         |  227 ++
 drivers/net/r8169/r8169_dash.h         |   57 +
 drivers/net/r8169/r8169_ethdev.c       |  764 ++++++
 drivers/net/r8169/r8169_ethdev.h       |  143 ++
 drivers/net/r8169/r8169_hw.c           | 1587 +++++++++++++
 drivers/net/r8169/r8169_hw.h           |  114 +
 drivers/net/r8169/r8169_logs.h         |   46 +
 drivers/net/r8169/r8169_phy.c          |  899 +++++++
 drivers/net/r8169/r8169_phy.h          |  147 ++
 drivers/net/r8169/r8169_rxtx.c         | 1479 ++++++++++++
 33 files changed, 14475 insertions(+)
 create mode 100644 doc/guides/nics/features/r8169.ini
 create mode 100644 doc/guides/nics/r8169.rst
 create mode 100644 drivers/net/r8169/base/rtl8125a.c
 create mode 100644 drivers/net/r8169/base/rtl8125a_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125a_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8125b.c
 create mode 100644 drivers/net/r8169/base/rtl8125b_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125b_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8125bp.c
 create mode 100644 drivers/net/r8169/base/rtl8125bp_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125bp_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8125d.c
 create mode 100644 drivers/net/r8169/base/rtl8125d_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8125d_mcu.h
 create mode 100644 drivers/net/r8169/base/rtl8126a.c
 create mode 100644 drivers/net/r8169/base/rtl8126a_mcu.c
 create mode 100644 drivers/net/r8169/base/rtl8126a_mcu.h
 create mode 100644 drivers/net/r8169/meson.build
 create mode 100644 drivers/net/r8169/r8169_compat.h
 create mode 100644 drivers/net/r8169/r8169_dash.c
 create mode 100644 drivers/net/r8169/r8169_dash.h
 create mode 100644 drivers/net/r8169/r8169_ethdev.c
 create mode 100644 drivers/net/r8169/r8169_ethdev.h
 create mode 100644 drivers/net/r8169/r8169_hw.c
 create mode 100644 drivers/net/r8169/r8169_hw.h
 create mode 100644 drivers/net/r8169/r8169_logs.h
 create mode 100644 drivers/net/r8169/r8169_phy.c
 create mode 100644 drivers/net/r8169/r8169_phy.h
 create mode 100644 drivers/net/r8169/r8169_rxtx.c
  

Comments

Ferruh Yigit Nov. 13, 2024, 12:22 a.m. UTC | #1
On 11/12/2024 9:57 AM, Howard Wang wrote:
> ./devtools/check-xxxx and some small issues
> 
> Howard Wang (17):
>   net/r8169: add PMD driver skeleton
>   net/r8169: add logging structure
>   net/r8169: add hardware registers access routines
>   net/r8169: implement core logic for Tx/Rx
>   net/r8169: add support for HW config
>   net/r8169: add PHY registers access routines
>   net/r8169: add support for hardware operations
>   net/r8169: add support for PHY configuration
>   net/r8169: add support for HW initialization
>   net/r8169: add link status and interrupt management
>   net/r8169: implement Rx path
>   net/r8169: implement Tx path
>   net/r8169: implement device statistics
>   net/r8169: implement promisc and allmulti modes
>   net/r8169: implement MTU configuration
>   net/r8169: add support for getting FW version
>   net/r8169: add driver start and driver stop
>

Hi Howard,

Series is mostly OK, I put some comments on checkpatch warnings or
documentation issues, can you please check them.