mbox series

[v1,00/24] Fixes for igc and e1000

Message ID cover.1738858026.git.anatoly.burakov@intel.com (mailing list archive)
Headers
Series Fixes for igc and e1000 |

Message

Burakov, Anatoly Feb. 6, 2025, 4:08 p.m. UTC 
This patchset is taken out of recent e1000/igc driver update [1].

[1] https://inbox.dpdk.org/dev/cover.1738681725.git.anatoly.burakov@intel.com/

Aleksandr Loktionov (2):
  net/igc/base: fix MAC addr hash bit shift
  net/e1000/base: fix MAC addr hash bit shift

Amir Avivi (2):
  net/igc/base: fix iterator type
  net/e1000/base: fix iterator type

Anatoly Burakov (1):
  net/e1000/base: correct mPHY access logic

Barbara Skobiej (3):
  net/igc/base: fix data type in MAC hash
  net/e1000/base: fix data type in MAC hash
  net/e1000/base: fix reset for 82580

Carolyn Wyborny (1):
  net/e1000/base: skip MANC check for 82575

Dima Ruinskiy (5):
  net/igc/base: fix deadlock in i225
  net/igc/base: fix infinite loop
  net/igc/base: fix typo in LTR calculation
  net/igc/base: fix unused value
  net/e1000/base: fix unchecked return

Jakub Buchocki (1):
  net/e1000/base: fix uninitialized variable usage

Pawel Malinowski (2):
  net/igc/base: fix semaphore timeout value
  net/e1000/base: fix semaphore timeout value

Przemyslaw Ciesielski (4):
  net/igc/base: fix bitwise op type mismatch
  net/igc/base: fix static analysis warning
  net/e1000/base: fix static analysis warning
  net/e1000/base: fix static analysis warning

Sasha Neftin (3):
  net/igc/base: increase PHY power up delay
  net/igc/base: reset loop variable
  net/igc/base: fix LTR for i225

 .mailmap                                      |  3 +++
 .../net/intel/e1000/base/e1000_80003es2lan.c  |  2 +-
 drivers/net/intel/e1000/base/e1000_82575.c    |  5 ++--
 drivers/net/intel/e1000/base/e1000_base.c     |  3 ++-
 drivers/net/intel/e1000/base/e1000_defines.h  |  1 +
 drivers/net/intel/e1000/base/e1000_ich8lan.c  |  2 ++
 drivers/net/intel/e1000/base/e1000_mac.c      | 12 +++++----
 drivers/net/intel/e1000/base/e1000_nvm.c      |  4 +--
 drivers/net/intel/e1000/base/e1000_phy.c      | 25 +++++++++----------
 drivers/net/intel/e1000/base/e1000_vf.c       | 12 +++++----
 drivers/net/intel/igc/base/igc_defines.h      |  1 +
 drivers/net/intel/igc/base/igc_i225.c         | 24 ++++++++++++------
 drivers/net/intel/igc/base/igc_mac.c          | 10 +++++---
 drivers/net/intel/igc/base/igc_nvm.c          |  4 +--
 drivers/net/intel/igc/base/igc_phy.c          |  8 +++---
 15 files changed, 68 insertions(+), 48 deletions(-)

Comments

Bruce Richardson Feb. 6, 2025, 6:03 p.m. UTC | #1 
On Thu, Feb 06, 2025 at 04:08:23PM +0000, Anatoly Burakov wrote:
> This patchset is taken out of recent e1000/igc driver update [1].
> 
> [1] https://inbox.dpdk.org/dev/cover.1738681725.git.anatoly.burakov@intel.com/
>

Thanks Anatoly. All the patches for e1000 and igc will be easier to work on
in two sets rather than one huge one, and it should make it easier to
backport all these fixes too.

/Bruce
Bruce Richardson Feb. 7, 2025, 11:16 a.m. UTC | #2 
On Thu, Feb 06, 2025 at 04:08:23PM +0000, Anatoly Burakov wrote:
> This patchset is taken out of recent e1000/igc driver update [1].
> 
> [1] https://inbox.dpdk.org/dev/cover.1738681725.git.anatoly.burakov@intel.com/
> 
> Aleksandr Loktionov (2):
>   net/igc/base: fix MAC addr hash bit shift
>   net/e1000/base: fix MAC addr hash bit shift
> 
> Amir Avivi (2):
>   net/igc/base: fix iterator type
>   net/e1000/base: fix iterator type
> 
> Anatoly Burakov (1):
>   net/e1000/base: correct mPHY access logic
> 
> Barbara Skobiej (3):
>   net/igc/base: fix data type in MAC hash
>   net/e1000/base: fix data type in MAC hash
>   net/e1000/base: fix reset for 82580
> 
> Carolyn Wyborny (1):
>   net/e1000/base: skip MANC check for 82575
> 
> Dima Ruinskiy (5):
>   net/igc/base: fix deadlock in i225
>   net/igc/base: fix infinite loop
>   net/igc/base: fix typo in LTR calculation
>   net/igc/base: fix unused value
>   net/e1000/base: fix unchecked return
> 
> Jakub Buchocki (1):
>   net/e1000/base: fix uninitialized variable usage
> 
> Pawel Malinowski (2):
>   net/igc/base: fix semaphore timeout value
>   net/e1000/base: fix semaphore timeout value
> 
> Przemyslaw Ciesielski (4):
>   net/igc/base: fix bitwise op type mismatch
>   net/igc/base: fix static analysis warning
>   net/e1000/base: fix static analysis warning
>   net/e1000/base: fix static analysis warning
> 
> Sasha Neftin (3):
>   net/igc/base: increase PHY power up delay
>   net/igc/base: reset loop variable
>   net/igc/base: fix LTR for i225
> 
>  .mailmap                                      |  3 +++
>  .../net/intel/e1000/base/e1000_80003es2lan.c  |  2 +-
>  drivers/net/intel/e1000/base/e1000_82575.c    |  5 ++--
>  drivers/net/intel/e1000/base/e1000_base.c     |  3 ++-
>  drivers/net/intel/e1000/base/e1000_defines.h  |  1 +
>  drivers/net/intel/e1000/base/e1000_ich8lan.c  |  2 ++
>  drivers/net/intel/e1000/base/e1000_mac.c      | 12 +++++----
>  drivers/net/intel/e1000/base/e1000_nvm.c      |  4 +--
>  drivers/net/intel/e1000/base/e1000_phy.c      | 25 +++++++++----------
>  drivers/net/intel/e1000/base/e1000_vf.c       | 12 +++++----
>  drivers/net/intel/igc/base/igc_defines.h      |  1 +
>  drivers/net/intel/igc/base/igc_i225.c         | 24 ++++++++++++------
>  drivers/net/intel/igc/base/igc_mac.c          | 10 +++++---
>  drivers/net/intel/igc/base/igc_nvm.c          |  4 +--
>  drivers/net/intel/igc/base/igc_phy.c          |  8 +++---
>  15 files changed, 68 insertions(+), 48 deletions(-)
> 

Patches all LGTM. I see a couple of fixes have to be applied to both e1000
and igc - which is another reason why we are deduplicating and merging
those drivers - but agree with the decision to keep the fixes in separate
patches here for easier reviewing/backporting/cherry-picking.

Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>

Series applied to dpdk-next-net-intel

Thanks,
/Bruce