From patchwork Wed Sep 17 13:46:50 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 415 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id B9F22B3ED; Wed, 17 Sep 2014 15:41:56 +0200 (CEST) Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by dpdk.org (Postfix) with ESMTP id 14F5CB3E5 for ; Wed, 17 Sep 2014 15:41:52 +0200 (CEST) Received: by mail-we0-f181.google.com with SMTP id w62so1430287wes.26 for ; Wed, 17 Sep 2014 06:47:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=P91+j7XMvauaNcSmzyr/aeB1DV+eXQsa8Z95wpjtXA4=; b=GaU/LL8V1NIdkc/oUkaml2iqhSTivb8PbLXK8dtbXffCRg+G6eYCEz/524eiNMQMpw 5xnKNHLsCGiH658zNh70lHF//cR4hqj7QCx3lkIUdoQMytyEewJIOV+EcGk+26RpGCsK DwwDds+EJb3U1ASXRX0iSZnZXbhv1JmrOwOb8yHZ628AgkwfQkd1tUjwpifC3jL3Y9lt HSHj7gitCgvKGeklowaz4yxQ/dBoavHDyUMYlpiMzhBzM/wrkCDBe35s2nd7rhJoHeiG PWfMMbc0I5+4IZ9O1yuX3BQBQm1gChRiiE0qqGRc80EiZjSaXjbLbQpffSU8r0iL2TFn 2OHA== X-Gm-Message-State: ALoCoQnmXBO1L1tNSmdGSZVN79EE5FNaNmrvUfseY3VgWzoBE7ELM8nk9kLvhhs00Xg487N3QDbj X-Received: by 10.194.76.195 with SMTP id m3mr2683581wjw.136.1410961653146; Wed, 17 Sep 2014 06:47:33 -0700 (PDT) Received: from alcyon.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id fa20sm5712872wic.1.2014.09.17.06.47.31 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Sep 2014 06:47:32 -0700 (PDT) From: David Marchand To: dev@dpdk.org Date: Wed, 17 Sep 2014 15:46:50 +0200 Message-Id: <1410961612-8571-19-git-send-email-david.marchand@6wind.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1410961612-8571-1-git-send-email-david.marchand@6wind.com> References: <1410961612-8571-1-git-send-email-david.marchand@6wind.com> Subject: [dpdk-dev] [PATCH v3 18/20] e1000: always log init messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 'init' messages should always be logged and filtered at runtime by rte_log. All the more so as these messages are not in the datapath. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- lib/librte_pmd_e1000/e1000_logs.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/librte_pmd_e1000/e1000_logs.h b/lib/librte_pmd_e1000/e1000_logs.h index 4dd7208..4a92804 100644 --- a/lib/librte_pmd_e1000/e1000_logs.h +++ b/lib/librte_pmd_e1000/e1000_logs.h @@ -34,12 +34,13 @@ #ifndef _E1000_LOGS_H_ #define _E1000_LOGS_H_ -#ifdef RTE_LIBRTE_E1000_DEBUG_INIT #define PMD_INIT_LOG(level, fmt, args...) \ - RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) + rte_log(RTE_LOG_ ## level, RTE_LOGTYPE_PMD, \ + "PMD: %s(): " fmt "\n", __func__, ##args) + +#ifdef RTE_LIBRTE_E1000_DEBUG_INIT #define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>") #else -#define PMD_INIT_LOG(level, fmt, args...) do { } while (0) #define PMD_INIT_FUNC_TRACE() do { } while (0) #endif