Message ID | 1423103460-4161-1-git-send-email-jijiang.liu@intel.com (mailing list archive) |
---|---|
State | Rejected, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 3DA5AB40C; Thu, 5 Feb 2015 03:31:11 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E1EE2B400 for <dev@dpdk.org>; Thu, 5 Feb 2015 03:31:09 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 04 Feb 2015 18:31:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,521,1418112000"; d="scan'208";a="681122394" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by orsmga002.jf.intel.com with ESMTP; 04 Feb 2015 18:31:08 -0800 Received: from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com [10.239.29.89]) by shvmail01.sh.intel.com with ESMTP id t152V5C4031945; Thu, 5 Feb 2015 10:31:05 +0800 Received: from shecgisg004.sh.intel.com (localhost [127.0.0.1]) by shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id t152V2v4004196; Thu, 5 Feb 2015 10:31:04 +0800 Received: (from jijiangl@localhost) by shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t152V2h7004192; Thu, 5 Feb 2015 10:31:02 +0800 From: Jijiang Liu <jijiang.liu@intel.com> To: dev@dpdk.org Date: Thu, 5 Feb 2015 10:31:00 +0800 Message-Id: <1423103460-4161-1-git-send-email-jijiang.liu@intel.com> X-Mailer: git-send-email 1.7.12.2 Subject: [dpdk-dev] [PATCH] maintainer: claim review for Xen Dom0 support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Jijiang Liu
Feb. 5, 2015, 2:31 a.m. UTC
I will be a volunteer of reviewing the following files:
lib/librte_eal/linuxapp/xen_dom0/*
lib/librte_eal/linuxapp/eal/eal_xen_memory.c
lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h
Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
---
MAINTAINERS | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Comments
Hi Jijiang, 2015-02-05 10:31, Jijiang Liu: > I will be a volunteer of reviewing the following files: > lib/librte_eal/linuxapp/xen_dom0/* > lib/librte_eal/linuxapp/eal/eal_xen_memory.c > lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h Actually, the section that you are subscribing is wider: F: lib/librte_eal/linuxapp/xen_dom0/ F: lib/librte_eal/linuxapp/eal/*xen* F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h F: lib/librte_mempool/rte_dom0_mempool.c F: lib/librte_pmd_xenvirt/ F: doc/guides/xen/ F: app/test-pmd/mempool_* F: examples/vhost_xen/ > Linux Xen > +M: Jijiang Liu <jijiang.liu@intel.com> Was your intention to be responsible of the whole Xen area or only of EAL for Xen?
Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, February 05, 2015 4:25 PM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] maintainer: claim review for Xen Dom0 > support > > Hi Jijiang, > > 2015-02-05 10:31, Jijiang Liu: > > I will be a volunteer of reviewing the following files: > > lib/librte_eal/linuxapp/xen_dom0/* > > lib/librte_eal/linuxapp/eal/eal_xen_memory.c > > lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h > > Actually, the section that you are subscribing is wider: > F: lib/librte_eal/linuxapp/xen_dom0/ > F: lib/librte_eal/linuxapp/eal/*xen* > F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h > F: lib/librte_mempool/rte_dom0_mempool.c > F: lib/librte_pmd_xenvirt/ > F: doc/guides/xen/ > F: app/test-pmd/mempool_* > F: examples/vhost_xen/ > > > Linux Xen > > +M: Jijiang Liu <jijiang.liu@intel.com> > > Was your intention to be responsible of the whole Xen area or only of EAL for > Xen? I just talked this with Xie Huawei, and I know that he will be a volunteer for the following files. F: lib/librte_pmd_xenvirt/ F: doc/guides/xen/ F: app/test-pmd/mempool_* F: examples/vhost_xen/ so I will be responsible for the following files: F: lib/librte_eal/linuxapp/xen_dom0/ F: lib/librte_eal/linuxapp/eal/*xen* F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h F: lib/librte_mempool/rte_dom0_mempool.c > -- > Thomas
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu > Sent: Thursday, February 5, 2015 10:31 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] maintainer: claim review for Xen Dom0 support > > > I will be a volunteer of reviewing the following files: > lib/librte_eal/linuxapp/xen_dom0/* > lib/librte_eal/linuxapp/eal/eal_xen_memory.c > lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h > > Signed-off-by: Jijiang Liu <jijiang.liu@intel.com> Acked-by: Helin Zhang <helin.zhang@intel.com> > --- > MAINTAINERS | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 9a63714..206783d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -110,6 +110,7 @@ Linux VFIO > F: lib/librte_eal/linuxapp/eal/*vfio* > > Linux Xen > +M: Jijiang Liu <jijiang.liu@intel.com> > F: lib/librte_eal/linuxapp/xen_dom0/ > F: lib/librte_eal/linuxapp/eal/*xen* > F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h > -- > 1.7.7.6
2015-02-05 08:34, Liu, Jijiang: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-02-05 10:31, Jijiang Liu: > > > I will be a volunteer of reviewing the following files: > > > lib/librte_eal/linuxapp/xen_dom0/* > > > lib/librte_eal/linuxapp/eal/eal_xen_memory.c > > > lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h > > > > Actually, the section that you are subscribing is wider: > > F: lib/librte_eal/linuxapp/xen_dom0/ > > F: lib/librte_eal/linuxapp/eal/*xen* > > F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h > > F: lib/librte_mempool/rte_dom0_mempool.c > > F: lib/librte_pmd_xenvirt/ > > F: doc/guides/xen/ > > F: app/test-pmd/mempool_* > > F: examples/vhost_xen/ > > > > > Linux Xen > > > +M: Jijiang Liu <jijiang.liu@intel.com> > > > > Was your intention to be responsible of the whole Xen area or only of EAL for > > Xen? > > I just talked this with Xie Huawei, and I know that he will be a volunteer for the following files. > F: lib/librte_pmd_xenvirt/ > F: doc/guides/xen/ > F: app/test-pmd/mempool_* > F: examples/vhost_xen/ > > so I will be responsible for the following files: > F: lib/librte_eal/linuxapp/xen_dom0/ > F: lib/librte_eal/linuxapp/eal/*xen* > F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h > F: lib/librte_mempool/rte_dom0_mempool.c This patch cannot be accepted because you didn't split the section as described. Actually, I'm not sure it makes sense to split Xen support maintainance.
diff --git a/MAINTAINERS b/MAINTAINERS index 9a63714..206783d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -110,6 +110,7 @@ Linux VFIO F: lib/librte_eal/linuxapp/eal/*vfio* Linux Xen +M: Jijiang Liu <jijiang.liu@intel.com> F: lib/librte_eal/linuxapp/xen_dom0/ F: lib/librte_eal/linuxapp/eal/*xen* F: lib/librte_eal/linuxapp/eal/include/exec-env/rte_dom0_common.h