[dpdk-dev] doc: add note for txqflags in testpmd UG

Message ID 1427890211-30148-1-git-send-email-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

De Lara Guarch, Pablo April 1, 2015, 12:10 p.m. UTC
Since txqflags is now set from the default rx/tx configuration,
depending on the PMD, it might not be 0.
Therefore, user has to overwrite it with --txqflags 0.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 doc/guides/testpmd_app_ug/run_app.rst |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
  

Comments

Siobhan Butler April 1, 2015, 12:21 p.m. UTC | #1
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Wednesday, April 1, 2015 1:10 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: add note for txqflags in testpmd UG
> 
> Since txqflags is now set from the default rx/tx configuration, depending on
> the PMD, it might not be 0.
> Therefore, user has to overwrite it with --txqflags 0.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  doc/guides/testpmd_app_ug/run_app.rst |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/doc/guides/testpmd_app_ug/run_app.rst
> b/doc/guides/testpmd_app_ug/run_app.rst
> index 6cbbf40..b29c176 100644
> --- a/doc/guides/testpmd_app_ug/run_app.rst
> +++ b/doc/guides/testpmd_app_ug/run_app.rst
> @@ -405,6 +405,12 @@ They must be separated from the EAL options,
> shown in the previous section, with
>      Set the hexadecimal bitmask of TX queue flags, where 0 <= N <=
> 0x7FFFFFFF.
>      The default value is 0.
> 
> +    Note::
> +
> +        When using hardware offload functions such as vlan, checksum...,
> +        add txqflags=0, since depending on the PMD,
> +        txqflags might be set to a non-zero value.
> +
>  *   --rx-queue-stats-
> mapping=(port,queue,mapping)[,(port,queue,mapping)]
> 
>      Set the RX queues statistics counters mapping 0 <= mapping <= 15.
> --
> 1.7.4.1

Thanks Pablo that wording is better
Acked-by Siobhan Butler <siobhan.a.butler@intel.com>
  
Thomas Monjalon April 1, 2015, 7:25 p.m. UTC | #2
> > Since txqflags is now set from the default rx/tx configuration, depending on
> > the PMD, it might not be 0.
> > Therefore, user has to overwrite it with --txqflags 0.
> > 
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
> Thanks Pablo that wording is better
> Acked-by Siobhan Butler <siobhan.a.butler@intel.com>

Applied, thanks
  

Patch

diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst
index 6cbbf40..b29c176 100644
--- a/doc/guides/testpmd_app_ug/run_app.rst
+++ b/doc/guides/testpmd_app_ug/run_app.rst
@@ -405,6 +405,12 @@  They must be separated from the EAL options, shown in the previous section, with
     Set the hexadecimal bitmask of TX queue flags, where 0 <= N <= 0x7FFFFFFF.
     The default value is 0.
 
+    Note::
+
+        When using hardware offload functions such as vlan, checksum...,
+        add txqflags=0, since depending on the PMD,
+        txqflags might be set to a non-zero value.
+
 *   --rx-queue-stats-mapping=(port,queue,mapping)[,(port,queue,mapping)]
 
     Set the RX queues statistics counters mapping 0 <= mapping <= 15.