From patchwork Sun Jul 19 10:52:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 6497 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id B5DCEC336; Sun, 19 Jul 2015 12:53:37 +0200 (CEST) Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 7B21CC328 for ; Sun, 19 Jul 2015 12:53:33 +0200 (CEST) Received: by wgbcc4 with SMTP id cc4so17873158wgb.3 for ; Sun, 19 Jul 2015 03:53:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=acc8jKtqEbYF4dbFjcQfu3eZzLjPmuWBG7bXBILeZsk=; b=eJXtC42tfuZsMe/f4uttGZf2K/BK5/UgCNHtl1szZ8sy1f1JvMT0eQmSBUwqFgqfvY zivOCCuEKwaWmxxepafTHbMNObtVZQ5nvX55GtUaAY+VvJ5Q5/A0TMVj8Nf5u1+PmmlH p/LoLnkovnXeRkDClJWe5ENhBqBbT3VU7Ol+RvzcDEl14YR/o1PrrX6dSmzBAUApNyKs KdCCsGGUeNmuCxxFLMPtSgrPOphvnOOql0dE2VHrRu3LRv+psk0B0rGGeegYWf8yrBDY XvjKMj8VhR7iGq2qhcucPJYVMJKPP4PiK0+kUfTHjAwxt1H9rGznkkMNC8RqFQDB0GaH 0UKA== X-Gm-Message-State: ALoCoQkqGZu2ug33tX7PNreDX7dU5LyFIopbBfNJU2+zMh1Gag1GEa6w/lRdmaIP4ifpRV2TIVSb X-Received: by 10.194.250.69 with SMTP id za5mr46559889wjc.90.1437303213386; Sun, 19 Jul 2015 03:53:33 -0700 (PDT) Received: from XPS13.localdomain (117.114.118.80.rev.sfr.net. [80.118.114.117]) by smtp.gmail.com with ESMTPSA id d5sm6481160wiz.24.2015.07.19.03.53.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 19 Jul 2015 03:53:32 -0700 (PDT) From: Thomas Monjalon To: dev@dpdk.org Date: Sun, 19 Jul 2015 12:52:15 +0200 Message-Id: <1437303137-29430-3-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.4.2 In-Reply-To: <1437303137-29430-1-git-send-email-thomas.monjalon@6wind.com> References: <1437303137-29430-1-git-send-email-thomas.monjalon@6wind.com> Subject: [dpdk-dev] [PATCH 2/4] pci: fix detach and uninit naming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There are close and detach functions in ethdev. To keep a consistent naming, PCI functions called by ethdev detach must be named "detach" instead of "close". Fix also comments which mix close and uninit names. Signed-off-by: Thomas Monjalon --- doc/guides/rel_notes/deprecation.rst | 3 +++ lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 ++ lib/librte_eal/common/eal_common_pci.c | 20 ++++++++++++-------- lib/librte_eal/common/include/rte_pci.h | 6 ++++-- lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 ++ lib/librte_ether/rte_ethdev.c | 6 +++--- 6 files changed, 26 insertions(+), 13 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index eef01f1..5330d3b 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -16,6 +16,9 @@ Deprecation Notices There is no backward compatibility planned from release 2.2. All binaries will need to be rebuilt from release 2.2. +* The EAL function rte_eal_pci_close_one is deprecated because renamed to + rte_eal_pci_detach. + * The Macros RTE_HASH_BUCKET_ENTRIES_MAX and RTE_HASH_KEY_LENGTH_MAX are deprecated and will be removed with version 2.2. diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map index e537b42..b2d4441 100644 --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map @@ -115,5 +115,7 @@ DPDK_2.0 { DPDK_2.1 { global: + rte_eal_pci_detach; rte_memzone_free; + } DPDK_2.0; diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 60e40e0..16e8629 100644 --- a/lib/librte_eal/common/eal_common_pci.c +++ b/lib/librte_eal/common/eal_common_pci.c @@ -213,7 +213,7 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *d * driver. */ static int -rte_eal_pci_close_one_driver(struct rte_pci_driver *dr, +rte_eal_pci_detach_dev(struct rte_pci_driver *dr, struct rte_pci_device *dev) { const struct rte_pci_id *id_table; @@ -246,7 +246,6 @@ rte_eal_pci_close_one_driver(struct rte_pci_driver *dr, RTE_LOG(DEBUG, EAL, " remove driver: %x:%x %s\n", dev->id.vendor_id, dev->id.device_id, dr->name); - /* call the driver devuninit() function */ if (dr->devuninit && (dr->devuninit(dev) < 0)) return -1; /* negative value is an error */ @@ -297,7 +296,7 @@ pci_probe_all_drivers(struct rte_pci_device *dev) * failed, return 1 if no driver is found for this device. */ static int -pci_close_all_drivers(struct rte_pci_device *dev) +pci_detach_all_drivers(struct rte_pci_device *dev) { struct rte_pci_driver *dr = NULL; int rc = 0; @@ -306,7 +305,7 @@ pci_close_all_drivers(struct rte_pci_device *dev) return -1; TAILQ_FOREACH(dr, &pci_driver_list, next) { - rc = rte_eal_pci_close_one_driver(dr, dev); + rc = rte_eal_pci_detach_dev(dr, dev); if (rc < 0) /* negative value is an error */ return -1; @@ -349,12 +348,17 @@ err_return: return -1; } +int __attribute__ ((deprecated)) +rte_eal_pci_close_one(const struct rte_pci_addr *addr) +{ + return rte_eal_pci_detach(addr); +} + /* - * Find the pci device specified by pci address, then invoke close function of - * the driver of the devive. + * Detach device specified by its pci address. */ int -rte_eal_pci_close_one(const struct rte_pci_addr *addr) +rte_eal_pci_detach(const struct rte_pci_addr *addr) { struct rte_pci_device *dev = NULL; int ret = 0; @@ -366,7 +370,7 @@ rte_eal_pci_close_one(const struct rte_pci_addr *addr) if (rte_eal_compare_pci_addr(&dev->addr, addr)) continue; - ret = pci_close_all_drivers(dev); + ret = pci_detach_all_drivers(dev); if (ret < 0) goto err_return; diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h index e96f389..e3ca3fc 100644 --- a/lib/librte_eal/common/include/rte_pci.h +++ b/lib/librte_eal/common/include/rte_pci.h @@ -416,7 +416,7 @@ int rte_eal_pci_probe_one(const struct rte_pci_addr *addr); * Close the single PCI device. * * Scan the content of the PCI bus, and find the pci device specified by pci - * address, then call the close() function for registered driver that has a + * address, then call the devuninit() function for registered driver that has a * matching entry in its id_table for discovered device. * * @param addr @@ -425,7 +425,9 @@ int rte_eal_pci_probe_one(const struct rte_pci_addr *addr); * - 0 on success. * - Negative on error. */ -int rte_eal_pci_close_one(const struct rte_pci_addr *addr); +int rte_eal_pci_detach(const struct rte_pci_addr *addr); +int __attribute__ ((deprecated)) +rte_eal_pci_close_one(const struct rte_pci_addr *addr); /** * Dump the content of the PCI bus. diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map index e537b42..b2d4441 100644 --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map @@ -115,5 +115,7 @@ DPDK_2.0 { DPDK_2.1 { global: + rte_eal_pci_detach; rte_memzone_free; + } DPDK_2.0; diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 57f841e..9596047 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -584,9 +584,9 @@ rte_eth_dev_detach_pdev(uint8_t port_id, struct rte_pci_addr *addr) if (rte_eal_compare_pci_addr(&vp, &freed_addr) == 0) goto err; - /* invoke close func of the driver, + /* invoke devuninit func of the pci driver, * also remove the device from pci_device_list */ - if (rte_eal_pci_close_one(&freed_addr)) + if (rte_eal_pci_detach(&freed_addr)) goto err; *addr = freed_addr; @@ -656,7 +656,7 @@ rte_eth_dev_detach_vdev(uint8_t port_id, char *vdevname) if (rte_eth_dev_get_name_by_port(port_id, name)) goto err; /* walk around dev_driver_list to find the driver of the device, - * then invoke close function o the driver */ + * then invoke uninit function of the driver */ if (rte_eal_vdev_uninit(name)) goto err;