Message ID | 1468585713-28557-1-git-send-email-yuanhan.liu@linux.intel.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 7AB295581; Fri, 15 Jul 2016 14:25:36 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5881A532D for <dev@dpdk.org>; Fri, 15 Jul 2016 14:25:34 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 15 Jul 2016 05:25:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.28,368,1464678000"; d="scan'208"; a="1022334524" Received: from yliu-dev.sh.intel.com ([10.239.67.162]) by fmsmga002.fm.intel.com with ESMTP; 15 Jul 2016 05:25:26 -0700 From: Yuanhan Liu <yuanhan.liu@linux.intel.com> To: dev@dpdk.org Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, Yuanhan Liu <yuanhan.liu@linux.intel.com> Date: Fri, 15 Jul 2016 20:28:33 +0800 Message-Id: <1468585713-28557-1-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 Subject: [dpdk-dev] [PATCH] doc: deprecate vhost-cuse X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Yuanhan Liu
July 15, 2016, 12:28 p.m. UTC
Vhost-cuse was invented before vhost-user exist. The both are actually
doing the same thing: a vhost-net implementation in user space. But they
are not exactly the same thing.
Firstly, vhost-cuse is harder for use; no one seems to care it, either.
Furthermore, since v2.1, a large majority of development effort has gone
to vhost-user. For example, we extended the vhost-user spec to add the
multiple queue support. We also added the vhost-user live migration at
v16.04 and the latest one, vhost-user reconnect that allows vhost app
restart without restarting the guest. Both of them are very important
features for product usage and none of them works for vhost-cuse.
You now see that the difference between vhost-user and vhost-cuse is
big (and will be bigger and bigger as time moves forward), that you
should never use vhost-cuse, that we should drop it completely.
The remove would also result to a much cleaner code base, allowing us
to do all kinds of extending easier.
So here to mark vhost-cuse as deprecated in this release and will be
removed in the next release (v16.11).
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
---
doc/guides/rel_notes/deprecation.rst | 4 ++++
1 file changed, 4 insertions(+)
Comments
> Subject: [dpdk-dev] [PATCH] doc: deprecate vhost-cuse > > Vhost-cuse was invented before vhost-user exist. The both are actually > doing the same thing: a vhost-net implementation in user space. But they > are not exactly the same thing. > > Firstly, vhost-cuse is harder for use; no one seems to care it, either. > Furthermore, since v2.1, a large majority of development effort has gone > to vhost-user. For example, we extended the vhost-user spec to add the > multiple queue support. We also added the vhost-user live migration at > v16.04 and the latest one, vhost-user reconnect that allows vhost app > restart without restarting the guest. Both of them are very important > features for product usage and none of them works for vhost-cuse. > > You now see that the difference between vhost-user and vhost-cuse is > big (and will be bigger and bigger as time moves forward), that you > should never use vhost-cuse, that we should drop it completely. > > The remove would also result to a much cleaner code base, allowing us > to do all kinds of extending easier. > > So here to mark vhost-cuse as deprecated in this release and will be > removed in the next release (v16.11). > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> > --- > doc/guides/rel_notes/deprecation.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index f502f86..ee99558 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -41,3 +41,7 @@ Deprecation Notices > * The mempool functions for single/multi producer/consumer are > deprecated and > will be removed in 16.11. > It is replaced by rte_mempool_generic_get/put functions. > + > +* The vhost-cuse will be removed in 16.11. Since v2.1, a large majority of > + development effort has gone to vhost-user, such as multiple-queue, live > + migration, reconnect etc. Therefore, vhost-user should be used instead. > -- > 1.9.0 Acked-by: Ciara Loftus <ciara.loftus@intel.com>
> > Vhost-cuse was invented before vhost-user exist. The both are actually > > doing the same thing: a vhost-net implementation in user space. But they > > are not exactly the same thing. > > > > Firstly, vhost-cuse is harder for use; no one seems to care it, either. > > Furthermore, since v2.1, a large majority of development effort has gone > > to vhost-user. For example, we extended the vhost-user spec to add the > > multiple queue support. We also added the vhost-user live migration at > > v16.04 and the latest one, vhost-user reconnect that allows vhost app > > restart without restarting the guest. Both of them are very important > > features for product usage and none of them works for vhost-cuse. > > > > You now see that the difference between vhost-user and vhost-cuse is > > big (and will be bigger and bigger as time moves forward), that you > > should never use vhost-cuse, that we should drop it completely. > > > > The remove would also result to a much cleaner code base, allowing us > > to do all kinds of extending easier. > > > > So here to mark vhost-cuse as deprecated in this release and will be > > removed in the next release (v16.11). > > > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> > > Acked-by: Ciara Loftus <ciara.loftus@intel.com> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
On Wed, Jul 27, 2016 at 1:31 AM, Thomas Monjalon <thomas.monjalon@6wind.com> wrote: > > > Vhost-cuse was invented before vhost-user exist. The both are actually > > > doing the same thing: a vhost-net implementation in user space. But > they > > > are not exactly the same thing. > > > > > > Firstly, vhost-cuse is harder for use; no one seems to care it, either. > > > Furthermore, since v2.1, a large majority of development effort has > gone > > > to vhost-user. For example, we extended the vhost-user spec to add the > > > multiple queue support. We also added the vhost-user live migration at > > > v16.04 and the latest one, vhost-user reconnect that allows vhost app > > > restart without restarting the guest. Both of them are very important > > > features for product usage and none of them works for vhost-cuse. > > > > > > You now see that the difference between vhost-user and vhost-cuse is > > > big (and will be bigger and bigger as time moves forward), that you > > > should never use vhost-cuse, that we should drop it completely. > > > > > > The remove would also result to a much cleaner code base, allowing us > > > to do all kinds of extending easier. > > > > > > So here to mark vhost-cuse as deprecated in this release and will be > > > removed in the next release (v16.11). > > > > > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> > > > > Acked-by: Ciara Loftus <ciara.loftus@intel.com> > > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> > Acked-by: Rich Lane <rich.lane@bigswitch.com>
On Fri, 15 Jul 2016 20:28:33 +0800 Yuanhan Liu <yuanhan.liu@linux.intel.com> wrote: > Vhost-cuse was invented before vhost-user exist. The both are actually > doing the same thing: a vhost-net implementation in user space. But they > are not exactly the same thing. > > Firstly, vhost-cuse is harder for use; no one seems to care it, either. > Furthermore, since v2.1, a large majority of development effort has gone > to vhost-user. For example, we extended the vhost-user spec to add the > multiple queue support. We also added the vhost-user live migration at > v16.04 and the latest one, vhost-user reconnect that allows vhost app > restart without restarting the guest. Both of them are very important > features for product usage and none of them works for vhost-cuse. > > You now see that the difference between vhost-user and vhost-cuse is > big (and will be bigger and bigger as time moves forward), that you > should never use vhost-cuse, that we should drop it completely. > > The remove would also result to a much cleaner code base, allowing us > to do all kinds of extending easier. > > So here to mark vhost-cuse as deprecated in this release and will be > removed in the next release (v16.11). > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> > Acked-by: Ciara Loftus <ciara.loftus@intel.com> > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> > Acked-by: Rich Lane <rich.lane@bigswitch.com> Acked-by: Jan Viktorin <viktorin@rehivetech.com>
Hi Thomas, just my two cents as Ubuntu DPDK maintainer (and part of the Debian Team that does the same). We never used vhost-cuse in any of our exampled, documentations or tests (It seems we started "late enough"). So again I think it is a good change to drop rather unmaintained parts to make the rest more stable: Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Wed, Jul 27, 2016 at 8:59 PM, Jan Viktorin <viktorin@rehivetech.com> wrote: > On Fri, 15 Jul 2016 20:28:33 +0800 > Yuanhan Liu <yuanhan.liu@linux.intel.com> wrote: > > > Vhost-cuse was invented before vhost-user exist. The both are actually > > doing the same thing: a vhost-net implementation in user space. But they > > are not exactly the same thing. > > > > Firstly, vhost-cuse is harder for use; no one seems to care it, either. > > Furthermore, since v2.1, a large majority of development effort has gone > > to vhost-user. For example, we extended the vhost-user spec to add the > > multiple queue support. We also added the vhost-user live migration at > > v16.04 and the latest one, vhost-user reconnect that allows vhost app > > restart without restarting the guest. Both of them are very important > > features for product usage and none of them works for vhost-cuse. > > > > You now see that the difference between vhost-user and vhost-cuse is > > big (and will be bigger and bigger as time moves forward), that you > > should never use vhost-cuse, that we should drop it completely. > > > > The remove would also result to a much cleaner code base, allowing us > > to do all kinds of extending easier. > > > > So here to mark vhost-cuse as deprecated in this release and will be > > removed in the next release (v16.11). > > > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> > > Acked-by: Ciara Loftus <ciara.loftus@intel.com> > > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> > > Acked-by: Rich Lane <rich.lane@bigswitch.com> > > Acked-by: Jan Viktorin <viktorin@rehivetech.com> >
> > > Vhost-cuse was invented before vhost-user exist. The both are actually > > > doing the same thing: a vhost-net implementation in user space. But they > > > are not exactly the same thing. > > > > > > Firstly, vhost-cuse is harder for use; no one seems to care it, either. > > > Furthermore, since v2.1, a large majority of development effort has gone > > > to vhost-user. For example, we extended the vhost-user spec to add the > > > multiple queue support. We also added the vhost-user live migration at > > > v16.04 and the latest one, vhost-user reconnect that allows vhost app > > > restart without restarting the guest. Both of them are very important > > > features for product usage and none of them works for vhost-cuse. > > > > > > You now see that the difference between vhost-user and vhost-cuse is > > > big (and will be bigger and bigger as time moves forward), that you > > > should never use vhost-cuse, that we should drop it completely. > > > > > > The remove would also result to a much cleaner code base, allowing us > > > to do all kinds of extending easier. > > > > > > So here to mark vhost-cuse as deprecated in this release and will be > > > removed in the next release (v16.11). > > > > > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com> > > > Acked-by: Ciara Loftus <ciara.loftus@intel.com> > > > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> > > > Acked-by: Rich Lane <rich.lane@bigswitch.com> > > Acked-by: Jan Viktorin <viktorin@rehivetech.com> > Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> Applied, thanks
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index f502f86..ee99558 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -41,3 +41,7 @@ Deprecation Notices * The mempool functions for single/multi producer/consumer are deprecated and will be removed in 16.11. It is replaced by rte_mempool_generic_get/put functions. + +* The vhost-cuse will be removed in 16.11. Since v2.1, a large majority of + development effort has gone to vhost-user, such as multiple-queue, live + migration, reconnect etc. Therefore, vhost-user should be used instead.