From patchwork Tue Sep 19 01:51:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 28915 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3A8301B1BE; Tue, 19 Sep 2017 03:52:20 +0200 (CEST) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0043.outbound.protection.outlook.com [104.47.33.43]) by dpdk.org (Postfix) with ESMTP id 701A61B027; Tue, 19 Sep 2017 03:52:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YufAH2qqnjPjUCWgyI1fC9vMr8Uk8zkdf7xPzN1CxXM=; b=dI8wIaJa4oEsGV+iL9ZDPHNLCOJAKmyVkjbQqsBw1nEMm3tlsUnZ0/M4Zml3/O0GJUTJ9U7k39hweTuMbaI+12lRMGhbWHEN7WM+MjHmLqAr6eU8fAXJ4sS6bcH5v/AC4HLDwDY+geikZ+a8TWWJxl0kTXPtigN1ukruxK3tteM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Tue, 19 Sep 2017 01:52:07 +0000 From: Rasesh Mody To: dev@dpdk.org, ferruh.yigit@intel.com Cc: Rasesh Mody , Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Mon, 18 Sep 2017 18:51:30 -0700 Message-Id: <1505785903-1741-11-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1505785903-1741-1-git-send-email-rasesh.mody@cavium.com> References: <1505785903-1741-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: MWHPR14CA0048.namprd14.prod.outlook.com (2603:10b6:300:12b::34) To DM5PR0701MB3832.namprd07.prod.outlook.com (2603:10b6:4:7f::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc297e82-1dea-4bda-0a6b-08d4ff0108ef X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DM5PR0701MB3832; X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 3:5SA3BCpYvCGpxyU3uL3Ut2OojbXFscZ6stbwI0E9w6IKjulwkUExtHLOjn3g6d8OQI67CyXQL2Qey8vWNm0ES2gDYvhvqlHZZvM8I7zkDt5caBaer6m2oNNoLuUEjEpQbSqtX0T11bogtNODy4wG/U5o76ty9j14M+TG3xEcAWxsy5rAAxm3G0pV6BkrreFoEDvjXG/U9TQ+tfosUnz3zSDy2kDNEN+r55b2e4+vIqwlICSBUTOIiFRCSVG1MmMU; 25:kr07B12l9KVxwVfIX6VoN/0+xMrhaa9RisIPD6NqsbFmxslN2l7gr6Vebl5n7XeUvLLiRa/HiKfESdSfCKlkKdlqBfLZVg3w4DCbeOcaYXhb1XVI/iptH0Q/LRIIUE7SPHIhypb/jT8l4WGHpOnQOPnOFU714eUmpb/Lo05FlV2agRPMoluxljGd4nu7ubwEarKfsJDdiGm4VUnKp6Pe60Iiacqgl6MMMQ42i5omOeCHCG+8L3TDhwKDCZj7KpLVxZ8In7TXXFDTXXJu+PBffbdXrURGWoBees+HLw0yUu8AGW6Tk0eWW04Q7TEwm5YzkVs2MrLfYU8BeC6PMdwWHw==; 31:A88T2y0oDr8Vnm/nnMWRUTBxufFR46pEVSQT1P76rOoZmdHHUjxq8hOnYZFzXPT3QW7IYiamovMsj2ZP0n1HCyQO/fGqrEM0GcMnbdnuBmO66x7YOvyHW/6qng5yJ2+N2urgKOo15B3u+0jMY+JPf1p8uZUmLJkcdIuoeZxE/rCvguVRPVODT0X9l6KhR3k6EalFPmMw1MZtW7wyWH7n5VsAEey20s9cSy4pdnFLKF8= X-MS-TrafficTypeDiagnostic: DM5PR0701MB3832: X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 20:JA7123qrSIMhEW2YHYUagu2muVWXk2E/BjeEUIw8s5F6HlEMQ2WDiKQiBHSQuWdzg8zOM+ONS5CTNAGnJwmq/EhAvBmIGMW86RPK7qtgxjZYpvn6zIMXfDTlVNTSkqHXgyTgkmjwgqN1cHNNmbgaj0fNxktNUTd3F3Csn0qDGl06rMeBQyy2NhWxWmpfRppMMjvmHJzi1TWndaBNCiZn45uD6mKvqRf3SO+uNWQz7Bjau1aP4csAck2mpFcwefRnTbzhilSb4u2F/MMRvz7pCgTtVrrpXDjCe/0fQoCINThjwQp4zjCTPDi2i9NSf5zUYXyJ0105Y+TO9q+Ies8DEundl5KGYQfgjrrA5Hmc5A4ZoSRgy7QGUJ16bQQq4z71mitez2BV2n9a6NVREsvtsYozodcYE2ih59PWiEaN3ZoOVaUMsYjFVZ5uS/QSrKs97vvuMx+ge2OJdTW3eQnPhyc3nSoRemQPCw7QHu6W1yyXgdNOWyFwKYFhYCS3Smoe; 4:7xd8kQbcMNbK0E4mYLxEm7fTxgdEpBHn8IVNiMVurw43mIRNeVpgYxnQm2xU3ZpWbPO8Je+xZoSbMKnC0sXG6Gry+8oxZnlui8MlABRonBUGTidjZSdZYeALzLy900AnMEicIGGzurgvIlvtaqr79Pqg/rmEL7m8OP84vY50XE8SUeZ4cVQBc1fyva3WvyYqZwifF2VxIkn3PbQTEXXd5vGE6yHe2f6XDiU2d398MHud4jBYFnJhwB2Ng5YOvKi+ X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR0701MB3832; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR0701MB3832; X-Forefront-PRVS: 04359FAD81 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(199003)(189002)(72206003)(106356001)(305945005)(105586002)(7736002)(36756003)(2950100002)(50226002)(478600001)(25786009)(6666003)(3846002)(4720700003)(55016002)(8676002)(189998001)(66066001)(5003940100001)(81166006)(81156014)(50986999)(76176999)(316002)(5660300001)(16526017)(16586007)(47776003)(4326008)(6116002)(33646002)(21086003)(86362001)(8936002)(97736004)(68736007)(69596002)(53936002)(50466002)(2906002)(48376002)(101416001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR0701MB3832; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR0701MB3832; 23:XEP0qpuWQX5YDUIBApcemFpwGQJYC/0qy8WdmC7?= rf970Stuqk4bjOdjKQC++eBkgPm4KigaytTQccLV/EyMTJMYw9LbWRC4A5VYsupNUy0oLlapohPFg3u10/LT7rlUS/BKE8Mubh3vuvUcT0uY4iWU9ngY0jSXqCmWhcHwnXA02keaIqqmChSbVTvfnmXawMInQ4RkFQlbLroJCVjEa4BUfgVAZnPSGgqcepZXSgSdIFUVlFA96F6hEx/uSElwlkMGHgSZFd45edAo0Qfr4WqtZJUvC/QOd8RqW/j25KRMYv74MxYaO7VHkofW09y+1/QOyoZKK73YooZyMDImE13WBhQAGBbp2PvGDOxT4nv7FSVcgO0j2CDCPPQvTNxR3YAr/tKBoWqE/PPEPWr4RELURRyFYD7EXRrBFzrZ1wZCB9ocjfIuhc1FMopG25R5rBu89/vu9qe/SxrG4sGS1J+IuZhkhlJfixoviyZoAW8/rQZZTvqnjTCIjRr+AQdt258JovBmK23xx4UXBTFvol1eN3Mr/m3F3T8YZK35GOBuGhzJgBab3ZlCypz0fIfo5lE2T8tngElNxTFnvixk3j5REg9486CZGAqMyyvya76purmTTfnQZiruaYuO8QAis+wHyDCdwkC2v1HTIY+W169VYgkW8vZW4le6ZvCPD9iIkcUNvcAAf2pF87chtesx9UKl79wQZTmFihIpvR4c0oMPbXuWiqXpQeSP51lC5tK4Xgg2fOf44harEQkbOihQxsU7vR8mschibWV/u4T6PWanNfN0ZU730gFSOVgbi/mdQUDW42xU8B0gD+VqGUTcQ1XN9wh3LMQsl2Ih5L/sgm9ng/6qwH8N1r6NFuy04EUhRqmnVlWR0El4H8qp8RADKJ6/y3OkbLJx4pG3XX0hniFSjfqvOy0WEG489PHfuCPg/KblaOZv4ROrnsiLpGwOplkTaURIU7sr/5hSEuLVBGb4sMnK0zaAXP/Xlx6zr/zGIJniC5NUXTXbG0UCCgEW4cvlM0r/TtrlJGk8J7obbdHxvgR7tMUCijv/IqSBGktTajl8wqE6CvwqS1hDKdk0wOaOlzA8MP1fwuWuHADwx/w== X-Microsoft-Exchange-Diagnostics: 1; DM5PR0701MB3832; 6:7nSi+1H8VNB3APpomVcN+dHllDGXvkF26ZozS//C/NK4tffUriLs+6ZiXzxajcu3N0ef+gBGoWVTNQvTSd54WCpOHrx9+B0TJPOvNunxAbdc+nDiQ1ToH4tCZSmonpyLl4vuIHqTWqBu0I8lWgoQoWPTEYZ9zF4tBNgdXOWUJSvkjjDwPmtNpo8QxtWMFdFtK86QwdHriXYQRqCaMV/8V5rve7WMqpN2z3kskPPd61TJGz2kr6v2qObkgzkV10T/4Yhgg6DxiwmIXn3dFweLr/dL2a3MlUywsiDUR/2GBUetikXka6D2OUWG9rqJWEenGFeUHisjTthYFj1PaP8ceQ==; 5:9LesMDsHwji4JMc+GQ7bUCPStsGKwNcfdeLNtyKgBA4j5viNKHH0cRhT9DjFAHIeS6Hy7/jEdebtT7g0l+UCpTWAjnDqCYKhyod2vKiRNE3Krvhuvo0ykGveoSbenUxaNOAmmnbo+bMPBgibtrO0zQ==; 24:lj3XWNnB8nWMf/yam7OADqoBnRwIyoGTIQ7U0CyGOa2jttYGmdaCHK1Sqm1r/dzLGhDdnIzDnX1peBshTabWt+penuJcEGWe81NQcRq8lqI=; 7:qxlt+WwWOF6z/w/94i2B1yYD5UheF6l1MsLT0r1Q5/vcpEd3xBL/pistTWlcmoxSly1+SCkTCn/ZG07aWcOqv9WR0oh1fmiYauN1bNNIwiB9cWasOZ/hjn6RFinsuSEZ1f37K6VdDGlJuX45JwPHL9iBiNQmvD8hh/Dl51vxk7RfzZhorJZL8l+5LAiK2VA6dIEWN6TJMRBs62RvoTFSnYwTuZdCudxycB3VkpldGGA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2017 01:52:07.1172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0701MB3832 Subject: [dpdk-dev] [PATCH 40/53] net/qede/base: fix number of app table entries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Configure only the available/requested number of app entries rather than max entries (DCBX_MAX_APP_PROTOCOL) in ecore_dcbx_get_app_data(). Also, fixed a minor issue where incorrect size value is being passed for memcpy(). Fixes: 26ae839d06e9 ("qede: add DCBX support") Cc: stable@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dcbx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/base/ecore_dcbx.c b/drivers/net/qede/base/ecore_dcbx.c index 889d91a..22525df 100644 --- a/drivers/net/qede/base/ecore_dcbx.c +++ b/drivers/net/qede/base/ecore_dcbx.c @@ -417,7 +417,7 @@ static bool ecore_dcbx_iwarp_tlv(struct ecore_hwfn *p_hwfn, u32 app_info_bitmap, p_params->app_error = GET_MFW_FIELD(p_app->flags, DCBX_APP_ERROR); p_params->num_app_entries = GET_MFW_FIELD(p_app->flags, DCBX_APP_NUM_ENTRIES); - for (i = 0; i < DCBX_MAX_APP_PROTOCOL; i++) { + for (i = 0; i < p_params->num_app_entries; i++) { entry = &p_params->app_entry[i]; if (ieee) { u8 sf_ieee; @@ -1071,7 +1071,7 @@ enum _ecore_status_t ecore_dcbx_query_params(struct ecore_hwfn *p_hwfn, p_app->flags |= (u32)p_params->num_app_entries << DCBX_APP_NUM_ENTRIES_OFFSET; - for (i = 0; i < DCBX_MAX_APP_PROTOCOL; i++) { + for (i = 0; i < p_params->num_app_entries; i++) { entry = &p_app->app_pri_tbl[i].entry; *entry = 0; if (ieee) { @@ -1273,7 +1273,7 @@ enum _ecore_status_t ecore_dcbx_get_config_params(struct ecore_hwfn *p_hwfn, p_hwfn->p_dcbx_info->set.enabled = dcbx_info->operational.enabled; OSAL_MEMCPY(&p_hwfn->p_dcbx_info->set.config.params, &dcbx_info->operational.params, - sizeof(struct ecore_dcbx_admin_params)); + sizeof(p_hwfn->p_dcbx_info->set.config.params)); p_hwfn->p_dcbx_info->set.config.valid = true; OSAL_MEMCPY(params, &p_hwfn->p_dcbx_info->set,