From patchwork Thu Jan 10 16:14:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rafal Kozik X-Patchwork-Id: 49620 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07E381B8CB; Thu, 10 Jan 2019 17:14:20 +0100 (CET) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by dpdk.org (Postfix) with ESMTP id E3F9C1B8C0 for ; Thu, 10 Jan 2019 17:14:18 +0100 (CET) Received: by mail-lf1-f65.google.com with SMTP id i26so8722152lfc.0 for ; Thu, 10 Jan 2019 08:14:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sLVI7JI1iRDKM/QC4aAfsx+X1WLvJHR5xcXHAMEtfoM=; b=OLwW3Pu9xtcn2NNJVurpkLCGpbTAAna12Oi4WvCN7bcNJlgm+k/r4fjkP/FnUCh1gn uFqjkAEJk5aRTsSjSNbFpkjgsOnWWbgKHhAwsFrlSBrtXBkz9QGhy1H5AyimeqLcckoK FWDQM6yKCt4+xO9p0Gg/0i1e3RrPP2j5OxgAjy9dzfjh/WMiKxDODKFJiXiXAi1UT/UF UVLw1aaL4EYfE4kNHc9N5QDMnfrNif3Sz6pRilVb7VucIUgCX4wVsJMTydbqdLKXrXon sbNi1HKH7xw+PTcdCZirX8HEdUoqMYtA71ZgTmRPLnawHpMM5E/bW/pNMkq8i/ha7OYC UcmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sLVI7JI1iRDKM/QC4aAfsx+X1WLvJHR5xcXHAMEtfoM=; b=XIs50mm9NjlHju9I5FQ7+2UiRLDdpGOEctsPd7UUcQi96o0KtaiFHW9oe8BFa7TA29 Q+73YVnZfrCocGvkezyfgjULSvkelpxU0uc/jiKDOxbX0Hh1XOOZToCn/VjaqkA0m/oZ TwWvaoA9aOBfIzk9tWDqCrCpsDWbAnbcug9yAZaQmZYI0d7I9VEFDpkwGU94RUN5uV0K 4BVue1hIYgsdSP+Hs9NL/WhlO81R9D5Nk8h0K3A52aGlmaijRezjf+oAY7l+EWREOIXN PutdLXP9Ks9AYCnOzxX7stZ99WY6ejYiageln1Lzb8vqKTBDBAYli+MNgQpldYvRGo21 o7pQ== X-Gm-Message-State: AJcUukcldG86sSjFd30k9CZ04EPqeTmYJ61iirhycSJ/rwaK6pM0up0O Vzx0HJSoXB4vH/H5lZdeVkAMQWBZONU= X-Google-Smtp-Source: ALg8bN6MTrIf6eKvqyFA83Fzjt2RM9h+nS0CXEQzTWHriptpFvpo7w7VlWnZ9y7viYAGOCOIY5xUzA== X-Received: by 2002:a19:db54:: with SMTP id s81mr6709817lfg.102.1547136858156; Thu, 10 Jan 2019 08:14:18 -0800 (PST) Received: from rafalkozik.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id y81-v6sm15558112lje.30.2019.01.10.08.14.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 10 Jan 2019 08:14:17 -0800 (PST) From: Rafal Kozik To: dev@dpdk.org, keith.wiles@intel.com Cc: mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, matua@amazon.com, igorch@amazon.com, Rafal Kozik Date: Thu, 10 Jan 2019 17:14:02 +0100 Message-Id: <1547136846-23319-2-git-send-email-rk@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1547136846-23319-1-git-send-email-rk@semihalf.com> References: <1547136846-23319-1-git-send-email-rk@semihalf.com> Subject: [dpdk-dev] [PATCH 1/5] [pktgen] fix race condition in start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Flag SENDING_PACKETS must be set last. When it is set before SEND_FOREVER flag, Tx lcores start to call pktgen_send_pkts. But as current_tx_count is 0 and SEND_FOREVER is not yet set, SENDING_PACKETS will be cleared. This causes in some cases that start command will no take effect. Fixes: f5f901fdf52b ("Update for 1.8 rte_mbuf changes.") Signed-off-by: Rafal Kozik --- app/pktgen-cmds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/pktgen-cmds.c b/app/pktgen-cmds.c index 95f6ef1..655f6bd 100644 --- a/app/pktgen-cmds.c +++ b/app/pktgen-cmds.c @@ -1412,10 +1412,10 @@ pktgen_start_transmitting(port_info_t *info) rte_atomic64_set(&info->current_tx_count, rte_atomic64_read(&info->transmit_count)); - pktgen_set_port_flags(info, SENDING_PACKETS); - if (rte_atomic64_read(&info->current_tx_count) == 0) pktgen_set_port_flags(info, SEND_FOREVER); + + pktgen_set_port_flags(info, SENDING_PACKETS); } }