From patchwork Thu Feb 20 14:53:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wisam Jaddo X-Patchwork-Id: 65975 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B00E7A0556; Thu, 20 Feb 2020 15:53:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B73E21BF99; Thu, 20 Feb 2020 15:53:26 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2066.outbound.protection.outlook.com [40.107.21.66]) by dpdk.org (Postfix) with ESMTP id C5EE823D; Thu, 20 Feb 2020 15:53:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z6KUqBgh/3FkCZybSxpR7FmGfaM0lsHAfOrQXpfgpN0mL+UuxKSu69aDu9FTR/ZXzGT3oEiM+nwnLRRxLqizFpmJLMiFcAizZFK/KV2OfjGfoeOGeCETRcmRP4Q5m+jNw8HHRSMbe6iJi5yK5leQukl8j+4uZYYVwq24FKk+zGZFUaKb2zIG++LZ7UFsgreEKwLWNDC8e0XkEvLS0D1IlDUSd9bzh5JucznHF+cGFfeMQmCcIXKMnv5DvzAm8+wBtHZkbTKmzNmPUwPI+/MULRtGqxGrPB0JQscc8m38i+detZR1Ps6OlPnT/TKT1h1gZg38ms6tera901FZwV4F3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PgJH+kLXUztwoBNZPlhYx25qT/3DtaAvgVQb8dtuu+4=; b=FuXlHJqP5ewgxNQ8VKooslSX459hh1nZbrUON2gydLuhRyy5uYTuclDAzAZfpumWRTJhruwyMAQIRBxKWrKi8dhIM+XTFLcdoQFtPuXcB2gzcc7g3fWOcoWp8jnZQmkNTXzWo7z+xo64/lEN6Li/6gb/TaZt4svlNQPYz90arP3Z2FQUESN+hOZBsv8gCKG3R7h9mq6Ti4/+BzXsRBxGlmTjtCNCate5/tiT5LYmeeugpOOO2Yab2aOeOGR8Z+ZK+9folo/2q4eG4FyJKbTPDJMtYui97RgYhPAYTal/Q8JjJN860tZ0RHZNanvll7Apm4TWU1dmGAdMha/o8vXTWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PgJH+kLXUztwoBNZPlhYx25qT/3DtaAvgVQb8dtuu+4=; b=grIoQIq0UdFffyM5yBh42DzH5z/V3YQvLld15IDqWF6wHRufTu5qYONyqDNJSh8bPvlCazjr3PBTrpK33xOJ3nQ/SYo6gmLtU13h+O02czgbIeAqlVLtTTjhEg3sqsz9Kkxh5l28lBa1JwKedL6TZQeNqyrN7h4G03jtxUsYxrQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=wisamm@mellanox.com; Received: from AM0PR05MB6610.eurprd05.prod.outlook.com (20.178.202.18) by AM0PR05MB4964.eurprd05.prod.outlook.com (52.134.89.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.29; Thu, 20 Feb 2020 14:53:23 +0000 Received: from AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::f9b0:5b27:21a3:c758]) by AM0PR05MB6610.eurprd05.prod.outlook.com ([fe80::f9b0:5b27:21a3:c758%3]) with mapi id 15.20.2750.016; Thu, 20 Feb 2020 14:53:23 +0000 From: Wisam Jaddo To: dev@dpdk.org, rasland@mellanox.com, thomas@monjalon.net Cc: olivier.matz@6wind.com, bernard.iremonger@intel.com, stable@dpdk.org Date: Thu, 20 Feb 2020 16:53:06 +0200 Message-Id: <1582210386-27331-1-git-send-email-wisamm@mellanox.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1582204709-7992-1-git-send-email-wisamm@mellanox.com> References: <1582204709-7992-1-git-send-email-wisamm@mellanox.com> X-ClientProxiedBy: PR0P264CA0171.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::15) To AM0PR05MB6610.eurprd05.prod.outlook.com (2603:10a6:208:12f::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mellanox.com (37.142.13.130) by PR0P264CA0171.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2750.17 via Frontend Transport; Thu, 20 Feb 2020 14:53:22 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [37.142.13.130] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 71382598-4b3b-46d2-8fda-08d7b614a22e X-MS-TrafficTypeDiagnostic: AM0PR05MB4964:|AM0PR05MB4964: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2276; X-Forefront-PRVS: 031996B7EF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(39850400004)(396003)(376002)(136003)(346002)(189003)(199004)(2616005)(4326008)(36756003)(8886007)(16526019)(66476007)(66946007)(8936002)(956004)(5660300002)(186003)(52116002)(26005)(66556008)(55016002)(7696005)(6666004)(86362001)(81166006)(2906002)(81156014)(8676002)(478600001)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4964; H:AM0PR05MB6610.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lLld8aH4zN8PvHedG4j7WPTOHYUKMjmtI2BeAsEOJIF+zXXG+Iwy65e/DdILS0A2KTww593+iil/STqQiVICU0ZJX/cngjWY+Z/tBKRCulKNSpvHCYuF9VCQmoCYeFl+Kmob29aCkgfF1zZoGDUDRiZgiJHkGI0KxiGdhzrb/rTDLcA9MuUi5Z39ErBq/Z38dryedIuI7o8pMcUAZHIGtk1nSBfg+lwYSnKFqqwzXgDyVT9cpHZl6QOJWBYLPhfPqcgflaLOy43p0TntZ3Ov88eUlEoL/xqroEZA88cNdYVjk+vB1xbHaClWvWdL1ydwqyoDFuh6gdEwy59lxvyXJYub8iZlkSRg2zaLpu399L9Ze2IKEh9EjC7UFm6GppW52Se2hUsNE4RQafxsQs/v6k/ABb/q9SlizFyecqLcprBle5W2m28KbkZPsxP5uwwL X-MS-Exchange-AntiSpam-MessageData: 49mAU32bifZuKp3N6hiqaQTbZU/LnE2rogwj6c3fv5Sbk8mtRDhgFmFZ6xffXFd3R1Y7tKju9cduJtJJpS7hJln5TP77cOeAabx93QATOcvB+7OXDgomjoSeCP/XW+mHcZOchmhWuSH2N8rLr7NhxA== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71382598-4b3b-46d2-8fda-08d7b614a22e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2020 14:53:23.5594 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PcZ9csmmhymQh8Yvhy1IvgzCPazPXmH4qb1o7OydZLSIR6gfF4UjPSYgGOKXZ2HHmxB/xgJ2JR43rk3Qt/r8ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4964 Subject: [dpdk-dev] [PATCH v3] cmdline: increase maximum line length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This increase due to the usage of cmdline in dpdk applications as config commands such as testpmd do for rte_flow rules creation. The current size of buffer is not enough to fill many cases of rte_flow commands validation/creation. rte_flow now can have outer items, inner items, modify actions, meta data actions, duplicate action, fate action and more in one single rte flow, thus 512 char will not be enough to validate such rte flow rules. Such change shouldn't affect the memory since the cmdline reading again using the same buffer. Cc: stable@dpdk.org Signed-off-by: Wisam Jaddo --- changes in v3 * Fix commit title Previous title was not that clear of what the change is * Add more clarification for what we need such increase * Explain why it won't cause any memory issue --- --- lib/librte_cmdline/cmdline_rdline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_cmdline/cmdline_rdline.h b/lib/librte_cmdline/cmdline_rdline.h index d217029..8193e1d 100644 --- a/lib/librte_cmdline/cmdline_rdline.h +++ b/lib/librte_cmdline/cmdline_rdline.h @@ -39,7 +39,7 @@ extern "C" { #endif /* configuration */ -#define RDLINE_BUF_SIZE 512 +#define RDLINE_BUF_SIZE 2048 #define RDLINE_PROMPT_SIZE 32 #define RDLINE_VT100_BUF_SIZE 8 #define RDLINE_HISTORY_BUF_SIZE BUFSIZ