[v13,08/10] app/testpmd: fix headers inclusion
Checks
Commit Message
- Include rte_os_shim.h in testpmd.h
- Remove redundant headers
Signed-off-by: Jie Zhou <jizh@microsoft.com>
Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
Acked-by: Tal Shnaiderman <talshn@nvidia.com>
---
app/test-pmd/cmdline.c | 3 ---
app/test-pmd/cmdline_flow.c | 2 --
app/test-pmd/parameters.c | 1 -
app/test-pmd/testpmd.h | 1 +
4 files changed, 1 insertion(+), 6 deletions(-)
Comments
2021-05-05 12:12 (UTC-0700), Jie Zhou:
> - Include rte_os_shim.h in testpmd.h
> - Remove redundant headers
>
> Signed-off-by: Jie Zhou <jizh@microsoft.com>
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> Acked-by: Tal Shnaiderman <talshn@nvidia.com>
It would be logical to merge this patch with the previous one.
On Mon, Jun 21, 2021 at 02:30:48AM +0300, Dmitry Kozlyuk wrote:
> 2021-05-05 12:12 (UTC-0700), Jie Zhou:
> > - Include rte_os_shim.h in testpmd.h
> > - Remove redundant headers
> >
> > Signed-off-by: Jie Zhou <jizh@microsoft.com>
> > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> > Acked-by: Tal Shnaiderman <talshn@nvidia.com>
>
> It would be logical to merge this patch with the previous one.
Will merge 08 and 07 into one in V14.
@@ -10,9 +10,6 @@
#include <string.h>
#include <unistd.h>
#include <inttypes.h>
-#include <sys/socket.h>
-#include <netinet/in.h>
-
#include <sys/queue.h>
#include <rte_common.h>
@@ -10,8 +10,6 @@
#include <errno.h>
#include <ctype.h>
#include <string.h>
-#include <arpa/inet.h>
-#include <sys/socket.h>
#include <rte_string_fns.h>
#include <rte_common.h>
@@ -19,7 +19,6 @@
#include <stdint.h>
#include <unistd.h>
#include <inttypes.h>
-#include <arpa/inet.h>
#include <rte_common.h>
#include <rte_byteorder.h>
@@ -11,6 +11,7 @@
#include <rte_bus_pci.h>
#include <rte_gro.h>
#include <rte_gso.h>
+#include <rte_os_shim.h>
#include <cmdline.h>
#include <sys/queue.h>