diff mbox series

examples/ipsec-secgw: fix parsing of flow queue

Message ID 1631772471-690-1-git-send-email-anoobj@marvell.com (mailing list archive)
State Accepted
Delegated to: akhil goyal
Headers show
Series examples/ipsec-secgw: fix parsing of flow queue | expand

Checks

Context Check Description
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/intel-Testing fail Testing issues
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/checkpatch success coding style OK

Commit Message

Anoob Joseph Sept. 16, 2021, 6:07 a.m. UTC
Documentation specifies that flow port & queue is provided as,

<...> port 0 queue 0

But code is expecting the same as,

<...> port 0 0

Fix the above to match documentation.

Fixes: 8e693616fcb2 ("examples/ipsec-secgw: enable flow based distribution")

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
 examples/ipsec-secgw/flow.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Akhil Goyal Sept. 16, 2021, 8:53 a.m. UTC | #1
> Documentation specifies that flow port & queue is provided as,
> 
> <...> port 0 queue 0
> 
> But code is expecting the same as,
> 
> <...> port 0 0
> 
> Fix the above to match documentation.
> 
> Fixes: 8e693616fcb2 ("examples/ipsec-secgw: enable flow based
> distribution")
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
Acked-by: Akhil Goyal <gakhil@marvell.com>
Akhil Goyal Sept. 24, 2021, 5:36 p.m. UTC | #2
> > Documentation specifies that flow port & queue is provided as,
> >
> > <...> port 0 queue 0
> >
> > But code is expecting the same as,
> >
> > <...> port 0 0
> >
> > Fix the above to match documentation.
> >
> > Fixes: 8e693616fcb2 ("examples/ipsec-secgw: enable flow based
> > distribution")
> >
> > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > ---
> Acked-by: Akhil Goyal <gakhil@marvell.com>
Applied to dpdk-next-crypto

Thanks.
Akhil Goyal Sept. 24, 2021, 5:36 p.m. UTC | #3
> > > Documentation specifies that flow port & queue is provided as,
> > >
> > > <...> port 0 queue 0
> > >
> > > But code is expecting the same as,
> > >
> > > <...> port 0 0
> > >
> > > Fix the above to match documentation.
> > >
> > > Fixes: 8e693616fcb2 ("examples/ipsec-secgw: enable flow based
> > > distribution")
> > >
> > > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > > ---
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> Applied to dpdk-next-crypto
> 
Cc: stable@dpdk.org
diff mbox series

Patch

diff --git a/examples/ipsec-secgw/flow.c b/examples/ipsec-secgw/flow.c
index 69f8405..1a1ec78 100644
--- a/examples/ipsec-secgw/flow.c
+++ b/examples/ipsec-secgw/flow.c
@@ -188,7 +188,9 @@  parse_flow_tokens(char **tokens, uint32_t n_tokens,
 				return;
 
 			rule->port = atoi(tokens[ti]);
+		}
 
+		if (strcmp(tokens[ti], "queue") == 0) {
 			INCREMENT_TOKEN_INDEX(ti, n_tokens, status);
 			if (status->status < 0)
 				return;