[v2] mempool/stack: build on Windows
Checks
Commit Message
enable build mempool/stack on Windows
----
V2 change:
- enable build lib stack on Windows which mempool/stack depends on
Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
---
drivers/mempool/stack/meson.build | 5 -----
lib/meson.build | 1 +
2 files changed, 1 insertion(+), 5 deletions(-)
Comments
2021-09-30 17:50 (UTC-0700), Jie Zhou:
> enable build mempool/stack on Windows
Nit: in commit body, we use correct capitalization, punctuation, and spelling.
> ----
> V2 change:
> - enable build lib stack on Windows which mempool/stack depends on
>
>
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
01/10/2021 09:42, Dmitry Kozlyuk:
> 2021-09-30 17:50 (UTC-0700), Jie Zhou:
> > enable build mempool/stack on Windows
>
> Nit: in commit body, we use correct capitalization, punctuation, and spelling.
>
> > ----
> > V2 change:
> > - enable build lib stack on Windows which mempool/stack depends on
> >
> >
> > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Applied, thanks.
01/10/2021 16:44, Thomas Monjalon:
> 01/10/2021 09:42, Dmitry Kozlyuk:
> > 2021-09-30 17:50 (UTC-0700), Jie Zhou:
> > > enable build mempool/stack on Windows
> >
> > Nit: in commit body, we use correct capitalization, punctuation, and spelling.
> >
> > > ----
> > > V2 change:
> > > - enable build lib stack on Windows which mempool/stack depends on
> > >
> > >
> > > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> >
> > Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
> Applied, thanks.
Note: I had to add #include <sys/queue.h> because of a recent commit.
@@ -1,11 +1,6 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017-2019 Intel Corporation
-if is_windows
- build = false
- reason = 'not supported on Windows'
-endif
-
sources = files('rte_mempool_stack.c')
deps += ['stack']
@@ -85,6 +85,7 @@ if is_windows
'gso',
'latencystats',
'pdump',
+ 'stack',
] # only supported libraries for windows
endif