diff mbox series

[v1] net/mlx5: error cqe handle Tx queue need assert

Message ID 1718175943-3586-1-git-send-email-junwang01@cestc.cn (mailing list archive)
State Rejected, archived
Delegated to: Raslan Darawsheh
Headers
Series [v1] net/mlx5: error cqe handle Tx queue need assert |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS

Commit Message

Jun Wang June 12, 2024, 7:05 a.m. UTC 
When encountering errors in handling some queues, we should assert
here; otherwise, some queues will fail to send packets continuously,
leading to traffic forwarding issues.

Bugzilla ID: 1449

Signed-off-by: Jun Wang <junwang01@cestc.cn>
---
 drivers/net/mlx5/mlx5_tx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Viacheslav Ovsiienko Oct. 28, 2024, 3:11 p.m. UTC | #1 
Hi,

I have some notes regarding the patch:

- patch does not fix the root cause of SQ state setting FW call failure
(https://bugs.dpdk.org/show_bug.cgi?id=1449 )
- MLX5_ASSERT is engaged only in debug mode and should not be used in release
- removing "return " prevents the tx_burst from retrying other errors recovery

What we should do - check if issue still exists and fix the root cause instead of
crippling the handling code.

With best regards,
Slava

> -----Original Message-----
> From: Jun Wang <junwang01@cestc.cn>
> Sent: Wednesday, June 12, 2024 10:06 AM
> To: dev@dpdk.org
> Subject: [PATCH v1] net/mlx5: error cqe handle Tx queue need assert
> 
> When encountering errors in handling some queues, we should assert here;
> otherwise, some queues will fail to send packets continuously, leading to
> traffic forwarding issues.
> 
> Bugzilla ID: 1449
> 
> Signed-off-by: Jun Wang <junwang01@cestc.cn>
> ---
>  drivers/net/mlx5/mlx5_tx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_tx.c b/drivers/net/mlx5/mlx5_tx.c index
> 1fe9521..e149f38 100644
> --- a/drivers/net/mlx5/mlx5_tx.c
> +++ b/drivers/net/mlx5/mlx5_tx.c
> @@ -213,7 +213,7 @@
>  				 * handling, we do not advance the index
>  				 * here, allowing to retry on next call.
>  				 */
> -				return;
> +				MLX5_ASSERT(ret < 0);
>  			}
>  			/*
>  			 * We are going to fetch all entries with
> --
> 1.8.3.1
> 
>
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_tx.c b/drivers/net/mlx5/mlx5_tx.c
index 1fe9521..e149f38 100644
--- a/drivers/net/mlx5/mlx5_tx.c
+++ b/drivers/net/mlx5/mlx5_tx.c
@@ -213,7 +213,7 @@ 
 				 * handling, we do not advance the index
 				 * here, allowing to retry on next call.
 				 */
-				return;
+				MLX5_ASSERT(ret < 0);
 			}
 			/*
 			 * We are going to fetch all entries with