From patchwork Thu Aug 1 11:31:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tathagat Priyadarshi X-Patchwork-Id: 142839 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C6DF45710; Thu, 1 Aug 2024 13:30:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C49A42D2B; Thu, 1 Aug 2024 13:30:31 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 0000E40DF8; Thu, 1 Aug 2024 13:30:28 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1fc569440e1so61677425ad.3; Thu, 01 Aug 2024 04:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722511828; x=1723116628; darn=dpdk.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=KUcugcszZWPbHqQpUrFQV7zjBzPTOyzVgJm4aSrp1i8=; b=ewo04O+fiIuo9BSwjt9hIpeXdqVTm/BhReVktWB2Uy/gy/nRmBzMwlIcSZMtja7Gnr Vf8bj1St0t0XT36/3lfy3qLXEThW+CwhDT/cVnfsTSLSEwxaPfCf4snbLyV5C55Cy2uU GpsolhXidzsrQTLxa5Pf+rH6aeAAUg6DFIqoj51G2q6XUvJknMPV+9vK3fccDK2xvX9I +KbEgjpEdpR7HRc/2yV7AsgwNc7DtxByOIQpn7IugnO8oPVeJjx2R+zF0d2l6pDTz5zC z8o7kGBIRoKPkfpU6wJrAyIkW86prrjRdecJu3KlMPwqJzm47u+0H1E9bWRMCblle2tJ wQBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722511828; x=1723116628; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KUcugcszZWPbHqQpUrFQV7zjBzPTOyzVgJm4aSrp1i8=; b=wfCMaFzKD/iWLOIvnq1vedaHDwXCM52xeyFhGN00w0pOKxxcU6IRUbHK+4RXkOqp8l /c+/jT0YzFZ2/09aTVRtE6ZyoII09Ef0zP4vpJeBDsR608vcLaLB/RcEaA8nNf/YRiNn 1OX0HjgPESN4g3E4wZim9fL8uLPqsme/RZEci+cZ2BnDFpVUeSKT2kplTrHq32N97/8l 8qzNYgSpV3IiJ1vV7CK06soCMqwxOTqIV76KAqfePArwxuRGvAs96mvzyd+DywT5TLMN F7QXMRD0C2P/JfZbVix80KMlSrhHp+LxW1vVnwMuudOaH/Fa45OH8ojkbuJB0th6YLQh xkiw== X-Forwarded-Encrypted: i=1; AJvYcCUEgLloXVgr+vMgsrVO78bnb1YWLy/bR371/xsM1kN0hLMzRUs/lhUqYw/JXjd3tCzUUvLq1eNjhcP1sn7H5Mk= X-Gm-Message-State: AOJu0Yw3paOXiz+77plVuSYUcFsqdALzY4m++xn+e4o3i7zP6QaCGpLM NhRRedj0vfkYgkjppRJ9ni9vffR9sIBlAb6xi7Ywmz8+izzSUuoSkcbUGg3A X-Google-Smtp-Source: AGHT+IHfblpvUCjqa0C4vKH3ow+7proh0ZPHb0qEUP9HSZ3sGbQZFdM0RjFx7SMmGMB5910CAk7DGw== X-Received: by 2002:a17:902:ea07:b0:1fb:67f4:1b72 with SMTP id d9443c01a7336-1ff4d25a6f8mr23788805ad.54.1722511827761; Thu, 01 Aug 2024 04:30:27 -0700 (PDT) Received: from tp-fat-se.vmware.com ([66.170.99.2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7ca8fd5sm136652855ad.64.2024.08.01.04.30.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Aug 2024 04:30:27 -0700 (PDT) From: Tathagat Priyadarshi To: dev@dpdk.org Cc: Tathagat Priyadarshi , stable@dpdk.org, Varun Lakkur Ambaji Rao Subject: [PATCH v2] net/gve : Update EOP bit in txd rte_mbuf chain Date: Thu, 1 Aug 2024 11:31:51 +0000 Message-Id: <1722511911-2403933-1-git-send-email-tathagat.dpdk@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1722443901-2400194-1-git-send-email-tathagat.dpdk@gmail.com> References: <1722443901-2400194-1-git-send-email-tathagat.dpdk@gmail.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The EOP bit was not set for all the packets in mbuf chain causing packet transmission stalls for packets split across mbuf in chain. Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO") Cc: stable@dpdk.org Signed-off-by: Tathagat Priyadarshi Signed-off-by: Varun Lakkur Ambaji Rao --- drivers/net/gve/gve_tx_dqo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c index a65e6aa..579b8d6 100644 --- a/drivers/net/gve/gve_tx_dqo.c +++ b/drivers/net/gve/gve_tx_dqo.c @@ -126,6 +126,7 @@ txd->pkt.dtype = GVE_TX_PKT_DESC_DTYPE_DQO; txd->pkt.compl_tag = rte_cpu_to_le_16(first_sw_id); txd->pkt.buf_size = RTE_MIN(tx_pkt->data_len, GVE_TX_MAX_BUF_SIZE_DQO); + txd->pkt.end_of_packet = 0; /* size of desc_ring and sw_ring could be different */ tx_id = (tx_id + 1) & mask;