diff mbox series

[v3,5/6] net/macb: fix tab errors in meson.build file

Message ID 1733814515-412204-1-git-send-email-liwencheng@phytium.com.cn (mailing list archive)
State Changes Requested
Delegated to: Stephen Hemminger
Headers
Series [v2,1/3] net/macb: add new driver |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS

Commit Message

Wencheng Li Dec. 10, 2024, 7:08 a.m. UTC 
Replace tabs with spaces to resolve indentation
issues in meson.build file.

Fixes: 97fd6a929cf8 ("net/macb: add new driver")
Cc: liwencheng@phytium.com.cn

Signed-off-by: Wencheng Li <liwencheng@phytium.com.cn>
---
 drivers/net/macb/base/meson.build | 25 ++++++++++++-------------
 drivers/net/macb/meson.build      |  6 +++---
 2 files changed, 15 insertions(+), 16 deletions(-)

Comments

Stephen Hemminger Dec. 10, 2024, 7:46 p.m. UTC | #1 
On Tue, 10 Dec 2024 07:08:35 +0000
Wencheng Li <liwencheng@phytium.com.cn> wrote:

> Replace tabs with spaces to resolve indentation
> issues in meson.build file.
> 
> Fixes: 97fd6a929cf8 ("net/macb: add new driver")
> Cc: liwencheng@phytium.com.cn
> 
> Signed-off-by: Wencheng Li <liwencheng@phytium.com.cn>

Since this is a new driver, please fix this in the earlier patch that
adds it rather than including a fixup patch. You can do this with
git rebase and squashing the patches.

Each patch in a new driver should be clean of basic stuff like
whitespace, bad flags, etc. And after each patch the build should
be clean.
Stephen Hemminger March 20, 2025, 6:53 p.m. UTC | #2 
On Tue, 10 Dec 2024 07:08:35 +0000
Wencheng Li <liwencheng@phytium.com.cn> wrote:

> Replace tabs with spaces to resolve indentation
> issues in meson.build file.
> 
> Fixes: 97fd6a929cf8 ("net/macb: add new driver")
> Cc: liwencheng@phytium.com.cn
> 
> Signed-off-by: Wencheng Li <liwencheng@phytium.com.cn>
> ---

Fix the formatting in the original patch since it is not
merged upstream yet.
diff mbox series

Patch

diff --git a/drivers/net/macb/base/meson.build b/drivers/net/macb/base/meson.build
index 009850f..888ac92 100644
--- a/drivers/net/macb/base/meson.build
+++ b/drivers/net/macb/base/meson.build
@@ -2,25 +2,24 @@ 
 # Copyright(c) 2022 Phytium Technology Co., Ltd.
 
 sources = [
-	'macb_common.c',
-	'macb_uio.c',
-	'generic_phy.c',
+        'macb_common.c',
+        'macb_uio.c',
+        'generic_phy.c',
 ]
 
 error_cflags = ['-Wno-unused-value',
-		'-Wno-unused-but-set-variable',
-		'-Wno-unused-variable',
-		'-Wno-unused-parameter',
-]
+        '-Wno-unused-but-set-variable',
+        '-Wno-unused-variable',
+        '-Wno-unused-parameter',
+        ]
 c_args = cflags
-
 foreach flag: error_cflags
-	if cc.has_argument(flag)
-		c_args += flag
-	endif
+    if cc.has_argument(flag)
+        c_args += flag
+    endif
 endforeach
 
 base_lib = static_library('macb_base', sources,
-	dependencies: static_rte_eal,
-	c_args: c_args)
+    dependencies: static_rte_eal,
+    c_args: c_args)
 base_objs = base_lib.extract_all_objects()
diff --git a/drivers/net/macb/meson.build b/drivers/net/macb/meson.build
index 28f7b37..7c79ab4 100644
--- a/drivers/net/macb/meson.build
+++ b/drivers/net/macb/meson.build
@@ -11,9 +11,9 @@  subdir('base')
 objs = [base_objs]
 
 sources = files(
-    'macb_ethdev.c',
-    'macb_rxtx.c',
-    )
+        'macb_ethdev.c',
+        'macb_rxtx.c',
+)
 
 if host_machine.cpu_family() == 'aarch64'
     sources += files('macb_rxtx_vec_neon.c')