diff mbox

[dpdk-dev] net/mlx5: fix tunnel offload detection

Message ID 20170904114351.104617-1-xuemingl@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Xueming Li Sept. 4, 2017, 11:43 a.m. UTC
PMD driver got random tunnel_en value on ConnextX-4LX NIC, depends on
compile optimization level. The variable was not initialized and
detection logic was absent.

Fixes: 578ff15e ("net/mlx5: add hardware checksum offload for tunnel
packets")

Signed-off-by: Xueming Li <xuemingl@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
---
 drivers/net/mlx5/mlx5.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Nélio Laranjeiro Sept. 4, 2017, 3:07 p.m. UTC | #1
On Mon, Sep 04, 2017 at 07:43:51PM +0800, Xueming Li wrote:
> PMD driver got random tunnel_en value on ConnextX-4LX NIC, depends on
> compile optimization level. The variable was not initialized and
> detection logic was absent.
> 
> Fixes: 578ff15e ("net/mlx5: add hardware checksum offload for tunnel
> packets")
> 
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index d7968f5..084df88 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -445,7 +445,7 @@ struct mlx5_args {
>  	struct ibv_device_attr device_attr;
>  	unsigned int sriov;
>  	unsigned int mps;
> -	unsigned int tunnel_en;
> +	unsigned int tunnel_en = 0;
>  	int idx;
>  	int i;
>  
> @@ -503,6 +503,7 @@ struct mlx5_args {
>  			mps = MLX5_MPW_DISABLED;
>  			break;
>  		case PCI_DEVICE_ID_MELLANOX_CONNECTX4LX:
> +			tunnel_en = 1;
>  			mps = MLX5_MPW;
>  			break;
>  		case PCI_DEVICE_ID_MELLANOX_CONNECTX5:
> -- 
> 1.8.3.1
 
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Ferruh Yigit Sept. 5, 2017, 3:56 p.m. UTC | #2
On 9/4/2017 4:07 PM, Nélio Laranjeiro wrote:
> On Mon, Sep 04, 2017 at 07:43:51PM +0800, Xueming Li wrote:
>> PMD driver got random tunnel_en value on ConnextX-4LX NIC, depends on
>> compile optimization level. The variable was not initialized and
>> detection logic was absent.

Fixes: f5fde5205101 ("net/mlx5: add hardware checksum offload for tunnel
packets")
Cc: stable@dpdk.org

>>
>> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
>> Acked-by: Shahaf Shuler <shahafs@mellanox.com>

> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index d7968f5..084df88 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -445,7 +445,7 @@  struct mlx5_args {
 	struct ibv_device_attr device_attr;
 	unsigned int sriov;
 	unsigned int mps;
-	unsigned int tunnel_en;
+	unsigned int tunnel_en = 0;
 	int idx;
 	int i;
 
@@ -503,6 +503,7 @@  struct mlx5_args {
 			mps = MLX5_MPW_DISABLED;
 			break;
 		case PCI_DEVICE_ID_MELLANOX_CONNECTX4LX:
+			tunnel_en = 1;
 			mps = MLX5_MPW;
 			break;
 		case PCI_DEVICE_ID_MELLANOX_CONNECTX5: