From patchwork Mon Sep 11 15:13:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Olivier Matz X-Patchwork-Id: 28586 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDA171B19E; Mon, 11 Sep 2017 17:13:54 +0200 (CEST) Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id A9C906D45 for ; Mon, 11 Sep 2017 17:13:51 +0200 (CEST) Received: from glumotte.dev.6wind.com (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id AE982CF32A for ; Mon, 11 Sep 2017 17:09:57 +0200 (CEST) From: Olivier Matz To: dev@dpdk.org Date: Mon, 11 Sep 2017 17:13:25 +0200 Message-Id: <20170911151333.5727-3-olivier.matz@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170911151333.5727-1-olivier.matz@6wind.com> References: <20170911151333.5727-1-olivier.matz@6wind.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 02/10] net/qede: fix compilation with -Og X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC qede_rxtx.o qede_rxtx.c: In function ‘qede_start_queues’: qede_rxtx.c:797:9: error: ‘rc’ may be used uninitialized in this function [-Werror=maybe-uninitialized] return rc; ^~ If there is no Rx or Tx queue, rc will not be initialized. Fix it by initializing rc to -1. Fixes: 4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation") Signed-off-by: Olivier Matz Acked-by: Harish Patil --- drivers/net/qede/qede_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 5c3613c7c..76e24abff 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -780,7 +780,7 @@ int qede_start_queues(struct rte_eth_dev *eth_dev) { struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev); uint8_t id; - int rc; + int rc = -1; for_each_rss(id) { rc = qede_rx_queue_start(eth_dev, id);