From patchwork Fri Oct 13 15:37:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: alok.makhariya@nxp.com X-Patchwork-Id: 30371 X-Patchwork-Delegate: pablo.de.lara.guarch@intel.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A0881B766; Fri, 13 Oct 2017 17:40:16 +0200 (CEST) Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0078.outbound.protection.outlook.com [104.47.38.78]) by dpdk.org (Postfix) with ESMTP id 4F0951B765 for ; Fri, 13 Oct 2017 17:40:15 +0200 (CEST) Received: from BN6PR03CA0082.namprd03.prod.outlook.com (10.164.122.148) by CY1PR03MB2363.namprd03.prod.outlook.com (10.166.207.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 13 Oct 2017 15:40:13 +0000 Received: from BY2FFO11OLC011.protection.gbl (2a01:111:f400:7c0c::142) by BN6PR03CA0082.outlook.office365.com (2603:10b6:405:6f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.77.21 via Frontend Transport; Fri, 13 Oct 2017 15:40:13 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; NXP1.onmicrosoft.com; dkim=none (message not signed) header.d=none;NXP1.onmicrosoft.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11OLC011.mail.protection.outlook.com (10.1.15.22) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Fri, 13 Oct 2017 15:40:13 +0000 Received: from netperf2.ap.freescale.net ([10.232.133.164]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9DFe82l031852; Fri, 13 Oct 2017 08:40:09 -0700 From: To: CC: , , , Alok Makhariya Date: Fri, 13 Oct 2017 21:07:30 +0530 Message-ID: <20171013153730.8395-1-alok.makhariya@nxp.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20171012130726.4332-1-alok.makhariya@nxp.com> References: <20171012130726.4332-1-alok.makhariya@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131523828132318841; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(376002)(346002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(104016004)(48376002)(86152003)(69596002)(77096006)(97736004)(50466002)(86362001)(189998001)(5003940100001)(4326008)(2950100002)(6916009)(76176999)(8656003)(50986999)(305945005)(50226002)(356003)(33646002)(8676002)(498600001)(36756003)(5660300001)(2906002)(6666003)(2876002)(105606002)(54906003)(16586007)(316002)(1076002)(68736007)(47776003)(53936002)(106466001)(2351001)(85426001)(8936002)(81156014)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2363; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC011; 1:cpnkrLeFMhMXtSBdKQeIaf9U6ATfSXuLsDJHcdSnsV4sjING2QbojQbeunYU0T5ij9EeVPjlLAgpzMAhNIiMafKrBGOPbbv3jrJx8AsBbA4JbrWKzt5/aiIwywYvh/Ba MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f5c5e876-aa6f-49e1-2d1c-08d51250b1c8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CY1PR03MB2363; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2363; 3:vW8F+2eym0sihZgUMzHrAEhLRW9Bd4Hw+YDvxGIjuPF03fyXA6QY9kamt7H/i67n4saI5ewkIGrsM1rxSGq2oty3tOwAkJkCq6SmqDR1BoHFzDXwqk7ipC7Op2qQ2CHQVlNlbfxw+o5EsccIsi/VlOvw9usXVkWNkRA/ukcEF9SOowYuvcl/0rXKawGBwm1oUG579yO/xeYV9eQba/qzjpupBDdYNIHlcbFNNrJdBoGpAPCI0NyKslcggVgaf4MZiP673p//QY/p9+V89J9eHyvC+v9hWT6YiitmMNBZkadHpLZNrZQsBIR/9k36Zb1dIbZjAZowUIuPpBu1On2zFCbwSDcQ1gAnsSdUotIP2A0=; 25:A6xGRTLW318V6Kmmwqx1aNRL37HP9qjfRjMnHY+sItWNSBjmrMn+hXx8GwVzk+CyXwDJWEcY6PJd8zuqtmUukIBvnckLXVYFSweBz8qoqjZluy9BhQkUdrpKb8hIGGggIZGdxSxhXZgFpzw4scKCjWvZq+b5CLtGx6tTMMl8gXr7gA1z1SdKEZ/OR3/xkNS1w39SrXT95Se1SpUiknZ3cvlxpE+Q1jfDd/su5vaLHRY/aavc61YwcypRrJW1+1ogLzMpq+itV07EoVygqALeqZqcG1QbGEpQ9Fc80HaBs39JjnVmTRYrF6FAlGwlbzqx0EuiCHBXPKRlvBNlgOdc8A== X-MS-TrafficTypeDiagnostic: CY1PR03MB2363: X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2363; 31:2XV2DxRo85rsF4rVSSVqgpDSume+AfNgCIVVJfZQeMvA5cwBWzyXbLaP5rq5/hY35Mntls0inTuOm9niysRntCpNKD/AWdjmGqCCjm3SWQ+5gdo6OXuwZfbTB4nkxMoEAGdKASibGftMLRFoBT+Nl83L2fSY9B6puF5RVuw+lm38Dqa3j+2rLxdos4eq+8bsH1/9kISOm68ST48mxEuyICFtv7hYnEDgofc/8I1bkWw=; 4:YiFIQSE84SR7BICnbtaT8rIbapantqt7PIOYRuZ33cVv+SEwC5wwvayBLmCmq6o1aA9kRrROtFYOePHqOCmfBkwRQurzDfkDJlmjgsTF/70mJB/YwcqMD/O3U1d1L5Ix+yWZt6Su72vMenyZwCvNnfv78d7Ng9TiSnlYKIs08EkdGwHk/HydmfkBsUD3yEYmx3tA/24qkayJe7PRP/03d3M8dNWo74WXDSKmY+j3F5Za4PCVVUXRMuJ7gEYrJrqIcUapsct7dS3oGbf28cMDeMxCB5NkAWQaThcAmi9MUdU= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123556025)(20161123561025)(20161123559100)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123563025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR03MB2363; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR03MB2363; X-Forefront-PRVS: 04599F3534 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR03MB2363; 23:eg2tZGeolPZ46ELQ5lqN9ifD2Sbs1zZmgkIzw6rmG?= RD6lqYszmgc+mFM4Qsj8NiRwehBaRPcnlAnBfgaVx81NvFTI8UJjhA2aC8EWd+xXO1+KWpnAoIfWwOHd6rq2I0NErSespKqCcHtkMsCUBNTw8HF32YeMlkvJxjGLD/w6kKjcsybW/bTG0CU+xlDOl2IibtLFJ6hATRLCpCp6Igd8fRg6kWvkbCiTwne7N37By42QX5zen4+GqiPumJFsFnCsWLKPjKGewzur1wzIYwtBsiwnwh37Oo9B+xSkYD0aBSFYTQc6b6xisqv4QDIhx63AGk0jOcaSPSHK3WA282UX1gEzupIBTKXAhkU7AQEOc2i7H7jzUh1ERn38vdmEvUX4ip8LIaX51w8JU0L2QwgN7siDk0QTDA06Xvxu0a6EYmjRb/2bkUybK2bTZsFTyPqPq90er3cdwgSmY/eNB+tGjbE8ag4fmiR39YsLLEqcMQMrfmL6EfI+u/jbEjBQ3FuW+mNrJXb3YMhtuAnZK7/hdiH35smKf1nf7sBhSoKPpUYaSzW2IDh+dEO5Cco8UqZ8+p531yJVlZuK0xUNFktr1dDJr4tfYTJHCoSSu8iJLdF115uVdb6/ymFKjsruL+IjQcRgLtz7TSGanj0En26K2+wvOR4a+YNU3dCY0S/gEJGL3F9MCzlivTP1C5Muhxg6mWolRQkMYQDL8oVxvoyW5i9X9BJOTRqW3aPFhm3mUfB+S6Y4DsPLZDKTmHAaKaFA8x6ruwt6/tI0Cs/TeU1wz6WXQZrnJL+czAudQ4fInXjevu0ETQBdFHoiqZ138gf4vZN8MUcw/ptfG6DwWRT0q8MYNrXqrt7ZnZPGbBVlVwBLAIN2ULrhbNgLAWvcfO+oui/goS5vFqgynrMrRF7a2e9ZGx6UIZ/R6YCAKI2M11N4EyH12UrSQQAxDDbqItLSwW3CWz3KxryGnSYVBJ6XwS9/94j2nHmYRl6UxRJ3gN4ucu+/nK57K7nlKAE+xfy83kc5BRDBZoNo5vovE0LHokj8oXThBfvUiVKDtT6lf+Uz92779JZNAKQLpTlB3oe0dhkkSxGLhMFUrvJOOV/s2OwW3EMWrAQRXU9kTxQlIDlc05qgFsyOdhD4VbiAfKpNWnRi2vrufpLJ+oOArbr0UppGdMHodVbo7Bg1JI/XAaeSFSy4IqhGU5q9cEDElKLy/X45noa8PLid6we3igYuQc7eHBecKeuSUmZV36u2y0= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2363; 6:t9uUU9791iusYcVfQUVNiI2mqu2htdomLFps6/2vFnAZR3l/uR69hLYU0pc+PTjO3BEu8D1VA8jD05WMFWsvtYTqBH1iiKj7eyAP+OrY8J4YMgIwkOAMDX1A0+BYHyIoTKTGxHtnRF/TnZpSMwHBugzGqDL+NRr7umKw5YRWe5++bqKUdUClIdIy5vyJ9m/Yjk4c/MXHrntIBK41A6SzEpJSWphyp92MNwHPvqpxjhIwdo4rsPkIfLOovqnzI1K2vgO51H4KJ4FB08cWTVAoa/N1LPUiSnohHZj0gf5XVO2DGBIqTondbbkJkg210g8Mh80pVBV5sLdTG01wnAXbEw==; 5:sn6vCghCpcaTPLkqEOEWXcPRGoTv8Gzb9qvnG6CKeJ0urhlYONFmyxWuIZ3V1IYobHTIeGsfXHDHOpY6My2hF7B3prC8vwcsn/DgoklSvdRI4wPMeQ84bHrhYpPLddkD3vN9p6orHRV7EOKD9zhWag==; 24:zvb5BtpDUPSEoDiwfMfbakBeuxX8Z/n+93NQxqnWiUonSIixL1R+hOWBASiMHD/3MIqqPjXkRYcKkRFQ28AtfcqrIukoh97FoqDWKR2I3+Q=; 7:ieEVYy2nxlaKQQPcUQb44O2AP9++FDi3LvOxxwgmmNN8gKBt3ptImByIUWwfC0uugiEXwFnb7EYv1fiUxz91dzYjKNMEo71tHux/o3X0vwVuCsG+xZzOBY8dz6qX/yYilcleRzVQDp7JepH/4O4G+0cP6K5jpv/DQoScl5M7gBHmJWmriPg4xSHQSAHC8UTIMpo2ZZ0XHnZoFhpdHrTxvqCESYD8E4c010+ousW5sEY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 15:40:13.0446 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2363 Subject: [dpdk-dev] [PATCH v2] crypto/dpaa_sec: add check for segmented buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Alok Makhariya The code would crash in case of segmented buffer if no check Fixes: 89aaf708d44b ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") Signed-off-by: Alok Makhariya Acked-by: Akhil Goyal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index 7b9a683..bd13d8c 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -893,6 +893,13 @@ dpaa_sec_enqueue_op(struct rte_crypto_op *op, struct dpaa_sec_qp *qp) return ret; } + /* + * Segmented buffer is not supported. + */ + if (!rte_pktmbuf_is_contiguous(op->sym->m_src)) { + op->status = RTE_CRYPTO_OP_STATUS_ERROR; + return -ENOTSUP; + } if (is_auth_only(ses)) { cf = build_auth_only(op, ses); } else if (is_cipher_only(ses)) {