From patchwork Wed Nov 22 09:28:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh X-Patchwork-Id: 31512 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 342A629D2; Wed, 22 Nov 2017 10:28:40 +0100 (CET) Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0064.outbound.protection.outlook.com [104.47.32.64]) by dpdk.org (Postfix) with ESMTP id B75202935 for ; Wed, 22 Nov 2017 10:28:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=t8AokmlVHLDUO8wHV/QbSA2eNSX1UEicyWnYh2kuPKU=; b=J0vZkoV2/MI9fmAOXTXAGmxlCY55sNkRVf8DPAAH0lMocViS+DfnL6L79wLrqHNU3P8kNXnjXfkUUgC5o2sSSl8BDsVYaTFDEiZ1963QbFJEzWPKKpQwIo9JU8QxdlBO8sNVE/7DNun5SFyXOv2MzU1rlzYsBcOMW6gPblPSY0Y= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT.caveonetworks.com (111.93.218.67) by DM5PR07MB3468.namprd07.prod.outlook.com (10.164.153.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Wed, 22 Nov 2017 09:28:32 +0000 From: Pavan Nikhilesh To: ferruh.yigit@intel.com, olivier.matz@6wind.com, thomas@monjalon.net Cc: dev@dpdk.org, Pavan Nikhilesh Date: Wed, 22 Nov 2017 14:58:06 +0530 Message-Id: <20171122092806.17194-3-pbhagavatula@caviumnetworks.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171122092806.17194-1-pbhagavatula@caviumnetworks.com> References: <20171122092806.17194-1-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: CY1PR07CA0002.namprd07.prod.outlook.com (10.166.202.12) To DM5PR07MB3468.namprd07.prod.outlook.com (10.164.153.23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a552c08d-dd60-494e-ad82-08d5318b674e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600022)(4604075)(2017052603258); SRVR:DM5PR07MB3468; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3468; 3:LEflF8os9aBHhboKatml7s55u0+WEbKH/bQgnaIqomhDTjpOiQOsfv6fyF/RcLmd+z4tLTpNbdLY5tmAKLYEeAZyCU7BItIT8kfDwU6sm6BvULQ3a6xt5HD5iHjUqI+/DEKuUA20YogkpqDzumqXTgjfmsDv8l4UCLdY8nLtFSquFj9czyOQWZfjeCMuAQFqbZ76o7MpOVZwCwamS1mykrgNO2iQk14W93A6MT2zzC/pkMCfLrjSfP8q5K1vNpz3; 25:40TUA1ggdxErFTtw/03MxoNxf+VaOWQp0akNP/IkdPjov3ZniI8wzTX7KCxYaQvVoCz2GXG3Wyyg9opo567yRFHEi8yVLNOr+AZwVGd15AtxLGVXPuKVtmF89mN7ywo447pPPF5siYGLhttV6H/SjPvzM4IBpoyC1ihRgkqOrBuYxVZPhS2AjOcwPr0BHTYi8AGrgni+PmhuDuCLbR6K2FgUYjz7XARj0GTNBcwZGbTnP/kf/27F7YJPBC7Lzp7jRggGwIKED2zUc0bWBD/at1mSqXoG7E27nB4YAEqAGj5b7mN+R4Ku1DeCbWPoY48UB2XIggH3Hupgv2XnrWlXUg==; 31:WITAWh0e62GMAQzLk2H495w+nZGRlx2qjTSEqyPt89LzoAl9Uqm1b7WuBNo17gBgLQGUqj/f5KuTv2QjnwicCf4FhA/D/hGxLbZMfpsKcdGpJQOZ3bm+7Jx/KUZy4Gs0WYitKj1TdPgtE4zyfZ7lid1JdmqxdWeUKhIR/PA/Jw/cKvgJdci5hV9/nb4H2oAxcczOpCHwupjrKmsHa4ZeyhLGvLrfD/nHBqVCXHdPg68= X-MS-TrafficTypeDiagnostic: DM5PR07MB3468: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3468; 20:j9V7YanCrcuIH0fk4cxJemrFh6+BM8x6FOftiNx0nfml8KcxJ3CYSnZY3IP6QQS1FOD2KN6Vntoib4fK46N8qID/gI0OhvQlfW3jhAiaqSwXsBIqZ0UOSr82qZUBkTf40BviB5puu1Axjh24PtlYFP5YQXHiDddsW20Wl0whqMYbDgyBsZZTE4egswi9/92pE+5IbOiDfnbhpx33kv9Qr0cmL9CmNZSMyn7IIbHEaFxwOA02VA9J5B4POdU9++R6RJWpEW0a5HTP/NToeOYG5U4PblVIMZUXQREIy1HRfKMDAjpBBRSoqhHcKrMaHJbuDXYBVgOwwf2TtgNp2uPV4uPQZl9ZfZ0CWX3jh1YOkfA+k3FSUqGRzO+oV4OJXcFajkBMF7+ISrvy8CFHdmf44hX01GWjpXtSBw+18ol1Lum/Yy1NpGexgQpQs5NHqh7dTMhJm7tQNCiemI6nYuFiaPLOYojLdLSovq1nB3magknfaU2WMEWGlEEOm+E3BsfyVqptdgjlOBdMNvJw5KL5OIuYHd6VoSmrItFlujE4DdvDw3qtRAi8pHM46MkUjB4EfNFTlesyXoijAn2Ci9vG4IXjFlfHl2pNfEVlUXNj2kw=; 4:RRlmY/EWh7zMAd+LV5REt+M5lrl6ArB8dG/EYnzBqxBP8usKb9N0e6MpIAJhJYQcIkebOu8FJzn+jOAZYA8aEYet/PsQdaeiuitRqwz7eKLwiicEWurLLpubgcjEuc//ASk5sliT0NTYl/rbA/z+oO0+BrUu8OZ6f+UMr6us0+dd0JoNP1sij1H5/BjhdVjKAVcDh33wtqHpTScTvAhxw/5l/zMuTMrX68NymEPXO/oxN6JpU4gdLdNBcpeK1/Ltkp4D+b7WAL6INVbaoaxhkA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(3231022)(6041248)(20161123555025)(20161123558100)(20161123564025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5PR07MB3468; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5PR07MB3468; X-Forefront-PRVS: 0499DAF22A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(189002)(199003)(66066001)(81166006)(97736004)(8676002)(50466002)(68736007)(47776003)(6666003)(42882006)(2950100002)(50986999)(76176999)(101416001)(5003940100001)(50226002)(2906002)(81156014)(69596002)(6486002)(305945005)(4326008)(36756003)(105586002)(106356001)(6512007)(33646002)(48376002)(107886003)(5009440100003)(53936002)(6506006)(7736002)(478600001)(8936002)(72206003)(189998001)(16526018)(5660300001)(16586007)(316002)(53416004)(1076002)(3846002)(6116002)(25786009)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3468; H:Pavan-LT.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3468; 23:ccFhBeg0bhbjKhjyokgdrYv+65Z6ET4aEMHaDefwy?= KhsK4z/dEc1G1mHV2uWqMn0VCSTeuG7F8Jo9j4q86colInUNc8nDK/CuxZbQ9ny/ToMrdr/GdiKqn4k0tloaxRDS+yB/T7cFEtCtMSlN9d8nE3xRCWq1HfrbXkSD5rt7auDeNK8Fe8vUK6aJBwkDvz5QSbBo7znU42zYxobr7oUBpL29T9Eg16JB/PYFMFc7cWGTfi+MK4zSIt2jxWUmpmJo2NWBkGgkySt7H5eg6/8QydylWay04L7ufEOWS/tI8IivysIcwyzalSoYnuHbj0WJxneU0h5YFwBvw1r67yGG40j/KO2JOC7M2GKmB111HNBZxnqomi3EkjvbpjpgIfsCdix7ztiMD8sbqq4iTHx1+DVYlQONIcHg6ZRVBg8tOZ0eD3oajIpXVdaDLDQdqwug764AzBI02z9xrxq0soJP9knI+/brVdwvR+mBN/sfdOdu0nEYUtOHk/wci3y21IuM3+bd9Rsr6KG6MDKhpVfe7g6Y/euAVb4dsY+rK6wmZxryuyPytX5kcBTHh0LEf3tMxTOi3cuafVw/NABx0Fr49tqJ2TpY3Ua/WwncLHWUjdtpedrG5FBHvH6qJnPubvIXUajgc8V+beqAaVAWANs24Dd1k8yMF9j6mWHIC0vJXqt1r2AI6tANNSjYHx3IQhYEycGtumZJGCfGFHVpK83bE8SiVZ/BRssneI+caW0RKJUQLpwqHwhL77DT8SU9xncZ1jORWt8rA/41SfeishyD9nq3s80BGJ6aYMC+10KXcStnOnOh0XjyCDoxzNyEuGi2xwxTrbEj/eqqYV+2h2vTtb6lRGTeaWAkywvzfqakUiwodBaEgD4ewJAaSybmGCltj/CRG1SCry+7mjR2aTMiXN8nge3/C3vuY96LgEdacowvzr19ps64FrB/ap1g17i0TZ9V1+o9PNBvAGqmNoGJ2H0lCBMmCgjyuIalOgbazjUECfFjml9e4k63f7yhgX50rOwK7yP+8o1k65As7NF6GJESPBh8gvaOFqEAgH/P9cPDcgIAvhvMjsTbgUcShrNlTCGPjEsDCT/G8n7oTId3I8JCg/GuEXoaNcqUCZtVtosCOtzVg2isRXbxAhXp1/b+z3zQW3yZKuujLy/ewXlILgMCzGrXxbYcOWmliAbstJe4JizeHROBsXVblFaes1t X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3468; 6:fTKvU5Tjg4tBT7NevExLkVJ6byTxP/sjZdlQeWnRlhbWnUabQrHm4PQKf6AWRm3mVqxTmcPo9xVjQLeLPz0iRtlH5tehb0768PzSlVXF1FuwcPAVxADj4lQkihi9RY6QfbGzNHT9Onp3zJxxyQ1IaDmYcUfwN05K/HNpxcCk2wVmEeCjdAf5/mCTb5OTUBgiy1LeW3n4v9esgHiDsO/HHw+OwGAE+06h6+MEzA4+tDEsLqekkZ23ALAwvaUUuJNWt4CqnVvxkAr6PPnvzoKfuQh0Hr08cWFEXUosh5uRIBy6Vm3Ak4K7E3EEwbj/glmGA6dXE5bCPZ159u17/E6pMqwBxK4hFeCDb5FKjwlTrhE=; 5:LPLwDApvwHy9ilYvxGVN8i4RkXx0eoL049VK0fAkAO+zkZCATnCm977n8U4QSqr0f2vT2AHy1w5KfDXC4B0V4FG+PnKuwQ+gUjsjA1BYo0AQWsxnlcQX6awzWxe0REpTouBYue1hTIqV812kaecK4CCsEQPPPAzAii1hrgwYdeU=; 24:kB2eEu/WRiDsWG8Vi67T3AEjziGk02GU0cGXrD5q531Zx+9P1wDk0B7inyLjZRS0rX4pmzYu8mmZHuOuTeixocbR5HyMCuRN1hCwroTOHyM=; 7:lYFMzd50iZCyjREiKxuLjTNejDFexB05MCqCiQ31QhbXoLmqCFuncvYbtvFon7pX2ws/NydbEeg972Chkt1b3PpRwiaLylZ8WdZlWp9zXvKNHZ7FdZsDFwioRRm3K6PZOpGOr3iqJMEveEuABwHLS0t8iVlquCN0cqWJJAdCKbCasbhmdL05ZS8lxrFLMvkHZkRwpCIU1jOwEmevQ7laTTIpHmWyi6k5qQyXvue91jK2FtEBpbYd/7a8/URB3tQo SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2017 09:28:32.8717 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a552c08d-dd60-494e-ad82-08d5318b674e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3468 Subject: [dpdk-dev] [PATCH 3/3] logs: remove log level config option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config option for controlling datapath log level. RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to control global and module specific log levels. Signed-off-by: Pavan Nikhilesh --- config/common_base | 1 - devtools/test-build.sh | 2 +- doc/guides/faq/faq.rst | 3 --- drivers/net/ena/base/ena_plat_dpdk.h | 2 +- drivers/net/sfc/sfc_debug.h | 2 +- examples/l3fwd-acl/main.c | 2 +- test/test/test.h | 2 +- 7 files changed, 5 insertions(+), 9 deletions(-) diff --git a/config/common_base b/config/common_base index e74febef4..e7af26cc8 100644 --- a/config/common_base +++ b/config/common_base @@ -94,7 +94,6 @@ CONFIG_RTE_MAX_MEMSEG=256 CONFIG_RTE_MAX_MEMZONE=2560 CONFIG_RTE_MAX_TAILQ=32 CONFIG_RTE_ENABLE_ASSERT=n -CONFIG_RTE_LOG_LEVEL=RTE_LOG_INFO CONFIG_RTE_LOG_DP_LEVEL=RTE_LOG_INFO CONFIG_RTE_LOG_HISTORY=256 CONFIG_RTE_BACKTRACE=y diff --git a/devtools/test-build.sh b/devtools/test-build.sh index 092d3a7f3..7e9e1e187 100755 --- a/devtools/test-build.sh +++ b/devtools/test-build.sh @@ -157,7 +157,7 @@ config () # ! echo $3 | grep -q '+shared' || \ sed -ri 's,(SHARED_LIB=)n,\1y,' $1/.config ! echo $3 | grep -q '+debug' || ( \ - sed -ri 's,(RTE_LOG_LEVEL=).*,\1RTE_LOG_DEBUG,' $1/.config + sed -ri 's,(RTE_LOG_DP_LEVEL=).*,\1RTE_LOG_DEBUG,' $1/.config sed -ri 's,(_DEBUG.*=)n,\1y,' $1/.config sed -ri 's,(_STAT.*=)n,\1y,' $1/.config sed -ri 's,(TEST_PMD_RECORD_.*=)n,\1y,' $1/.config ) diff --git a/doc/guides/faq/faq.rst b/doc/guides/faq/faq.rst index dac805099..55dcfe9c2 100644 --- a/doc/guides/faq/faq.rst +++ b/doc/guides/faq/faq.rst @@ -103,9 +103,6 @@ Yes, the option ``--log-level=`` accepts one of these numbers: #define RTE_LOG_INFO 7U /* Informational. */ #define RTE_LOG_DEBUG 8U /* Debug-level messages. */ -It is also possible to change the default level at compile time -with ``CONFIG_RTE_LOG_LEVEL``. - How can I tune my network application to achieve lower latency? --------------------------------------------------------------- diff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h index accecf518..8cba319eb 100644 --- a/drivers/net/ena/base/ena_plat_dpdk.h +++ b/drivers/net/ena/base/ena_plat_dpdk.h @@ -96,7 +96,7 @@ typedef uint64_t dma_addr_t; #define ENA_GET_SYSTEM_USECS() \ (rte_get_timer_cycles() * US_PER_S / rte_get_timer_hz()) -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG #define ENA_ASSERT(cond, format, arg...) \ do { \ if (unlikely(!(cond))) { \ diff --git a/drivers/net/sfc/sfc_debug.h b/drivers/net/sfc/sfc_debug.h index 92eba9c38..3f9ccf1e6 100644 --- a/drivers/net/sfc/sfc_debug.h +++ b/drivers/net/sfc/sfc_debug.h @@ -35,7 +35,7 @@ #include #ifdef RTE_LIBRTE_SFC_EFX_DEBUG -/* Avoid dependency from RTE_LOG_LEVEL to be able to enable debug check +/* Avoid dependency from RTE_LOG_DP_LEVEL to be able to enable debug check * in the driver only. */ #define SFC_ASSERT(exp) RTE_VERIFY(exp) diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c index e50b1a1a8..eb78decdd 100644 --- a/examples/l3fwd-acl/main.c +++ b/examples/l3fwd-acl/main.c @@ -68,7 +68,7 @@ #include #include -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG #define L3FWDACL_DEBUG #endif #define DO_RFC_1812_CHECKS diff --git a/test/test/test.h b/test/test/test.h index 08ffe949c..8fdb3045e 100644 --- a/test/test/test.h +++ b/test/test/test.h @@ -204,7 +204,7 @@ struct unit_test_case { #define TEST_CASES_END() { NULL, NULL, NULL, NULL, 0 } -#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG #define TEST_HEXDUMP(file, title, buf, len) rte_hexdump(file, title, buf, len) #else #define TEST_HEXDUMP(file, title, buf, len) do {} while (0)