From patchwork Wed Feb 21 10:56:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 35322 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 458941B1AF; Wed, 21 Feb 2018 11:56:17 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D1D331B1AD for ; Wed, 21 Feb 2018 11:56:15 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Feb 2018 02:56:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,543,1511856000"; d="scan'208";a="19962407" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.77]) by orsmga006.jf.intel.com with SMTP; 21 Feb 2018 02:56:12 -0800 Received: by (sSMTP sendmail emulation); Wed, 21 Feb 2018 10:56:10 +0000 Date: Wed, 21 Feb 2018 10:56:10 +0000 From: Bruce Richardson To: Hemant Agrawal Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20180221105609.GA2532@bricha3-MOBL3.ger.corp.intel.com> References: <1515769212-24122-1-git-send-email-hemant.agrawal@nxp.com> <1519200571-12620-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1519200571-12620-1-git-send-email-hemant.agrawal@nxp.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH v6] kernel folder for Linux and BSD modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Feb 21, 2018 at 01:39:31PM +0530, Hemant Agrawal wrote: > This patch moves the kernel modules code from EAL to a common place. > - Separate the kernel module code from user space code. > > Signed-off-by: Hemant Agrawal > Tested-by: Bruce Richardson > --- > v6: added meson build support > v5: rearrange kernel compliation as per Bruce's suggestion > v4: update the path in MAINTAINERS > v3: move contigmem from bsdapp > v2: rename kern to kernel, add freebsd modules as well > Hi Hemant, from testing on FreeBSD, I believe these are the changes needed to allow compilation with meson there. Nothing too drastic - mainly fix up the folder names, and skip the subdir into the higher-level "freebsd" folder. /Bruce diff --git a/kernel/meson.build b/kernel/meson.build index a5d5df7dd..697c419b6 100644 --- a/kernel/meson.build +++ b/kernel/meson.build @@ -13,7 +13,6 @@ if host_machine.system() == 'linux' elif host_machine.system() == 'freebsd' dpdk_conf.set('RTE_EXEC_ENV_BSDAPP', 1) - subdir('freebsd') kmods = ['contigmem', 'nic_uio'] # for building kernel modules, we use kernel build system using make, as @@ -26,9 +25,9 @@ elif host_machine.system() == 'freebsd' '-I' + join_paths(meson.source_root(), 'config'), '-include rte_config.h'] foreach k:kmods - subdir(join_paths('bsdapp', k)) + subdir(join_paths('freebsd', k)) custom_target(k, - input: [files('bsdapp/BSDmakefile.meson'), sources], + input: [files('freebsd/BSDmakefile.meson'), sources], output: k + '.ko', command: ['make', '-f', '@INPUT0@', 'KMOD_SRC=@INPUT1@',