From patchwork Mon Mar 12 17:05:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongseok Koh X-Patchwork-Id: 35989 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 160B22C01; Mon, 12 Mar 2018 18:06:14 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0045.outbound.protection.outlook.com [104.47.2.45]) by dpdk.org (Postfix) with ESMTP id 528D8E5D for ; Mon, 12 Mar 2018 18:06:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EFywS8qQ49GJw1e5htqZvA2MREQznPAfOd9RQXGGajk=; b=OxJhcSRfhNLsKCH6CWPeJJxchKGoo/QMwwG5+XOW2AJDzR79nB3tZvMgXVLzVhf/VHY1NpDTcbMXHFw2yIPsIutuFjhIgbNKsHVKqHSNZeueKbCHwdk9ynzHxD+t0xwXDtHnEBn9DJlzDzcZO/SfpBz39/0Bdpg0COxEc1eutOI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by VI1PR0501MB2045.eurprd05.prod.outlook.com (2603:10a6:800:36::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Mon, 12 Mar 2018 17:06:09 +0000 From: Yongseok Koh To: adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Cc: dev@dpdk.org, Yongseok Koh Date: Mon, 12 Mar 2018 10:05:45 -0700 Message-Id: <20180312170545.16165-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CY4PR15CA0016.namprd15.prod.outlook.com (2603:10b6:910:14::26) To VI1PR0501MB2045.eurprd05.prod.outlook.com (2603:10a6:800:36::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 71517bc2-e44f-4b81-f91b-08d5883b8d8a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2045; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 3:06RNc1Md+1H0SSRU7RoHIFIHIz9lASzJDWdF/70I12+hNmaOO6iVGRM0p18McFffz5hLIWJrL05ug7dHJXHRJakeL5cKszRupaPtSyxeIyOIeTpheikLJGV4k2M5x8US1fHaojBeptu6ADdT3fQJq2q2YJcURn5LABG/wcjdqq4/7PfnQ1Wvf1YnDRstCAH8HMEMS0ZIpmQNPv+sEWgEM65VMXngfO5FDtu/XKib8rnpBfWG1KHaBqagvjMxe54m; 25:iQuLQG3xdSF2kzr2dHjgXa1Zm1yFop+M70KYADUixytG6TLSpKGHbZJGASn7cSLsGR+H4sqBsVsg2Y9RxgG01TGWLmvQrEML6XySRzI2FHqyEhytfF28gIDEvLp4oYaaZfxp2EXi8FExX46hrb/f7wwSCJTa/22/uYqZ934nBWaFL42NO43t7UDeTNsBo/BM7L+nwTr5NSU0J0iWWsp5zWB0v07bsE9ZcV+OpzJWG6Hf6ZgBHxSiGXf4whplPELRQmN7OrRniZl1IvmP03VpWjiBcGFZPykLRn4G5exe3aUWSYJA/QpwMVpue+uQpcmMgloX+P3MtOfEpZVyHypPEg==; 31:KUnlivpT0MWJekPbnZOWTiAktt/loA5z51J5OJBNwWC5wtqHL2OAiV/kCwQFGSBkoOD1Er/xcmIcShQAdZLQHXpRmFZrjlUeNGrwDWf76KrX4WE7YaB5oV/8cRytB9dFou0/fhFd25FrJOTIJXYObfX9AeprPQFpNS+D2F70y/wLRQND/ikOhEYE4IyQOsOMUBFxNCeDuU4wxWnQmoIkaAykvqpD+GbbMDEbcxt5kWM= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2045: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 20:XKnNJHyxfKoT9mXMPl58+oo4kRjvQeZuWXFtPobZXgM9t49DyjPIXsWxSLz/6vEVbgNr0/xNG6geYrnh0QDJufiX2ZURmNGfCkcURsmwx6K4e1dodJGC0D/oC7pWiH0Ij+OWhldP7qrF1Upk+fufkUKoT3W6AhmVN5/lvdyb37v6aI7w+NwexyDwVDprHJG307rUr3cLyq5iIzyQUogHU80YqHmnnYyGp44FOT4BWj2mERTWlZ3sxFqwacElL3qluLWjitW6A7Hii8YDDy0y+/IZnpqqGLvpMuJxWNaTqDQ7/0uHkOK0B3Mt9ivrxgLgnC3yhUWBTKq6rsFZ1jaUt4u6dmpZVqfuKosy7+GC5tMdbb3uvDnfhdl75KQxp4I81AW0uShzF7WBau27tR615CnviViNAIScN0BVfsssC7UQFtryOOBOqTEUushKdsC2b3dzLLoVv+6bBe8kABlOI5Cpdc9rFztr3T/Nxhzpp0AT5/5dqNKYfDkvjT5Er3Kv; 4:eAVvGVsCvTfa4qgyIM55XXlKeeEkFJgWMnUcFVaGnDNdjaFH1nT/fVeK2Pg5QtNbWDoLjg8W+mF5vvAIL6CmRIg25VVvc4+h2m4QOopr5BVu6LBVINsSpTcGi6FOJDMRxNkr0LsEYY7y8VUODvZBgP415PuUT6fu/xX8P7xcXHhOkspTOKc8oVgjbEQkZU5dtdJuUsFzYirVnQm2hsJS1uiShzv45FgxMugnxM11phBorZu7ufg9TnYwOd3vJpQ7N0DF5oVY7yEKyjLvKGh5KQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231220)(944501244)(52105095)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:VI1PR0501MB2045; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2045; X-Forefront-PRVS: 06098A2863 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(39860400002)(39380400002)(396003)(189003)(199004)(105586002)(2906002)(1857600001)(36756003)(316002)(66066001)(47776003)(1076002)(3846002)(6116002)(50226002)(81166006)(81156014)(8936002)(68736007)(5660300001)(55016002)(106356001)(21086003)(69596002)(48376002)(16586007)(50466002)(97736004)(86362001)(7736002)(8676002)(4326008)(386003)(51416003)(25786009)(478600001)(305945005)(53936002)(26005)(16526019)(186003)(6666003)(7696005)(52116002)(107886003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2045; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2045; 23:NmrJxxXsDH57oFQdJ3n4Klmhyk88TnfXJcpjQMo?= mDJKalR/v6VOmx71audzu6Qmw0pnThT1tmN/S8Xry4PH+mBa9VMaAhaVJwBoak3goFHQj45Q6OaxVMi5gWRKfMmFIB0VgsA6OP0zw6HlP6eQFeIHpC/vrwDRC9dlkg0eIZFj0qBCWxXJ/sV04o9vZ40PqKgwxS6srKX8srP0eU2g958Hy45MLy44/CCgkXuu0cdhyisFAEEm1vOVfKmYzcnbFxAcH74LhUtA0JJnbws2c1NIs3HUoVuUKQevbC1kmC+EnxI+1AV/CVnDz5kuWfrZxcxnZM8osczBA2JaL7J904ZOIyNw7bf/yeQU/kBcmIJcj8MCBibJ96HHdzC720h2Cc258h8SiDjGB0Vn+tSIsGn48EB4ecfNWbkK1mVV6rEP/OiQsUF/YXZe51wT3S6DnWga+lIuWAorbtWNRLtouSxoVifLioq/Qj/rXdKJdKT6cTxgFNGE8enz3hVuXkJMJbi0OoGZL+iQpLRRRG170lJ7bBRBdHPZAsWbI3yPKWiHgJ6I3704hI+upBXJug+6ORgODNmlEHKjzZMmfrN/dzK2xuIccjF1o3C7gggaj3YkQtRn6ZoDJ/b4AEmWjwkxY4b9VfqVgyjtBlcGIa6Ueho39OmSuUpSS8wmjJ3cDIFg9QKxtuI5w1H7pWgphmPtbXUOkhfD+wThToR41QJsd/E8K2WT8hZtkC4zWsEBHE8xMzBwrOYDuaUaZQxpmJqrw7564BNQ/kwtWRNe4b0YncplWlzWDsi0tSaWkG6Pyi9rdTO3azmoIDou7x8N9k3P7Z6RaiwjgBQpwzfe00InANrglCeNHVlCyNT1osGBBgxPc2jpew/nvnDG7NHMuhHUJHYrFk7K1zVxxmclprF6gahO5oucFeNbjPyxsNqYazkmKPLoUiFk8Yqn7LqFbzzADHBKBLq4ihAASckUEgwTHSSVFlIsyoD7PEGZUucS1EMitChtVPonrvVBPpns1yKvo//76RGnLjexShtzGHyORNUqkwQ4PKbKdRMgyAFrtFvxhaIIaGwb9q1j9vly6zdHPeGqV9I5pBESBmuCKKlBvbd9x1PTfACoUGKleRrFtxMg= X-Microsoft-Antispam-Message-Info: 3xQTdpVhKxk2xTT1sw44kvB23c0DIbRt4hXRVLlrN7VLiwyHB0U/AFq310OEMfgALXWaAu4YA89pI1r4qYf1XfFKiez/BDx7OFAqYXTyxeBthUYpwUtClV8aEbuEpgEnlV+e3qX1R856RFmwKwnCeyxF/Xk8O/CAC2cGsHL/u7XrGNR1PC9xPvJxv6NTsM42 X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 6:WdN+U/zBv9bo8MHuaFBd+uP/iv+GJTND1ZRGIM/LAKyvCq4zBjkrgwzMdAZ3TxVtMXuu9XfkJCCaHJ9RhoHhZyC1U+zFEgw/oH12Gzr4WanqRw39efirJJ8CTK9ufqGz3T/qYJT+1gRajFZrefbIAhZotwTBE1op9NkAsy2tIruxxGC3Y0qT2J2koVm1b84+YsUu5FEIAiIy1mWrewZxLtCdlrGtFQkl1O/QUOjYl07WC4AHDEtPtzKNt7iwRENjJ9D1cDzgrLI/yF02q08TyW2GnIlOCSH0lUoxagTAtmpKT1LX2IBi7kA9TvRmtK9A0WignNMtr9vovDE50Y148xoPOh7IpNoKrZuWmBhDBX8=; 5:IFI7wYtMbUQiM4BBUm4dKLyHlXVVEZewVQE2Ae/xQAQ+cFmPIU4m1y4ygXUiKMc9KU4vOVa2OYkvo0B1OqsLNX2QjSZ/LzAQRgQjCIOaGG4+A/Yv+CWvcd02/V01ZtiyQr1c4l05IHDARK7ExVf3WcAxDF2MUutmUROfpGf2Wlc=; 24:9nzRMNP58j9bbfP6oHenbN6OWJJwUh23AAvQNp5PejkSnXH5bVZvQy/eINIVsxg+beiFVcx0eObX0ldyxGGrH9nCyzN46WdoW17YuZl8O1E=; 7:cKFI/PiL6eIuY8FWs6sW2SfNRpXiYiVIZvWICR2hvP8/mDOvduLJMxKb/dZEFOloO2UGCrd1/VETn1UNuJSg2hf4+Q0VupsnV/mIE6IstF/Y9WNBzQvPFuvItzpVr667ain2XCpwB0Y0f6Lw73syCk6FIdZyXfJYlsTJsfzaLW7D3L/1JJR0I454UKtGdZA9kmY9pMIiLFlao/k5nuCjJLoli86WwC/mtn4NcXcJfPLz/R7R/j16k4z23MBnAbkz SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2018 17:06:09.1779 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71517bc2-e44f-4b81-f91b-08d5883b8d8a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2045 Subject: [dpdk-dev] [PATCH] net/mlx5: remove excessive data prefetch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In Enhanced Multi-Packet Send (eMPW), entire packet data is prefetched to LLC if it isn't inlined. Even though this helps reducing jitter when HW fetches data by DMA, this can thresh the LLC with evicting precious data. And if the size of queue is large and there are many queues, this might not be effective. Also, if application runs on a remote node from the PCIe link, it may not be helpful and can even cause bad results. Signed-off-by: Yongseok Koh Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_rxtx.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 049f7e6c1..c2060b734 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -1320,7 +1320,6 @@ txq_burst_empw(struct mlx5_txq_data *txq, struct rte_mbuf **pkts, do { struct rte_mbuf *buf = *(pkts++); uintptr_t addr; - unsigned int n; unsigned int do_inline = 0; /* Whether inline is possible. */ uint32_t length; uint8_t cs_flags; @@ -1440,11 +1439,8 @@ txq_burst_empw(struct mlx5_txq_data *txq, struct rte_mbuf **pkts, ((uintptr_t)mpw.data.raw + inl_pad); (*txq->elts)[elts_head++ & elts_m] = buf; - addr = rte_pktmbuf_mtod(buf, uintptr_t); - for (n = 0; n * RTE_CACHE_LINE_SIZE < length; n++) - rte_prefetch2((void *)(addr + - n * RTE_CACHE_LINE_SIZE)); - addr = rte_cpu_to_be_64(addr); + addr = rte_cpu_to_be_64(rte_pktmbuf_mtod(buf, + uintptr_t)); *dseg = (rte_v128u32_t) { rte_cpu_to_be_32(length), mlx5_tx_mb2mr(txq, buf),