From patchwork Fri Apr 6 11:30:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh X-Patchwork-Id: 37356 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07E821CF58; Fri, 6 Apr 2018 13:31:09 +0200 (CEST) Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0075.outbound.protection.outlook.com [104.47.41.75]) by dpdk.org (Postfix) with ESMTP id E53251CF4B for ; Fri, 6 Apr 2018 13:31:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5G91CDSPeyYrOHFexoJGkXcVEzn9y6Ba4K8j/E9WhvQ=; b=SRYvER9QKy2PsacDDC/tyHz7M6+FSvtNJOnCbugkgj5YyvUW3OL8ni/Loh4VRTltUVbOHbiq7GDNvBDSpLV1HxFWo1Y75gIBtpYvZlB+7ZWdqtqe7y88NhaeL3u+mwhRleCwHujcODayinUvBhQSJtyKvxzrLm8B723VFUEzDPI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn.caveonetworks.com (111.93.218.67) by DM5PR07MB3467.namprd07.prod.outlook.com (2603:10b6:4:67::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Fri, 6 Apr 2018 11:31:02 +0000 From: Pavan Nikhilesh To: jerin.jacob@caviumnetworks.com, ferruh.yigit@intel.com, pascal.mazon@6wind.com, vipin.varghese@intel.com, thomas@monjalon.net Cc: dev@dpdk.org, Pavan Nikhilesh Date: Fri, 6 Apr 2018 17:00:31 +0530 Message-Id: <20180406113031.30340-1-pbhagavatula@caviumnetworks.com> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR0101CA0043.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::29) To DM5PR07MB3467.namprd07.prod.outlook.com (2603:10b6:4:67::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1e3f9305-880a-43eb-23b1-08d59bb1e242 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(2017052603328)(7153060)(7193020); SRVR:DM5PR07MB3467; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 3:+BhBEMDyogGibgIuE7pMCYikJeYjtJmmM153+UIhMTJxg0+3H20YDNwosRekQAMfZ7n8Bscqg7Fjevyg4vVdmqAXtSIMefWjgnzM6fKS1NJOBxGeykLS03h2tiOHGdxMgiR7SrluEaA2W9VyXEMGT27FLWexXMRPj15/py66EovAR+Ruah202ztsfDAZuRJRPai8jF4nAgl8vP4fyMTgGTJGy2N61uQdDwjDecvwaxy8UUpK0u+MfmAhtz30iCjK; 25:p+ZJer17z1YbH/cd6uRXFqx+mYWL5dn6LqyPzaH3Jj/xTnnHoDxCdP4bK7UgOqDMJ/o7Re7ktI4oXpR9qUyeMWX+YdG/dhyowyOnyh4ayQkeeUKaFBPm2ML0xSoE1Vu5qaoBMcIsjXVkmZPi2/DO7KyWkQNmw0wOcO5bGH24CQoYurxeAGSpG70caS9j8T4meTloFYeFVZ9fBepaLsNsmqPOfHzbV9mA7NNhUaQ7qYfMyLaGYkhhCcKtG0l6KSvHp4umFq1Wld0Issm9Pcw7vOLQPgRmx/tjWjnkhJ65B2EdKP1zv4vqBdVYl9ZcHEj8Un/4K39aAf35f9Bp1Xo7mg==; 31:hfCcNvGB1VCtdqySZtEP/deA75jDQg5Rp18z4LbZYzYawcsZ5IpyKoGXlmtoWKX6KzgsqpKhrCniyZfZ4o+nIuQ+Q1v8XmeiCR7j+bobNZGsu3Oo5+fZj5xj2qgC+MPh5MsK/1Zuvini6oxmDp/roV/GAMKZ1EUf5F5jCtDi2kR6CAdUAd48CHTh7le+DwGZx9AqJNI8tzhdyIgMQbCWiBRnOUwZtlvTqp7NFnwGHzc= X-MS-TrafficTypeDiagnostic: DM5PR07MB3467: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 20:YY825v2YS8ZV2X74SoZ3rtrx679mkLgXqYvTSAJVMo2CWQQ4mO/VjMsQsVcJrTiqjec7j3Y/cFayzelgvqce0LHB2M0duvEMNB9kJ3LIMT6E2zf0tZfJUjY6zXg++DFoATY+Ch3/GqjHCEfT5AkFZuO7P0h5MbOgOXTbjNzWHYc+FEYN7bZ9f3vVDSEWAGHc1LRunlosMzDA5Uk7DQC4SfZMfSs/gzF0kC4eoYGQzg7GdmNevaClbWP92F+Vo01LCcRTWrHX0MJOyQ0Swhriy4S8bqGRYUv2K+q5Y4nRkLbxndxHMsYqIOI/gmAucauMdwWGtAZrPjf4wImEphL1tt++gMvQZm5BZlECnRa5rcT7HH2rgGqlWEjbY0wsObT7vy8Aw6Yltqphqan1HUGR2JtYxSDuWoXM7MePMsY7Ln9jhzkzEwCwHP8pkNnmwVChB2LO4Q+zk8RF6QDNYX7g1kWyZzRWEb15kG5ng4FhbAlnfLpg0bWbcyZbMq3LsViAYm4Faz/yJSqnljOAwZC8JyO5k62z1zSmJLKVbqJkPxGHg65iKX6HtH6yK3AT8bqHPnDvwQwKVzF4KFeTFJJF3M6OuMGs7nkLq9Wu8op3/OI=; 4:RTwY2RWc79IYfxZe86dQEtwWTr58Py9zFs/EZCOiUj1BBg+wRpch+D6p72HgRX1ZWi3GS8LeQaA05dxwtlceE1oGSJyxIFJs7PQ9l4e60AG7ueazgaQRW01exPHNV7D1tWd9YrJzPMTSDJKqSnadO3JHqjLJE2dj9ds7BMsOhj65JoJ7GiHguC95TkjHMXpFoz1FiADaKFrcrf5UwXFPIbisHF7xbdIgIc98E8OTPMpb6VnQUEyjC2L7O1e+IZ3kSqFbv5ctl7Lct0lpj1uPVg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3002001)(3231221)(944501327)(52105095)(6041310)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:DM5PR07MB3467; BCL:0; PCL:0; RULEID:; SRVR:DM5PR07MB3467; X-Forefront-PRVS: 0634F37BFF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(376002)(39850400004)(366004)(396003)(39380400002)(346002)(199004)(189003)(52116002)(51416003)(5660300001)(50466002)(48376002)(476003)(81156014)(59450400001)(8676002)(2616005)(8936002)(81166006)(1857600001)(107886003)(50226002)(4326008)(106356001)(7736002)(16586007)(316002)(486006)(305945005)(3846002)(6116002)(36756003)(26005)(68736007)(6506007)(386003)(42882007)(6512007)(97736004)(53936002)(1076002)(16526019)(72206003)(956004)(66066001)(2906002)(25786009)(47776003)(6666003)(5009440100003)(69596002)(478600001)(105586002)(53416004)(6486002)(42262002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3467; H:ltp-pvn.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3467; 23:e+SVUI3Qc7X5GUCCnbfAoFjf/6Og5VnW8H/yR+zhz?= 4XJ1cMJmfhHf7D+NB+HB8ej0uOFpP/nxUWNclEI1tFUqNy3SSjb98EDwZ+S/grAfgpFXW9W5/SkFOKLQvnxAOhGO2tREWAM8s691gIgb0ARhp9LPozJm/V2vEDhv22PLamTvNPSV8wCKqeNyaNiam3JK+hXBe1PjwoXBLcD8c/OxLGDRTHE5tE95lLFh75aSt3IzcXnSCtOHhs9VRLFSPteIU7f0D6QpGw+Fj35+atbrG+JmWFdhSVr4jGENsJ/JolgObdNcJS1O/Zu8sZpGS0RaQMAVPJ3X0DuY5PBZobRWHaRxSO8SWIJqjrQGzPuiKZg2H8Xb4cMAC0iB3IlZJqxPi31mYi1CuHLDtZ+3lbSKVJgTImzBL3zdJ5/IQp9V7spjlNbbphmAEkTbp/rMPkzbJTVSp7YRWRdSSewqIptc2as3d1Lp3exXseinWK6deqtUp/vvsEr+hscfr0y7hoYfZ2/73CnFrRwpJ6SHQ+M4gHIT5xQTnMVwswRBWXT42dMKBSecDzbDz+9ZiuxRe4rabUdKgjsQV8H0kMzAgMwIyUZTlBV3ts3lq5fcqstx9QUncNloWxScGo6f7Tdi6UYIXI5cGDYLyq1uAkBOF0IJhOUMY6EIwIYOPA/SRKdVeMYpYXFRCHJSUH1OpXI1m7EngKw3HSwJPNOFRooUrpqeB1M/yi7JdEpYamNQxeMO7Kz/SzodHWAHwp9qUMN6CqG5OZeMRgXTM+o0JKiKoP9jJRSIjQsPTHxBRaaaujBP7r9y7ZxsYXzvFPRbf2323Qiy6cNF57CcKG1SnWkPft8q+H4lqwRLR9gA1VJJS4N5ErUkG9+Oo8q/GpOjCCUf+z4djmy7NlyArU+Vo4LAph/yzosD4Z7JmFkeLGuyg1CZ7TJFdFe5foZKsRh6vZIhTDw8fKXWOYYEMSX4u188x/W0+XAM0HaGx8buhok0MGMuTAwjssWbuzHbVj/y3ZiaOBcRF7ClyD3aqpbf7AH+DO9LqpWDrhs+agBUe4eA7ZJ7hTSAGUt9tTK17sqglVutMgNDvdjV2PHynPQk/VjDLUrmfenZFu2A62OZh5cI5rBYupFSJh4coyLTUY4k8NfKjc6I29VeRh3gYqHKnwvxooIgQ7z0QU6g1EsgPFUupNduIXZ52sIP8P0msniy3WhZPBtRZDYlfvrn8S7CyQ13VB/MMhJDSN2MstLkcUHE6lPlwyjI+euwYX8pp4H7vl+FjAgSqh7w9/sZSuU2w1XXrjZBhq92Yv7S0fRWms+jiMP/hFCIJTpjohGhYoL3bLrWJx8LnSBau1f9sWzANQx2jY7xjBXSNKm6H+QUQhVsmwy7cf8Q85nJhyTrq5AN5BMmMUF X-Microsoft-Antispam-Message-Info: 063wv5vmcM6/A4Cg4tSQYMc3oRpYgoDccDVNrZ9X4Pr5Z+x73J3gCsYKP1ZfLQQXY2wloJBTBgywJGcbj5w2AcT9tnUU3Yhz8J545u1iX5xYIshrGWU1KlyShYN4wHr3L5TFluhrpXQjwzZ1cFVetvnX3GEU//h9rSMm2XYAy+u79gP8NNEu1cHQHjOderep X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 6:65YCczQzz7kKCPGZxljgP4aBte4svZ6mIdOHWn+gu2G7Q/MxI7N6psMJxZyRBwcpqIYf2lgN9IYPeHbS49RslJRwwJ9asFfAhC7w7yUU4Rzs+EhJwsa54iG4a9ToI8PvXWuJr8pcVWtzBCAO/0fuG9M31mOGEO+yBgMBVcPNUoVsnzte6z9aV9yqMsdwWWM7HdA26OGYOJgKm0UQo2LuqrSIGJ7IYXW5+pOtM87/LbYRDzjFicFq8xk9GCs2O6uWXIrEPBgnBIJz3/8aJDuqEMkqCIg3qFzKDJsa+uZH/z05rpnT0VbnyTyhxwJrPWb1B/4C1iPjWH8IrdF0ChTj3wHG0yzIQDYHFf20b97NP4QlAlskGgB2btVLpdq8sqxsnL80HlptSMyogHAS5NdOXIGjJ8KUtTQ3AQ9X9uKlOgpT5XTcWv3CUqMXERlCAC7s7xsbQP6arSthqojB92tIdQ==; 5:HPcqfpvvvSYdK3c+xa7kbcjxI8h22eoU9QEwNx3rFLnnxbKI1mDLXxspvZ2helNEYvvmRjQsWe3bXVV3XBo6gA5uq74cYya6SkNM+7RTAP0J/z+LljiitCoLxLVxL7QGaa2/4wYSvkWXjzOmVxGMyxwSIX6SH6bWN7S/kRF7328=; 24:9XO/OOhoh7A4aNGhL9dX7BaZmv8Xe0WgnIktEWyIaJ3CB3x+zi4/z9cNnxp4Minxwy2Xt7c53pxhkyDhi1vUsMTUx69YPYxAm97gO4gdnMY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3467; 7:kiy1qNkSpyJ3ni73cCkhxj8OlQKocdSAFUrgiz0iyh57axboOETz3HEtv40xFW4VL5id4PA+p/vEIZxWnYN91L9T/NdyFOgRGnq/jEFi2mPx36Kt/UVH3XNBO7wQ7yRj0n2PRal/odxc5WeIkOKOFmdL3UFx4lIjItTxWHnvCWKeAh7+dzvNAUU7qZlZlfCxf7zKhv2J8W9mmub1KrVns1dtyvcQQiOQpor3qxec9uJ0J+E3PS+UTsxexaN9Qz3l X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2018 11:31:02.5517 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1e3f9305-880a-43eb-23b1-08d59bb1e242 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3467 Subject: [dpdk-dev] [PATCH] net/tap: fix memcpy with incorrect size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix incorrect sizeof operation being used for getting mac addr size. Found while compiling with arm64 clang. drivers/net/tap/rte_eth_tap.c:1410:40: error: argument to 'sizeof' in 'memcpy' call is the same pointer type 'struct ether_addr *' as the destination; expected 'struct ether_addr' or an explicit length [-Werror,-Wsizeof-pointer-memaccess] rte_memcpy(&pmd->eth_addr, mac_addr, sizeof(mac_addr)); ~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~ Fixes: bcab6c1d27fa ("net/tap: allow user MAC to be passed as args") Signed-off-by: Pavan Nikhilesh Acked-by: Zhiyong Yang --- drivers/net/tap/rte_eth_tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 3e4f7a8e8..6ed4a8a02 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -1406,7 +1406,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name, if (is_zero_ether_addr(mac_addr)) eth_random_addr((uint8_t *)&pmd->eth_addr); else - rte_memcpy(&pmd->eth_addr, mac_addr, sizeof(mac_addr)); + rte_memcpy(&pmd->eth_addr, mac_addr, sizeof(*mac_addr)); /* Immediately create the netdevice (this will create the 1st queue). */ /* rx queue */