| Message ID | 20180418000020.6229-1-johndale@cisco.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ferruh Yigit |
| Headers | show |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/Intel-compilation | success | Compilation OK |
On 4/18/2018 1:00 AM, John Daley wrote: > A local variable was used without initialization and triggered a > coverity issue. > > Is is fixed here, but there is no ill effect of not initializing > the variable in this case. 'rxq_interrupt_offset' is irrelevant > if 'rxq_interrupt_enable' is not set (the condition caught by > coverity). > > Fixes: fc2c8c0668fd ("net/enic: use Tx completion index instead of messages") > Coverity issue: 268314 > > Signed-off-by: John Daley <johndale@cisco.com> > Reviewed-by: Hyong Youb Kim <hyonkim@cisco.com> Applied to dpdk-next-net/master, thanks.
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index 822037ce8..2a2269794 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -200,15 +200,14 @@ void enic_init_vnic_resources(struct enic *enic) unsigned int error_interrupt_enable = 1; unsigned int error_interrupt_offset = 0; unsigned int rxq_interrupt_enable = 0; - unsigned int rxq_interrupt_offset; + unsigned int rxq_interrupt_offset = ENICPMD_RXQ_INTR_OFFSET; unsigned int index = 0; unsigned int cq_idx; struct vnic_rq *data_rq; - if (enic->rte_dev->data->dev_conf.intr_conf.rxq) { + if (enic->rte_dev->data->dev_conf.intr_conf.rxq) rxq_interrupt_enable = 1; - rxq_interrupt_offset = ENICPMD_RXQ_INTR_OFFSET; - } + for (index = 0; index < enic->rq_count; index++) { cq_idx = enic_cq_rq(enic, enic_rte_rq_idx_to_sop_idx(index));
A local variable was used without initialization and triggered a coverity issue. Is is fixed here, but there is no ill effect of not initializing the variable in this case. 'rxq_interrupt_offset' is irrelevant if 'rxq_interrupt_enable' is not set (the condition caught by coverity). Fixes: fc2c8c0668fd ("net/enic: use Tx completion index instead of messages") Coverity issue: 268314 Signed-off-by: John Daley <johndale@cisco.com> Reviewed-by: Hyong Youb Kim <hyonkim@cisco.com> --- v2: fix typo drivers/net/enic/enic_main.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)