From patchwork Wed Apr 25 14:15:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 38924 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CEBD37CDB; Wed, 25 Apr 2018 16:15:27 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id D7A2D7CDA for ; Wed, 25 Apr 2018 16:15:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2018 07:15:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,326,1520924400"; d="scan'208";a="49014398" Received: from silpixa00399777.ir.intel.com (HELO silpixa00399777.ger.corp.intel.com) ([10.237.222.236]) by fmsmga004.fm.intel.com with ESMTP; 25 Apr 2018 07:15:23 -0700 From: Ferruh Yigit To: Wenzhuo Lu , Jingjing Wu Cc: dev@dpdk.org, Ferruh Yigit , qi.z.zhang@intel.com Date: Wed, 25 Apr 2018 15:15:09 +0100 Message-Id: <20180425141509.160899-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.14.3 Subject: [dpdk-dev] [PATCH] app/testpmd: update start log to be less verbose X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A per port per queue log is too verbose with multiple port/queue log is longer than full screen, make it less verbose: - Reduced log to only first queue of the port, as a sample - Merged a few lines - Indent queue logs for readability The log becomes as following after update: testpmd> start tx_first io packet forwarding - ports=2 - cores=1 - streams=8 - NUMA support enabled, MP over anonymous pages disabled Logical Core 1 (socket 0) forwards packets on 8 streams: RX P=0/Q=0 (socket 0) -> TX P=1/Q=0 (socket 0) peer=02:00:00:00:00:01 RX P=0/Q=1 (socket 0) -> TX P=1/Q=1 (socket 0) peer=02:00:00:00:00:01 RX P=0/Q=2 (socket 0) -> TX P=1/Q=2 (socket 0) peer=02:00:00:00:00:01 RX P=0/Q=3 (socket 0) -> TX P=1/Q=3 (socket 0) peer=02:00:00:00:00:01 RX P=1/Q=0 (socket 0) -> TX P=0/Q=0 (socket 0) peer=02:00:00:00:00:00 RX P=1/Q=1 (socket 0) -> TX P=0/Q=1 (socket 0) peer=02:00:00:00:00:00 RX P=1/Q=2 (socket 0) -> TX P=0/Q=2 (socket 0) peer=02:00:00:00:00:00 RX P=1/Q=3 (socket 0) -> TX P=0/Q=3 (socket 0) peer=02:00:00:00:00:00 io packet forwarding packets/burst=32 nb forwarding cores=1 - nb forwarding ports=2 port 0: RX queue number: 4 Tx queue number: 4 Rx offloads=0x1000 Tx offloads=0x0 RX queue: 0 RX desc=0 - RX free threshold=32 RX threshold registers: pthresh=8 hthresh=8 wthresh=0 RX Offloads=0x1000 TX queue: 0 TX desc=0 - TX free threshold=32 TX threshold registers: pthresh=32 hthresh=0 wthresh=0 TX RS bit threshold=32 TX offloads=0x0 port 1: RX queue number: 4 Tx queue number: 4 Rx offloads=0x1000 Tx offloads=0x0 RX queue: 0 RX desc=0 - RX free threshold=32 RX threshold registers: pthresh=8 hthresh=8 wthresh=0 RX Offloads=0x1000 TX queue: 0 TX desc=0 - TX free threshold=32 TX threshold registers: pthresh=32 hthresh=0 wthresh=0 TX RS bit threshold=32 TX offloads=0x0 Fixes: 266f28b91e34 ("app/testpmd: enable per queue configure") Cc: qi.z.zhang@intel.com Signed-off-by: Ferruh Yigit --- Hi Qi, If you are agree with the patch I can squash into original patch. btw, desc numbers are zero, "TX desc=0","RX desc=0", is this correct? --- app/test-pmd/config.c | 35 ++++++++++++++++------------------- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 216a7eb4e..a5bfda140 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1776,43 +1776,40 @@ rxtx_config_display(void) uint16_t *nb_tx_desc = &ports[pid].nb_tx_desc[0]; /* per port config */ - printf(" port %d:\n", (unsigned int)pid); - printf(" Rx offloads=0x%"PRIx64"\n", - ports[pid].dev_conf.rxmode.offloads); + printf(" port %d: RX queue number: %d Tx queue number: %d\n", + (unsigned int)pid, nb_rxq, nb_txq); - printf(" Tx offloads=0x%"PRIx64"\n", + printf(" Rx offloads=0x%"PRIx64" Tx offloads=0x%"PRIx64"\n", + ports[pid].dev_conf.rxmode.offloads, ports[pid].dev_conf.txmode.offloads); - printf(" RX queue number: %d\n", nb_rxq); - - /* per rx queue config */ - for (qid = 0; qid < nb_rxq; qid++) { + /* per rx queue config only for first queue to be less verbose */ + for (qid = 0; qid < 1; qid++) { printf(" RX queue: %d\n", qid); - printf(" RX desc=%d - RX free threshold=%d\n", + printf(" RX desc=%d - RX free threshold=%d\n", nb_rx_desc[qid], rx_conf[qid].rx_free_thresh); - printf(" RX threshold registers: pthresh=%d hthresh=%d " + printf(" RX threshold registers: pthresh=%d hthresh=%d " " wthresh=%d\n", rx_conf[qid].rx_thresh.pthresh, rx_conf[qid].rx_thresh.hthresh, rx_conf[qid].rx_thresh.wthresh); - printf(" RX Offloads=0x%"PRIx64"\n", + printf(" RX Offloads=0x%"PRIx64"\n", rx_conf[qid].offloads); } - printf(" Tx queue number: %d\n", nb_txq); - - /* per tx queue config */ - for (qid = 0; qid < nb_txq; qid++) { + /* per tx queue config only for first queue to be less verbose */ + for (qid = 0; qid < 1; qid++) { printf(" TX queue: %d\n", qid); - printf(" TX desc=%d - TX free threshold=%d\n", + printf(" TX desc=%d - TX free threshold=%d\n", nb_tx_desc[qid], tx_conf[qid].tx_free_thresh); - printf(" TX threshold registers: pthresh=%d hthresh=%d " + printf(" TX threshold registers: pthresh=%d hthresh=%d " " wthresh=%d\n", tx_conf[qid].tx_thresh.pthresh, tx_conf[qid].tx_thresh.hthresh, tx_conf[qid].tx_thresh.wthresh); - printf(" TX RS bit threshold=%d\n", tx_conf->tx_rs_thresh); - printf(" TX offloads=0x%"PRIx64"\n", + printf(" TX RS bit threshold=%d\n", + tx_conf->tx_rs_thresh); + printf(" TX offloads=0x%"PRIx64"\n", tx_conf[qid].offloads); } }