eal:missing newline on RTE_LOG msg
Checks
Commit Message
Add a missing newline to a RTE_LOG message.
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
---
lib/librte_eal/common/rte_option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Keith,
On Sun, Dec 16, 2018 at 05:01:03PM -0600, Keith Wiles wrote:
> Add a missing newline to a RTE_LOG message.
>
I think it might interest stable@dpdk.org, and you might as well include
a fixline reference.
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
> lib/librte_eal/common/rte_option.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c
> index 02d59a869..7605190c3 100644
> --- a/lib/librte_eal/common/rte_option.c
> +++ b/lib/librte_eal/common/rte_option.c
> @@ -36,7 +36,7 @@ rte_option_register(struct rte_option *opt)
> {
> TAILQ_FOREACH(option, &rte_option_list, next) {
> if (strcmp(opt->opt_str, option->opt_str) == 0)
> - RTE_LOG(INFO, EAL, "Option %s has already been registered.",
> + RTE_LOG(INFO, EAL, "Option %s has already been registered.\n",
> opt->opt_str);
> return;
> }
> --
> 2.17.1
>
17/12/2018 10:25, Gaëtan Rivet:
> Hi Keith,
>
> On Sun, Dec 16, 2018 at 05:01:03PM -0600, Keith Wiles wrote:
> > Add a missing newline to a RTE_LOG message.
> >
>
> I think it might interest stable@dpdk.org, and you might as well include
> a fixline reference.
Fixes: 2395332798d0 ("eal: add option register infrastructure")
Cc: stable@dpdk.org
> > Signed-off-by: Keith Wiles <keith.wiles@intel.com>
Applied, thanks
@@ -36,7 +36,7 @@ rte_option_register(struct rte_option *opt)
{
TAILQ_FOREACH(option, &rte_option_list, next) {
if (strcmp(opt->opt_str, option->opt_str) == 0)
- RTE_LOG(INFO, EAL, "Option %s has already been registered.",
+ RTE_LOG(INFO, EAL, "Option %s has already been registered.\n",
opt->opt_str);
return;
}